Re: [pve-devel] [PATCH pve-docs] Add section for ZFS Special Device

Thanks for the review and suggestions! I'll send a v2 later, two replies inline. On 11/5/19 10:14 AM, Aaron Lauterer wrote: Nicely written. I have some suggestions inline: * splitting long sentences * adding more info as to what is valid for the size in special_small_blocks (taken from the zf

[pve-devel] first 20 nodes cluster upgraded to proxmox6 :)

Hi, I have finished to upgraded my first 20 nodes cluster to proxmox6. So far, it's stable, no corosync bug. qemu is working fine too. I just have ldaps auth not working, I have send a patch to the mailing this week. Alexandre ___ pve-devel mailing

[pve-devel] [PATCH v2 docs] Add section for ZFS Special Device

Signed-off-by: Fabian Ebner --- Changes from v1: * Reworded the part that describes when a special device is useful * Moved that part to the top, so people know right away whether it's interesting for them * Add note about values for the special_small_blocks parameter * Spli

[pve-devel] [PATCH docs] qm: fix typo: /ghen/When/

Signed-off-by: Christian Ebner --- qm.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qm.adoc b/qm.adoc index 9ee4460..429cff6 100644 --- a/qm.adoc +++ b/qm.adoc @@ -507,7 +507,7 @@ host. .Fixed Memory Allocation [thumbnail="screenshot/gui-create-vm-memory.png"] -ghen

[pve-devel] [PATCH lxc 1/2] postinst: ignore lxc.service reload errors

otherwise this could fail posinst execution (and thus package installation!) on systems coming from plain Debian, or where lxc.service is masked. Signed-off-by: Fabian Grünbichler --- Notes: noticed this when attempting to cleanly build pve-manager.. debian/lxc-pve.postinst | 2 +- 1 file

[pve-devel] [PATCH lxc 2/2] postinst: reload/restart lxc.service later

since the debhelper-generated default enabling should come before we attempt to start/reload/restart it. Signed-off-by: Fabian Grünbichler --- debian/lxc-pve.postinst | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/debian/lxc-pve.postinst b/debian/lxc-pve.postinst ind

[pve-devel] [PATCH manager] ui: vm opts: add hint for spice foldersharing

Spice foldersharing needs the webdavd daemon installed inside the guest. This patch adds a hint to remind the user to install it in the VM. Signed-off-by: Aaron Lauterer --- www/manager6/form/SpiceEnhancementSelector.js | 13 + 1 file changed, 13 insertions(+) diff --git a/www/manag

[pve-devel] [PATCH docs 1/2] use PVE::DataCenterConfig to get schema

Signed-off-by: Fabian Grünbichler --- gen-datacenter.cfg.5-opts.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gen-datacenter.cfg.5-opts.pl b/gen-datacenter.cfg.5-opts.pl index 1c687c9..37507e5 100755 --- a/gen-datacenter.cfg.5-opts.pl +++ b/gen-datacenter.cfg.5-opts.p

[pve-devel] [PATCH common 1/2] cert: add fingerprint helper

for usage in pve-cluster's certificate cache. Signed-off-by: Fabian Grünbichler --- src/PVE/Certificate.pm | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/PVE/Certificate.pm b/src/PVE/Certificate.pm index 5ab920f..2421f3f 100644 --- a/src/PVE/Certificate.pm +++ b/src/PVE/

[pve-devel] [PATCH cluster 07/16] move certificate cache to own file

and just keep node to certificate path helper in PVE::Cluster. Signed-off-by: Fabian Grünbichler --- Notes: in peparation of moving it to pve-manager altogether in the next patch requires versioned breaks on pve-manager (HTTPServer.pm) data/PVE/Cluster/Makefile | 2 +- data/P

[pve-devel] [PATCH cluster 06/16] move corosync_link schema to Corosync.pm

since it can be/is already used by all relevant files, and it is not related at all to pmxcfs. Signed-off-by: Fabian Grünbichler --- data/PVE/API2/ClusterConfig.pm | 4 ++-- data/PVE/CLI/pvecm.pm | 4 ++-- data/PVE/Cluster.pm| 31 --- data/PVE/C

[pve-devel] [PATCH common 2/2] bump version to 6.0-7~test1

Signed-off-by: Fabian Grünbichler --- debian/changelog | 6 ++ 1 file changed, 6 insertions(+) diff --git a/debian/changelog b/debian/changelog index a4f4ba5..06d9df2 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +libpve-common-perl (6.0-7~test1) pve pmg; urgency=mediu

[pve-devel] [PATCH cluster 04/16] move RRD creating into own file

Signed-off-by: Fabian Grünbichler --- Notes: versioned breaks on - qemu-server - pve-manager - pve-container - libpve-storage-perl could also move to pve-common instead. data/PVE/Makefile | 2 +- data/PVE/Cluster.pm | 125

[pve-devel] [PATCH cluster 15/16] pve-cluster.service: move pvecm call to pveproxy.service

since that is were we actually require a certificate/key to be present Signed-off-by: Fabian Grünbichler --- Notes: requires counter-part in pve-manager, and maybe a versioned breaks? this only really affects newly installed systems.. debian/pve-cluster.service | 1 - 1 file changed, 1

[pve-devel] [PATCH cluster 10/16] datacenter.cfg: parse/print u2f property string

when parsing config, like other property strings stored in this file. Signed-off-by: Fabian Grünbichler --- data/PVE/DataCenterConfig.pm | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/data/PVE/DataCenterConfig.pm b/data/PVE/DataCenterConfig.pm index 5f3f80a..77cc

[pve-devel] [PATCH cluster 01/16] d/control: add missing build-depends

Signed-off-by: Fabian Grünbichler --- this strictly speaking breaks bootstrapping - but it is already broken, we just no longer hide it. one solution for this would be to adapt libpve-cluster* and libpve-access-control* to optionally skip building their respective -api- binary packages to break th

[pve-devel] [PATCH cluster 13/16] d/control: add versioned breaks

for all the refactored/moved code Signed-off-by: Fabian Grünbichler --- debian/control | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/debian/control b/debian/control index c5e6962..03a03a7 100644 --- a/debian/control +++ b/debian/control @@ -48,7 +48,12 @@ Depends: cor

[pve-devel] [PATCH docs 2/2] bump version to 6.0-9~test1

Signed-off-by: Fabian Grünbichler --- Notes: depending on your build-env, you might need to touch datacenter.cfg.5-opts.adoc to prevent it from getting re-generated. debian/changelog | 6 ++ 1 file changed, 6 insertions(+) diff --git a/debian/changelog b/debian/changelog index ba0

[pve-devel] [PATCH cluster 02/16] remove unused Data::Dumper import

Signed-off-by: Fabian Grünbichler --- data/PVE/Cluster.pm | 3 --- 1 file changed, 3 deletions(-) diff --git a/data/PVE/Cluster.pm b/data/PVE/Cluster.pm index 9cb68d8..596d87e 100644 --- a/data/PVE/Cluster.pm +++ b/data/PVE/Cluster.pm @@ -34,8 +34,6 @@ cfs_write_file cfs_register_file cfs_lock

[pve-devel] [PATCH access-control 05/13] pveum: cleanup outdated use statements

Signed-off-by: Fabian Grünbichler --- PVE/CLI/pveum.pm | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/PVE/CLI/pveum.pm b/PVE/CLI/pveum.pm index 5fd15fe..c394535 100755 --- a/PVE/CLI/pveum.pm +++ b/PVE/CLI/pveum.pm @@ -2,20 +2,13 @@ package PVE::CLI::pveum; use stri

[pve-devel] [PATCH cluster 16/16] bump version to 6.0-8~test1

Signed-off-by: Fabian Grünbichler --- debian/changelog | 6 ++ 1 file changed, 6 insertions(+) diff --git a/debian/changelog b/debian/changelog index 6f14c8a..a3f92f1 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +pve-cluster (6.0-8~test1) pve; urgency=medium + + * te

[pve-devel] [PATCH cluster 08/16] move CertCache to pve-manager

Signed-off-by: Fabian Grünbichler --- data/PVE/Cluster/Makefile | 2 +- data/PVE/Cluster/CertCache.pm | 92 --- 2 files changed, 1 insertion(+), 93 deletions(-) delete mode 100644 data/PVE/Cluster/CertCache.pm diff --git a/data/PVE/Cluster/Makefile b/data/PV

[pve-devel] [PATCH access-control 08/13] use PVE::DataCenterConfig

since we read datacenter.cfg, and parse the u2f property string using a format defined in PVE::DataCenterConfig. Signed-off-by: Fabian Grünbichler --- Notes: needs a dependency on libpve-cluster-perl PVE/API2/AccessControl.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --

[pve-devel] [PATCH cluster 03/16] use PVE::Certificate to read fingerprint

instead of duplicating the whole "read certificate from file" code that we already have in pve-common. Signed-off-by: Fabian Grünbichler --- Notes: requires versioned dependency on libpve-common-perl data/PVE/Cluster.pm | 23 ++- debian/control | 2 +- 2 files cha

[pve-devel] [PATCH access-control 04/13] d/control: remove outdated dependencies

Signed-off-by: Fabian Grünbichler --- debian/control | 2 -- 1 file changed, 2 deletions(-) diff --git a/debian/control b/debian/control index c49b1e8..349a105 100644 --- a/debian/control +++ b/debian/control @@ -25,8 +25,6 @@ Depends: libauthen-pam-perl, libnet-ssleay-perl,

[pve-devel] [PATCH access-control 02/13] build: use dh_missing

to fail the build if files are installed, but not shipped in any package. Signed-off-by: Fabian Grünbichler --- debian/rules | 3 +++ 1 file changed, 3 insertions(+) diff --git a/debian/rules b/debian/rules index 955dd78..b6ca118 100755 --- a/debian/rules +++ b/debian/rules @@ -11,3 +11,6 @@

[pve-devel] [PATCH access-control 01/13] build: bump compat to 10

Signed-off-by: Fabian Grünbichler --- debian/compat | 2 +- debian/control | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/debian/compat b/debian/compat index ec63514..f599e28 100644 --- a/debian/compat +++ b/debian/compat @@ -1 +1 @@ -9 +10 diff --git a/debian/control b/d

[pve-devel] [PATCH cluster 12/16] get_ssh_info: try via API first

and only fallback to SSH in case it doesn't work. this will allow use to remove 'pvecm mtunnel' in the next major release! :) Signed-off-by: Fabian Grünbichler --- Notes: the downside of this is a dependency from libpve-cluster-perl to libpve-access-control

[pve-devel] [PATCH access-control 03/13] build: leave man page compression to dh_docs

Signed-off-by: Fabian Grünbichler --- Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/Makefile b/Makefile index cf0aa6b..df6f271 100644 --- a/Makefile +++ b/Makefile @@ -51,7 +51,6 @@ install: pveum.1 oathkeygen pveum.bash-completion pveum.zsh-completion install -d ${DESTDIR}

[pve-devel] [PATCH storage 1/6] use correct local IP address helper

this always uses an explicit CIDR, so we don't need a round-trip via datacenter.cfg .. Signed-off-by: Fabian Grünbichler --- PVE/CLI/pvesm.pm | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/PVE/CLI/pvesm.pm b/PVE/CLI/pvesm.pm index ae1bc3d..161b0a3 100755 --- a/PVE/CLI/pv

[pve-devel] [PATCH access-control 06/13] pveum: don't unconditionally create auth key

anything that uses it should already generate it anyway. Signed-off-by: Fabian Grünbichler --- pveum | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/pveum b/pveum index 196fb3a..34ed82c 100755 --- a/pveum +++ b/pveum @@ -5,9 +5,4 @@ use warnings; use PVE::CLI::pveum;

[pve-devel] [PATCH access-control 13/13] bump version to 6.0-4~test1

Signed-off-by: Fabian Grünbichler --- debian/changelog | 8 1 file changed, 8 insertions(+) diff --git a/debian/changelog b/debian/changelog index bbeebd7..59eb8d4 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,11 @@ +libpve-access-control (6.0-4~test1) pve; urgency=med

[pve-devel] [PATCH storage 6/6] bump version to 6.0-10~test1

Signed-off-by: Fabian Grünbichler --- debian/changelog | 12 1 file changed, 12 insertions(+) diff --git a/debian/changelog b/debian/changelog index 616abcb..a342cef 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,15 @@ +libpve-storage-perl (6.0-10~test1) pve; urgenc

[pve-devel] [PATCH storage 4/6] use PVE::RRD for RRD data

refactored from PVE::Cluster. same code, same semantics, different file. Signed-off-by: Fabian Grünbichler --- Notes: needs dependency on libpve-cluster-perl PVE/API2/Storage/Status.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Storage/Status.pm b/PVE

[pve-devel] [PATCH access-control 07/13] ticket: use clinfo to get cluster name

instead of parsing corosync.conf, and avoid coupling the access-control API with PVE::Corosync. if corosync.conf and pmxcfs don't agree on how the cluster is called, there is a bigger issue anyway.. Signed-off-by: Fabian Grünbichler --- PVE/API2/AccessControl.pm | 15 +++ 1 file chan

[pve-devel] [PATCH ha-manager 2/2] bump version to 3.0-3~test1

Signed-off-by: Fabian Grünbichler --- debian/changelog | 16 1 file changed, 16 insertions(+) diff --git a/debian/changelog b/debian/changelog index d05e89c..4c6f656 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,19 @@ +pve-ha-manager (3.0-3~test1) pve; urgency=

[pve-devel] [PATCH access-control 10/13] d/control: correctly set Architecture field

this packge only contains perl modules and scripts, shell completions and documentation - no architecture-specific stuff whatsoever. Signed-off-by: Fabian Grünbichler --- Makefile | 2 +- debian/control | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makef

[pve-devel] [PATCH guest-common 1/5] use PVE::DataCenterConfig

to make sure that the corresponding cfs_read_file works() works. Signed-off-by: Fabian Grünbichler --- Notes: needs depends on libpve-cluster-perl PVE/AbstractMigrate.pm | 1 + PVE/Replication.pm | 1 + 2 files changed, 2 insertions(+) diff --git a/PVE/AbstractMigrate.pm b/PVE/Abstrac

[pve-devel] [PATCH access-control 11/13] d/control: (build-)depend on libpve-cluster-perl

Signed-off-by: Fabian Grünbichler --- debian/control | 2 ++ 1 file changed, 2 insertions(+) diff --git a/debian/control b/debian/control index 0f0e294..e9f70d6 100644 --- a/debian/control +++ b/debian/control @@ -8,6 +8,7 @@ Build-Depends: debhelper (>= 10.0.0~), libpve-common-p

[pve-devel] [PATCH access-control 09/13] use already parsed u2f property string

since libpve-cluster-perl 6.0-8 this happens automatically when parsing the datacenter.cfg, just like the other property strings stored there. Signed-off-by: Fabian Grünbichler --- Notes: needs a dependency on libpve-cluster-perl (as well) requires a (versioned) depends on libpve-cl

[pve-devel] [PATCH cluster 11/16] move ssh_info code to own file

Signed-off-by: Fabian Grünbichler --- Notes: requires versioned breaks on: - libpve-storage-perl - qemu-server - libpve-guest-common-perl data/PVE/Makefile | 2 +- data/PVE/Cluster.pm | 58 -- data/PVE/SSHInfo.pm | 68 ++

[pve-devel] [PATCH guest-common 5/5] bump version to 3.0-3~test1

Signed-off-by: Fabian Grünbichler --- debian/changelog | 6 ++ 1 file changed, 6 insertions(+) diff --git a/debian/changelog b/debian/changelog index fb2cad0..041bc5f 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +libpve-guest-common-perl (3.0-3~test1) pve; urgency=med

[pve-devel] [PATCH guest-common 3/5] d/control: add (build-)depends on libpve-cluster-perl

Signed-off-by: Fabian Grünbichler --- debian/control | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/debian/control b/debian/control index 322ff9f..d023ea3 100644 --- a/debian/control +++ b/debian/control @@ -3,12 +3,14 @@ Section: perl Priority: optional Maintainer: Prox

[pve-devel] [PATCH ha-manager 1/2] use PVE::DataCenterConfig

to make sure that the corresponding cfs_read_file works() works. Signed-off-by: Fabian Grünbichler --- Notes: requires versioned depends on libpve-cluster-perl debian/control | 2 ++ src/PVE/HA/Env/PVE2.pm | 1 + 2 files changed, 3 insertions(+) diff --git a/debian/control b/debia

[pve-devel] [PATCH storage 3/6] use PVE::SSHInfo

Signed-off-by: Fabian Grünbichler --- Notes: needs dependency on libpve-cluster-perl PVE/API2/Storage/Content.pm | 3 ++- PVE/Storage.pm | 5 +++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/PVE/API2/Storage/Content.pm b/PVE/API2/Storage/Content.pm index 9f6

[pve-devel] [PATCH container 1/5] test: mock PVE::Cluster in setup tests

Signed-off-by: Fabian Grünbichler --- src/test/run_setup_tests.pl | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/test/run_setup_tests.pl b/src/test/run_setup_tests.pl index 678ff0f..bb66c01 100755 --- a/src/test/run_setup_tests.pl +++ b/src/test/run_setup_tests.pl @@

[pve-devel] [PATCH storage 5/6] d/control: add (build-)depends on libpve-cluster-perl

Signed-off-by: Fabian Grünbichler --- debian/control | 2 ++ 1 file changed, 2 insertions(+) diff --git a/debian/control b/debian/control index 0c146aa..6de6f39 100644 --- a/debian/control +++ b/debian/control @@ -9,6 +9,7 @@ Build-Depends: debhelper (>= 7.0.50~), librados2-perl,

[pve-devel] [PATCH guest-common 4/5] d/control: add more missing build-dependencies

pve-cluster is used by the test cases Signed-off-by: Fabian Grünbichler --- debian/control | 3 +++ 1 file changed, 3 insertions(+) diff --git a/debian/control b/debian/control index d023ea3..837cbaa 100644 --- a/debian/control +++ b/debian/control @@ -4,6 +4,9 @@ Priority: optional Maintainer

[pve-devel] [PATCH qemu-server 05/12] d/control: add build-dependency on pve-edk2-firmware

needed for config2command tests Signed-off-by: Fabian Grünbichler --- debian/control | 1 + 1 file changed, 1 insertion(+) diff --git a/debian/control b/debian/control index 0c59d95..74a4d7f 100644 --- a/debian/control +++ b/debian/control @@ -15,6 +15,7 @@ Build-Depends: debhelper (>= 11~),

[pve-devel] [PATCH cluster 14/16] split package into pve-cluster/pmxcfs and perl modules

with the former containing: - pmxcfs binary + service - IPCC perl bindings - PVE::Cluster and the latter being further split into libpve-cluster-perl: - PVE::DataCenterConfig - various other perl modules not directly related to pmxcfs and libpve-cluster-api-perl: - ClusterConfig API - pvecm CLI

[pve-devel] [PATCH qemu-server 07/12] use PVE::DataCenterConfig

to make sure that the corresponding cfs_read_file works() works. Signed-off-by: Fabian Grünbichler --- Notes: needs dependency on libpve-cluster-perl PVE/API2/Qemu.pm | 1 + PVE/QemuServer.pm | 1 + 2 files changed, 2 insertions(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index d

[pve-devel] [PATCH storage 2/6] use PVE::DataCenterConfig

to make sure that the corresponding cfs_read_file works() works. Signed-off-by: Fabian Grünbichler --- Notes: needs dependency on libpve-cluster-perl PVE/Storage.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/Storage.pm b/PVE/Storage.pm index 1a38d07..b9437c8 100755 --- a/PVE/S

[pve-devel] [PATCH qemu-server 06/12] d/control: add build-dependency on pkg-config

needed to find libjson-c-dev headers for qmeventd Signed-off-by: Fabian Grünbichler --- debian/control | 1 + 1 file changed, 1 insertion(+) diff --git a/debian/control b/debian/control index 74a4d7f..b03f1e6 100644 --- a/debian/control +++ b/debian/control @@ -13,6 +13,7 @@ Build-Depends: debh

[pve-devel] [PATCH container 3/5] use PVE::DataCenterConfig

to make sure that the corresponding cfs_read_file works() works. Signed-off-by: Fabian Grünbichler --- Notes: needs a dependency on libpve-cluster-perl debian/control| 2 ++ src/PVE/API2/LXC.pm | 1 + src/PVE/LXC/Config.pm | 1 + src/PVE/LXC/Create.pm | 1 + 4 files changed, 5 in

[pve-devel] [PATCH container 5/5] bump version to 3.0-11~test11

Signed-off-by: Fabian Grünbichler --- debian/changelog | 14 ++ 1 file changed, 14 insertions(+) diff --git a/debian/changelog b/debian/changelog index 88253e3..9da2430 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,17 @@ +pve-container (3.0-11~test1) pve; urgency=me

[pve-devel] [PATCH qemu-server 01/12] move 'use UUID' statement to correct file

and add the libuuid-perl package to build-depends as well. Signed-off-by: Fabian Grünbichler --- PVE/API2/Qemu.pm | 1 - PVE/QemuServer.pm | 1 + debian/control| 1 + 3 files changed, 2 insertions(+), 1 deletion(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index b2c0b0d..da00676 100

[pve-devel] [PATCH guest-common 2/5] use PVE::SSHInfo

Signed-off-by: Fabian Grünbichler --- Notes: requires versioned dependency on libpve-cluster-perl PVE/AbstractMigrate.pm | 5 +++-- PVE/Replication.pm | 9 + 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/PVE/AbstractMigrate.pm b/PVE/AbstractMigrate.pm index 908d

[pve-devel] [PATCH qemu-server 09/12] use PVE::RRD for RRD data

refactored from PVE::Cluster. same code, same semantics, different file. Signed-off-by: Fabian Grünbichler --- Notes: needs dependency on libpve-cluster-perl PVE/API2/Qemu.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index

[pve-devel] [PATCH manager 04/12] test: mock PVE::SSHInfo module

since it is now used for getting a cluster node's migration IP address. Signed-off-by: Fabian Grünbichler --- Notes: needs versioned build dependency on libpve-cluster-perl requires versioned build dependency on libpve-cluster-perl test/ReplicationTestEnv.pm | 7 ++- 1 file ch

[pve-devel] [PATCH qemu-server 02/12] test: mock PVE::ReplicationConfig->new

to allow tests to finish without running, functional pmxcfs instance. Signed-off-by: Fabian Grünbichler --- test/snapshot-test.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/test/snapshot-test.pm b/test/snapshot-test.pm index c95e7f3..2090d26 100644 --- a/test/snapshot-test.pm +++ b/test

[pve-devel] [PATCH container 2/5] test: add 'use PVE::LXC::Config' to setup test

Signed-off-by: Fabian Grünbichler --- src/test/run_setup_tests.pl | 1 + 1 file changed, 1 insertion(+) diff --git a/src/test/run_setup_tests.pl b/src/test/run_setup_tests.pl index bb66c01..582a97b 100755 --- a/src/test/run_setup_tests.pl +++ b/src/test/run_setup_tests.pl @@ -10,6 +10,7 @@ use P

[pve-devel] [PATCH container 4/5] use PVE::RRD for RRD data

refactored from PVE::Cluster. same code, same semantics, different file. Signed-off-by: Fabian Grünbichler --- Notes: needs a dependency on libpve-cluster-perl (as well) src/PVE/API2/LXC.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/PVE/API2/LXC.pm b/src/P

[pve-devel] [PATCH qemu-server 04/12] d/control: add build-dependency on pve-qemu-kvm

instead of qemu-utils, since we actually depend on files from our qemu package for some tests. Signed-off-by: Fabian Grünbichler --- debian/control | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/control b/debian/control index cbf16ef..0c59d95 100644 --- a/debian/contr

[pve-devel] [PATCH qemu-server 11/12] d/control: add (build-)depends on libpve-cluster-perl

Signed-off-by: Fabian Grünbichler --- debian/control | 2 ++ 1 file changed, 2 insertions(+) diff --git a/debian/control b/debian/control index b03f1e6..55f816e 100644 --- a/debian/control +++ b/debian/control @@ -5,6 +5,7 @@ Maintainer: Proxmox Support Team Build-Depends: debhelper (>= 11~),

[pve-devel] [PATCH manager 09/12] d/control: add (build-)depends on libpve-cluster-api-perl

it contains PVE::API2::ClusterConfig Signed-off-by: Fabian Grünbichler --- debian/control | 2 ++ 1 file changed, 2 insertions(+) diff --git a/debian/control b/debian/control index 1853cd92..caf71441 100644 --- a/debian/control +++ b/debian/control @@ -8,6 +8,7 @@ Build-Depends: debhelper (>= 1

[pve-devel] [PATCH qemu-server 12/12] bump version to 6.0-14~test1

Signed-off-by: Fabian Grünbichler --- debian/changelog | 12 1 file changed, 12 insertions(+) diff --git a/debian/changelog b/debian/changelog index 831c88e..5662de5 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,15 @@ +qemu-server (6.0-14~test1) pve; urgency=medium

[pve-devel] [PATCH qemu-server 08/12] use PVE::SSHInfo

Signed-off-by: Fabian Grünbichler --- Notes: needs dependency on libpve-cluster-perl requires versioned dependency on libpve-cluster-perl PVE/API2/Qemu.pm | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 02af933.

[pve-devel] [PATCH firewall 1/1] d/control: add (build-)depends on libpve-cluster-perl

since it contains PVE::Corosync now Signed-off-by: Fabian Grünbichler --- debian/control | 2 ++ 1 file changed, 2 insertions(+) diff --git a/debian/control b/debian/control index b119159..e91f9f7 100644 --- a/debian/control +++ b/debian/control @@ -8,6 +8,7 @@ Build-Depends: debhelper (>= 10),

[pve-devel] [PATCH manager 06/12] pveproxy.service: take over pvecm call from pve-cluster.service

to ensure certificate/key is present prior to loading them. Signed-off-by: Fabian Grünbichler --- services/pveproxy.service | 1 + 1 file changed, 1 insertion(+) diff --git a/services/pveproxy.service b/services/pveproxy.service index 8c80ebf1..51038785 100644 --- a/services/pveproxy.service ++

[pve-devel] [PATCH manager 07/12] test: also mock cfs_read_file

needed for tests to work without a functional running pmxcfs instance. Signed-off-by: Fabian Grünbichler --- test/ReplicationTestEnv.pm | 8 1 file changed, 8 insertions(+) diff --git a/test/ReplicationTestEnv.pm b/test/ReplicationTestEnv.pm index bc305627..f1eea688 100755 --- a/test/R

[pve-devel] [PATCHSET] pve-cluster split

this patch set attempts to rectify a long-standing issue with our pve-cluster packaging: - the combination of pmxcfs+ipcc+binding and various other more or less cluster-related perl code in mostly one perl module (PVE::Cluster) and binary package (pve-cluster) - a cyclic dependency between pve-

[pve-devel] [PATCH access-control 12/13] add new api/cli binary package and bump version

this is needed to avoid a dependency cycle: libpve-access-control-api-perl -> libpve-cluster-perl (DataCenterConfig) libpve-cluster-perl -> libpve-access-control (Ticket generation) Signed-off-by: Fabian Grünbichler --- Notes: needs a version bump to properly work! Makefile

[pve-devel] [PATCH qemu-server 03/12] test: mock PVE::Storage for all tests

since the prepare step also attempts to read /etc/pve/storage.cfg Signed-off-by: Fabian Grünbichler --- test/snapshot-test.pm | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/test/snapshot-test.pm b/test/snapshot-test.pm index 2090d26..da55b2c 100644

[pve-devel] [PATCH manager 10/12] d/control: bump versioned b-d on libpve-guest-common-perl

otherwise the replication tests fail to load datacenter.cfg Signed-off-by: Fabian Grünbichler --- debian/control | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/debian/control b/debian/control index caf71441..0bd2c6be 100644 --- a/debian/control +++ b/debian/control @@ -1

[pve-devel] [PATCH cluster 09/16] move datacenter.cfg to own file

and inline get_local_migration_ip into 'pvecm mtunnel', since all the other callers are either wrong or have different requirements. Signed-off-by: Fabian Grünbichler --- Notes: requires versioned breaks on - ha-manager - libpve-access-control-perl - libpve-guest-common-perl

[pve-devel] [PATCH manager 11/12] d/control: add dependency on libpve-access-control-api-perl

since we link the contained modules into the big-picture API2 tree here. Signed-off-by: Fabian Grünbichler --- debian/control | 1 + 1 file changed, 1 insertion(+) diff --git a/debian/control b/debian/control index 0bd2c6be..c5be9aa6 100644 --- a/debian/control +++ b/debian/control @@ -45,6 +45

[pve-devel] [PATCH manager 03/12] API: add node address(es) API endpoint

Signed-off-by: Fabian Grünbichler --- naming is not my forte - better recommendations welcome ;) PVE/API2/Nodes.pm | 72 +++ 1 file changed, 72 insertions(+) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index 715c8563..ae408dcc 100644 --- a/PVE/

[pve-devel] [PATCH manager 05/12] use PVE::RRD for RRD data

refactored from PVE::Cluster. same code, same semantics, different file. Signed-off-by: Fabian Grünbichler --- Notes: needs a dependency on libpve-cluster-perl, but see comment in pve-cluster PVE/API2/Nodes.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/PVE/API

[pve-devel] [PATCH manager 01/12] takeover CertCache from pve-cluster

same code, same semantics, different file/module Signed-off-by: Fabian Grünbichler --- PVE/Makefile | 1 + PVE/CertCache.pm | 92 +++ PVE/HTTPServer.pm | 5 +-- 3 files changed, 96 insertions(+), 2 deletions(-) create mode 100644 PVE/CertCache

[pve-devel] [PATCH qemu-server 10/12] refactor migration IP retrieval

since PVE::Cluster::get_local_migration_ip does not exist anymore. this is basically an inlined version, since this is the only remaining caller that we actually want to keep long-term. Signed-off-by: Fabian Grünbichler --- PVE/QemuServer.pm | 40 +++- 1 file

[pve-devel] [PATCH manager 12/12] bump version to 6.0-12~test1

Signed-off-by: Fabian Grünbichler --- debian/changelog | 18 ++ 1 file changed, 18 insertions(+) diff --git a/debian/changelog b/debian/changelog index 9491b2a1..81cb86e2 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,21 @@ +pve-manager (6.0-12~test1) pve; urgenc

[pve-devel] [PATCH manager 08/12] d/control: add (build-)depends on libpve-cluster-perl

Signed-off-by: Fabian Grünbichler --- debian/control | 2 ++ 1 file changed, 2 insertions(+) diff --git a/debian/control b/debian/control index e2afb374..1853cd92 100644 --- a/debian/control +++ b/debian/control @@ -7,6 +7,7 @@ Build-Depends: debhelper (>= 11~), libhttp-daemon-pe

[pve-devel] [PATCH manager 02/12] use PVE::DataCenterConfig

to make sure that the corresponding cfs_read_file works() works. Signed-off-by: Fabian Grünbichler --- Notes: needs a dependency on libpve-cluster-perl PVE/API2.pm | 1 + PVE/API2/APT.pm | 1 + PVE/API2/Cluster.pm | 3 ++- PVE/API2/Nodes.pm| 1 + PVE/API2

[pve-devel] [PATCH cluster 05/16] move cluster setup related code to own file

this includes: - directory setup - ssh setup (known hosts, keys, config) - CA/certificate helpers - join helpers used by API and CLI code Signed-off-by: Fabian Grünbichler --- data/PVE/Cluster/Makefile | 2 +- data/PVE/API2/ClusterConfig.pm | 19 +- data/PVE/CLI/pvecm.pm | 17 +

[pve-devel] [PATCH docs] Add description for mountpoint property

Signed-off-by: Fabian Ebner --- pve-storage-zfspool.adoc | 5 + 1 file changed, 5 insertions(+) diff --git a/pve-storage-zfspool.adoc b/pve-storage-zfspool.adoc index f53a598..cf7cc3f 100644 --- a/pve-storage-zfspool.adoc +++ b/pve-storage-zfspool.adoc @@ -32,6 +32,11 @@ sparse:: Use ZFS th

[pve-devel] [PATCH storage] fix #2085: Handle non-default mount point in path() by introducing new mountpoint property

A new mountpoint property is added to the schema for ZFSPool storages. When needed for the first time, the current mount point is determined and written to the storage config. Signed-off-by: Fabian Ebner --- PVE/Storage/ZFSPoolPlugin.pm | 25 +++-- 1 file changed, 23 insertio

[pve-devel] [PATCH docs v2 00/10] pveceph: update doc

In patch 10 I have added an attribute to asciidoc-pve.conf to replace Ceph's codename. I hope this is the right location for this. Changes V1 -> V2: Added corrections and suggestions from Aaron. Doesn't ship the applied patch "pveceph: old style commands to subcommands" Review and suggest

[pve-devel] [PATCH docs v2 09/10] Fix #1958: pveceph: add section Ceph maintenance

Signed-off-by: Alwin Antreich --- pveceph.adoc | 55 1 file changed, 55 insertions(+) diff --git a/pveceph.adoc b/pveceph.adoc index 66ea111..0d62943 100644 --- a/pveceph.adoc +++ b/pveceph.adoc @@ -331,6 +331,7 @@ network. It is recommended t

[pve-devel] [PATCH docs v2 08/10] pveceph: correct CephFS subtitle

Signed-off-by: Alwin Antreich --- pveceph.adoc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pveceph.adoc b/pveceph.adoc index e97e2e6..66ea111 100644 --- a/pveceph.adoc +++ b/pveceph.adoc @@ -659,8 +659,8 @@ refer to the ceph documentation. footnote:[Configuring multip

[pve-devel] [PATCH docs v2 07/10] pveceph: Reorganize TOC for new sections

Put the previous added sections into subsection for a better outline of the TOC. With the rearrangement of the first level titles to second level, the general descriptions of a service needs to move into the new first level titles. And add/corrects some statements of those descriptions. Signed-of

[pve-devel] [PATCH docs v2 06/10] pveceph: switch note for Creating Ceph Manager

to be more consistent with other sections, the note for creating the Ceph Manager was moved below the command. Signed-off-by: Alwin Antreich --- pveceph.adoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pveceph.adoc b/pveceph.adoc index 5933cc8..dbfe909 100644 --- a/

[pve-devel] [PATCH docs v2 10/10] pveceph: add attribute ceph_codename

To change the codename for Ceph in one place, the patch adds the asciidoc attribute 'ceph_codename'. Replaces the outdated references to luminous and the http -> https on the links in pveceph.adoc. Signed-off-by: Alwin Antreich --- pveceph.adoc | 30 +++---

[pve-devel] [PATCH docs] qm: spice foldersharing: Add experimental warning

Signed-off-by: Aaron Lauterer --- qm.adoc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qm.adoc b/qm.adoc index 9ee4460..c0fe892 100644 --- a/qm.adoc +++ b/qm.adoc @@ -856,6 +856,8 @@ Select the folder to share and then enable the checkbox. NOTE: Folder sharing currently only works in

Re: [pve-devel] [PATCH docs] qm: spice foldersharing: Add experimental warning

On Wed, Nov 06, 2019 at 03:20:59PM +0100, Aaron Lauterer wrote: > Signed-off-by: Aaron Lauterer > --- > qm.adoc | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/qm.adoc b/qm.adoc > index 9ee4460..c0fe892 100644 > --- a/qm.adoc > +++ b/qm.adoc > @@ -856,6 +856,8 @@ Select the folder to

Re: [pve-devel] [PATCH docs] qm: spice foldersharing: Add experimental warning

Hmm, What about: Currently this feature does not work reliably. On 11/6/19 3:29 PM, Alwin Antreich wrote: On Wed, Nov 06, 2019 at 03:20:59PM +0100, Aaron Lauterer wrote: Signed-off-by: Aaron Lauterer --- qm.adoc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qm.adoc b/qm.adoc index

Re: [pve-devel] [PATCH manager 1/4] ceph: add perf data cache helpers

On 11/6/19 8:36 AM, Dominik Csapak wrote: > On 11/5/19 6:33 PM, Thomas Lamprecht wrote: >> On 11/5/19 1:51 PM, Dominik Csapak wrote: >>> +my $entry = { >>> +time => $time, >>> +ops_r => $pgmap->{read_op_per_sec}, >>> +ops_w => $pgmap->{write_op_per_sec}, >>> +bytes_r => $pgmap->

[pve-devel] applied: [PATCH docs] qm: fix typo: /ghen/When/

On 11/6/19 10:45 AM, Christian Ebner wrote: > Signed-off-by: Christian Ebner > --- > qm.adoc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qm.adoc b/qm.adoc > index 9ee4460..429cff6 100644 > --- a/qm.adoc > +++ b/qm.adoc > @@ -507,7 +507,7 @@ host. > .Fixed Memory All

Re: [pve-devel] [PATCH docs] qm: spice foldersharing: Add experimental warning

On Wed, Nov 06, 2019 at 03:45:26PM +0100, Aaron Lauterer wrote: > Hmm, What about: > > Currently this feature does not work reliably. > > > On 11/6/19 3:29 PM, Alwin Antreich wrote: > > On Wed, Nov 06, 2019 at 03:20:59PM +0100, Aaron Lauterer wrote: > > > Signed-off-by: Aaron Lauterer > > > ---

[pve-devel] [PATCH container] fix #2453: actually write random MAC addresses in config

apparently this was a regression introduced with the pending changes series. when creating/changing the network interface of a container, we need to use $print_lxc_network in order to have the correct property string in the config file. Signed-off-by: Oguz Bektas --- src/PVE/LXC/Config.pm | 5 ++

[pve-devel] [PATCH v2 docs] qm: spice foldersharing: Add experimental warning

Signed-off-by: Aaron Lauterer --- v1 -> v2: added Currently qm.adoc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qm.adoc b/qm.adoc index 9ee4460..35d7d57 100644 --- a/qm.adoc +++ b/qm.adoc @@ -856,6 +856,8 @@ Select the folder to share and then enable the checkbox. NOTE: Folder shari

  1   2   >