thanks for noticing!
On October 25, 2019 5:34 pm, Thomas Lamprecht wrote:
> The libanyevent-perl version 7.140-3 included a fix for this.
> It migrated to the then still testing (buster was not yet released)
> on 07.04.2019, and so we can safely revert this workaround again
> here.
>
> Albeit thi
When doing an online migration with --targetstorage unused disks get migrated
to the specified target storage as well.
With this patch we keep track of those volumes and update the VM config with
their new locations. Unused volumes of the VM previously not present in the
config are added as well.
Doing an online migration with --targetstorage and two unused disks with the
same name on different storages failed, because they would collide on the
target storage. This patch makes sure that we don't use the same name twice.
Signed-off-by: Fabian Ebner
---
PVE/QemuMigrate.pm | 8 ++--
1 f
Signed-off-by: Fabian Ebner
---
PVE/QemuMigrate.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm
index a01f0ca..448f584 100644
--- a/PVE/QemuMigrate.pm
+++ b/PVE/QemuMigrate.pm
@@ -958,7 +958,7 @@ sub phase3_cleanup {
if (my $e
On 10/28/19 10:57 AM, Fabian Ebner wrote:
When doing an online migration with --targetstorage unused disks get migrated
to the specified target storage as well.
With this patch we keep track of those volumes and update the VM config with
their new locations. Unused volumes of the VM previously no
On 10/28/19 10:57 AM, Fabian Ebner wrote:
> Signed-off-by: Fabian Ebner
> ---
> PVE/QemuMigrate.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm
> index a01f0ca..448f584 100644
> --- a/PVE/QemuMigrate.pm
> +++ b/PVE/QemuMigrate.p
On 10/24/19 3:58 PM, Oguz Bektas wrote:
> lock option needs to be fastpluggable when modifying with 'pct set'.
> otherwise it registers as a pending change.
>
> Signed-off-by: Oguz Bektas
> ---
> src/PVE/LXC/Config.pm | 1 +
> 1 file changed, 1 insertion(+)
>
applied, thanks!
As said, IMO the
Signed-off-by: Stefan Reiter
---
PVE/Service/pvestatd.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/PVE/Service/pvestatd.pm b/PVE/Service/pvestatd.pm
index bad1b73d..d8c86886 100755
--- a/PVE/Service/pvestatd.pm
+++ b/PVE/Service/pvestatd.pm
@@ -18,6 +18,7 @@ use PVE::N
The current version had only one user in LXC, so move the LXC-specific
code there to reuse this in QemuServer.
Also cache, since the host's architecture can't change during runtime.
Signed-off-by: Stefan Reiter
---
src/PVE/Tools.pm | 17 +
1 file changed, 5 insertions(+), 12 del
Signed-off-by: Stefan Reiter
---
src/PVE/HA/Resources/PVEVM.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/HA/Resources/PVEVM.pm b/src/PVE/HA/Resources/PVEVM.pm
index 0a37cf6..3a4c07a 100644
--- a/src/PVE/HA/Resources/PVEVM.pm
+++ b/src/PVE/HA/Resources/PVEVM.pm
@@
This is the only time we need to do this translation, moving it here
allows reuse of the PVE::Tools function.
Signed-off-by: Stefan Reiter
---
src/PVE/LXC/Setup.pm | 9 +
1 file changed, 9 insertions(+)
diff --git a/src/PVE/LXC/Setup.pm b/src/PVE/LXC/Setup.pm
index 845aced..ae42a10 1006
...now that it no longer does LXC-specific stuff. Removes a FIXME.
Signed-off-by: Stefan Reiter
---
PVE/QemuServer.pm | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index b635760..9af690a 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/Q
...PVE::QemuServer::Machine.
qemu_machine_feature_enabled is exported since it has a *lot* of users
in PVE::QemuServer and a long enough name as it is.
Signed-off-by: Stefan Reiter
---
Not sure if PVE::QemuMachine wouldn't be a better package name. I'm fine with
both (or other suggestions), if
First 3 patches are independant refactorings around get_host_arch.
Rest of the series refactors QemuServer and creates three new packages:
* 'PVE::QemuSchema' for schema related code and common directory creation
* 'PVE::QMP' for higher-level QMP functions
* 'PVE::QemuServer::Machine' for QEMU mac
Signed-off-by: Stefan Reiter
---
src/PVE/HA/Resources/PVEVM.pm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/PVE/HA/Resources/PVEVM.pm b/src/PVE/HA/Resources/PVEVM.pm
index 3a4c07a..84c23be 100644
--- a/src/PVE/HA/Resources/PVEVM.pm
+++ b/src/PVE/HA/Resources/PVEVM.pm
...in addition to PVE::QMPClient for low-level.
Also move all references (most with exports, the methods are used a lot
and have unique enough names IMO) and fix tests.
References in __snapshot_create_vol_snapshots_hook (in QemuConfig) is an
exception, as using the exported functions breaks tests
Signed-off-by: Stefan Reiter
---
PVE/API2/Nodes.pm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm
index 9e731e05..0f30a518 100644
--- a/PVE/API2/Nodes.pm
+++ b/PVE/API2/Nodes.pm
@@ -1729,7 +1729,7 @@ __PACKAGE__->register_method ({
Also merge the 'mkdir's from QemuServer and QemuConfig to reduce
duplication (both modules depend on QemuSchema anyway).
nodename() is still called in multiple modules, but since it's cached by
the INotify module it doesn't really matter.
Signed-off-by: Stefan Reiter
---
QemuSchema is pretty sm
Also move check_cmdline, since check_running is its only user. Changes
all uses of check_running in QemuServer, including mocking in snapshot
tests.
Signed-off-by: Stefan Reiter
---
PVE/API2/Qemu.pm | 32 +++---
PVE/CLI/qm.pm| 13 +++---
PVE/QemuConfig.pm
instead of 10 years, to avoid issues with browsers/os that reject
certificates which have a longer lifetime
(e.g. macOs Catalina only accepts max 825 days if issued after july 2019)
Signed-off-by: Dominik Csapak
---
data/PVE/Cluster.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
this series enabled auto-renewing of our self issued certificates
by checking the expiry time daily with 'pveupdate' and
renewing it if it expires in less than 2 weeks
also reduce the initial lifetime of the certificates to two years
this fixes an issue where some os/browsers (macOs Catalina) wou
but only if the ca is ours, and the cert is issued by our ca
(by checking the issuer and openssl verify)
this way we can reduce the lifetime of the certs without having
to worry that they ran out
Signed-off-by: Dominik Csapak
---
PVE/CertHelpers.pm | 6 ++
bin/pveupdate | 33 +
On October 28, 2019 11:36 am, Stefan Reiter wrote:
> This is the only time we need to do this translation, moving it here
> allows reuse of the PVE::Tools function.
>
> Signed-off-by: Stefan Reiter
> ---
> src/PVE/LXC/Setup.pm | 9 +
> 1 file changed, 9 insertions(+)
>
> diff --git a/sr
On 10/28/19 11:54 AM, Fabian Grünbichler wrote:
On October 28, 2019 11:36 am, Stefan Reiter wrote:
This is the only time we need to do this translation, moving it here
allows reuse of the PVE::Tools function.
Signed-off-by: Stefan Reiter
---
src/PVE/LXC/Setup.pm | 9 +
1 file change
Signed-off-by: Wolfgang Bumiller
---
www/manager6/dc/TFAEdit.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/dc/TFAEdit.js b/www/manager6/dc/TFAEdit.js
index 7d19127d..8f3017f6 100644
--- a/www/manager6/dc/TFAEdit.js
+++ b/www/manager6/dc/TFAEdit.js
@@ -289,7 +
This series adds a new format of how we store TFA keys. The reason is
documented in the new format verifier:
# The old format used 16 base32 chars or 40 hex digits. Since they have a
common subset it's
# hard to distinguish them without the our previous length constraints, so
add a 'v2'
Signed-off-by: Wolfgang Bumiller
---
Introduces a pve-common dependency bump.
PVE/API2/AccessControl.pm | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/PVE/API2/AccessControl.pm b/PVE/API2/AccessControl.pm
index 9d2da8d..6d0ea82 100644
--- a/PVE/API2/AccessControl.pm
+++ b
Signed-off-by: Wolfgang Bumiller
---
src/PVE/OTP.pm | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/PVE/OTP.pm b/src/PVE/OTP.pm
index 019076b..070ab59 100644
--- a/src/PVE/OTP.pm
+++ b/src/PVE/OTP.pm
@@ -137,7 +137,13 @@ sub oath_verify_otp {
foreach my $k (PVE
Signed-off-by: Wolfgang Bumiller
---
Introduces a pve-access-control dependency bump.
www/manager6/dc/TFAEdit.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/dc/TFAEdit.js b/www/manager6/dc/TFAEdit.js
index e1c3b658..7d19127d 100644
--- a/www/manager6/dc/TFAEd
Signed-off-by: Wolfgang Bumiller
---
src/PVE/JSONSchema.pm | 24
1 file changed, 24 insertions(+)
diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm
index db38d44..3712872 100644
--- a/src/PVE/JSONSchema.pm
+++ b/src/PVE/JSONSchema.pm
@@ -530,6 +530,30 @@
PVE::J
This function has been used in one place only into which we inlined its
functionality. Removing it avoids confusion between vm_destroy and vm_destroy.
The whole $importfn is executed in a lock_config_full.
As a consequence, for the inlined code:
1. lock_config is redundant
2. it is not possible th
Previously a VMID conflict was possible when creating a VM on another node
between locking the config with lock_config_full and writing to it for the
first time with write_config.
Using create_and_lock_config eliminates this possibility. This means that now
the "lock" property is set in the config
This series cleans up some redundant locks and functions and sets more
appropriate locks instead when importing .ovf and disks.
Patch 1/7 of the old series has already been applied.
Drop 4/7 "Remove variable from lock" as we plan to apply the patch with
create_and_lock_config and this makes it obs
Functions like qm importovf can now set the "lock" property in a config file
before calling do_import.
Signed-off-by: Dominic Jäger
---
v1->v2: Edited only the commit message ("parameter lock" -> "lock property")
PVE/CLI/qm.pm| 4 ++--
PVE/QemuServer/ImportDisk.pm | 6 --
2
Signed-off-by: Stefan Reiter
---
src/PVE/HA/Resources/PVEVM.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/HA/Resources/PVEVM.pm b/src/PVE/HA/Resources/PVEVM.pm
index 0a37cf6..3a4c07a 100644
--- a/src/PVE/HA/Resources/PVEVM.pm
+++ b/src/PVE/HA/Resources/PVEVM.pm
@@
The current version had only one user in LXC, so move the LXC-specific
code there to reuse this in QemuServer.
Also cache, since the host's architecture can't change during runtime.
Signed-off-by: Stefan Reiter
---
src/PVE/Tools.pm | 17 +
1 file changed, 5 insertions(+), 12 del
Signed-off-by: Stefan Reiter
---
src/PVE/HA/Resources/PVEVM.pm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/PVE/HA/Resources/PVEVM.pm b/src/PVE/HA/Resources/PVEVM.pm
index 3a4c07a..84c23be 100644
--- a/src/PVE/HA/Resources/PVEVM.pm
+++ b/src/PVE/HA/Resources/PVEVM.pm
This is the only time we need to do this translation, moving it here
allows reuse of the PVE::Tools function.
Signed-off-by: Stefan Reiter
---
src/PVE/LXC/Setup.pm | 9 +
1 file changed, 9 insertions(+)
diff --git a/src/PVE/LXC/Setup.pm b/src/PVE/LXC/Setup.pm
index 845aced..ca6fc4f 1006
Also merge the 'mkdir's from QemuServer and QemuConfig to reduce
duplication (both modules depend on QemuSchema anyway).
nodename() is still called in multiple modules, but since it's cached by
the INotify module it doesn't really matter.
Signed-off-by: Stefan Reiter
---
QemuSchema is pretty sm
...PVE::QemuServer::Machine.
qemu_machine_feature_enabled is exported since it has a *lot* of users
in PVE::QemuServer and a long enough name as it is.
Signed-off-by: Stefan Reiter
---
Not sure if PVE::QemuMachine wouldn't be a better package name. I'm fine with
both (or other suggestions), if
Also move check_cmdline, since check_running is its only user. Changes
all uses of check_running in QemuServer, including mocking in snapshot
tests.
Signed-off-by: Stefan Reiter
---
PVE/API2/Qemu.pm | 32 +++---
PVE/CLI/qm.pm| 13 +++---
PVE/QemuConfig.pm
First 3 patches are independant refactorings around get_host_arch.
Rest of the series refactors QemuServer and creates three new packages:
* 'PVE::QemuSchema' for schema related code and common directory creation
* 'PVE::QMP' for higher-level QMP functions
* 'PVE::QemuServer::Machine' for QEMU mac
Signed-off-by: Stefan Reiter
---
PVE/API2/Nodes.pm | 6 +++---
test/ReplicationTestEnv.pm | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm
index 9e731e05..0f30a518 100644
--- a/PVE/API2/Nodes.pm
+++ b/PVE/API2/Nodes.pm
@@ -1729,
...in addition to PVE::QMPClient for low-level.
Also move all references (most with exports, the methods are used a lot
and have unique enough names IMO) and fix tests.
References in __snapshot_create_vol_snapshots_hook (in QemuConfig) is an
exception, as using the exported functions breaks tests
...now that it no longer does LXC-specific stuff. Removes a FIXME.
Signed-off-by: Stefan Reiter
---
PVE/QemuServer.pm | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index b635760..9af690a 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/Q
Signed-off-by: Stefan Reiter
---
PVE/Service/pvestatd.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/PVE/Service/pvestatd.pm b/PVE/Service/pvestatd.pm
index bad1b73d..d8c86886 100755
--- a/PVE/Service/pvestatd.pm
+++ b/PVE/Service/pvestatd.pm
@@ -18,6 +18,7 @@ use PVE::N
On 10/28/19 12:20 PM, Wolfgang Bumiller wrote:
> Signed-off-by: Wolfgang Bumiller
> ---
> src/PVE/JSONSchema.pm | 24
> 1 file changed, 24 insertions(+)
>
> diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm
> index db38d44..3712872 100644
> --- a/src/PVE/JSONSch
The codepath for "any" hugepages did not check if memory size was even,
leading to the code below trying to allocate half a hugepage (e.g. VM
with 2049MiB RAM would lead to 1024.5 2kB hugepages).
Also improve error message for systems with only 1GB hugepages enabled.
Signed-off-by: Stefan Reiter
On Mon, Oct 28, 2019 at 02:26:28PM +0100, Thomas Lamprecht wrote:
> On 10/28/19 12:20 PM, Wolfgang Bumiller wrote:
> > Signed-off-by: Wolfgang Bumiller
> > ---
> > src/PVE/JSONSchema.pm | 24
> > 1 file changed, 24 insertions(+)
> >
> > diff --git a/src/PVE/JSONSchema.pm
adds the pending button for Resources, Options and DNS screens.
Signed-off-by: Oguz Bektas
---
v1 -> v2:
* fix typo
* use 'datachanged' to track the status of the buttons, however:
for some reason it takes a while to refresh the status of the button,
also same on the qemu side so this is likely
On 10/28/19 3:13 PM, Wolfgang Bumiller wrote:
> On Mon, Oct 28, 2019 at 02:26:28PM +0100, Thomas Lamprecht wrote:
>> On 10/28/19 12:20 PM, Wolfgang Bumiller wrote:
>>> +register_standard_option('pve-tfa-secret', {
>>> +description => "A TFA secret, base32 encoded or hexadecimal.",
>>> +type
On 10/28/19 12:20 PM, Wolfgang Bumiller wrote:
> Signed-off-by: Wolfgang Bumiller
> ---
> src/PVE/OTP.pm | 8 +++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
applied, thanks!
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pv
On 10/23/19 6:48 PM, Oguz Bektas wrote:
> since we sort them while going through the delete hash, we can do it for
> the other loops for consistency.
>
> Signed-off-by: Oguz Bektas
> ---
> src/PVE/LXC/Config.pm | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
applied, thanks!
On 10/28/19 12:59 PM, Stefan Reiter wrote:
> This is the only time we need to do this translation, moving it here
> allows reuse of the PVE::Tools function.
>
> Signed-off-by: Stefan Reiter
> ---
> src/PVE/LXC/Setup.pm | 9 +
> 1 file changed, 9 insertions(+)
>
> diff --git a/src/PVE/LX
On 10/28/19 12:59 PM, Stefan Reiter wrote:
> The current version had only one user in LXC, so move the LXC-specific
> code there to reuse this in QemuServer.
>
> Also cache, since the host's architecture can't change during runtime.
>
> Signed-off-by: Stefan Reiter
> ---
> src/PVE/Tools.pm | 17
On 10/28/19 12:59 PM, Stefan Reiter wrote:
> The current version had only one user in LXC, so move the LXC-specific
> code there to reuse this in QemuServer.
>
> Also cache, since the host's architecture can't change during runtime.
>
> Signed-off-by: Stefan Reiter
> ---
> src/PVE/Tools.pm | 17
On 10/28/19 12:59 PM, Stefan Reiter wrote:
> The current version had only one user in LXC, so move the LXC-specific
> code there to reuse this in QemuServer.
>
> Also cache, since the host's architecture can't change during runtime.
>
> Signed-off-by: Stefan Reiter
> ---
> src/PVE/Tools.pm | 17
57 matches
Mail list logo
