On 10/23/19 9:37 AM, Fabian Grünbichler wrote:
LGTM in general, comments inline
On October 23, 2019 8:38 am, Wolfgang Link wrote:
Files:
./src/PVE/..--> /usr/share/perl5/PVE/..
./src/PVE/ACME.pm
./src/PVE/ACME/Challenge.pm
./src/PVE/ACME/Standalone.pm
./src/PVE/ACME/DNS.p
Signed-off-by: Stefan Reiter
---
That dot was bothering me. I can safely say that, since I'm the one who
mistakenly put it there :)
system-booting.adoc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/system-booting.adoc b/system-booting.adoc
index d3d7813..fcfe6c4 100644
---
- Le 22 Oct 19, à 17:25, Stefan Reiter s.rei...@proxmox.com a écrit :
> As mentioned in #2408, live-migrating a VM between storages that use
> different scsi backends (scsi-hd, scsi-generic, scsi-block) breaks.
>
> To fix, from QEMU 4.1 machine types onward (to not break current
> behaviour
to improve UX, disabled fields shouldn't show validation errors.
Signed-off-by: Tim Marx
---
www/manager6/qemu/CDEdit.js | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/www/manager6/qemu/CDEdit.js b/www/manager6/qemu/CDEdit.js
index 78d758c7..a1636aa9 100644
--- a/www/manag
On October 15, 2019 4:12 pm, Stefan Reiter wrote:
> * query_understood_cpu_flags returns all flags that QEMU/KVM knows about
> * query_supported_cpu_flags returns all flags that QEMU/KVM can use on
> this particular host.
>
> To get supported flags, a temporary VM is started with QEMU, so we can
On October 15, 2019 4:12 pm, Stefan Reiter wrote:
> If a cputype is custom (check via prefix), try to load options from the
> custom CPU model config, and set values accordingly.
>
> While at it, extract currently hardcoded values into seperate sub and add
> reasonings.
>
> Since the new flag res
two small nits on individual patches (could also be done as follow-ups,
but it requires a rebase already anyway), others looks good to go from
my side :)
thanks for the patience and work!
On October 15, 2019 4:12 pm, Stefan Reiter wrote:
> Based on the RFC and following on- and off-list discuss
On 10/23/19 10:19 AM, Stefan Reiter wrote:
> Signed-off-by: Stefan Reiter
> ---
>
> That dot was bothering me. I can safely say that, since I'm the one who
> mistakenly put it there :)
>
^^
> system-booting.adoc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/system-
On 10/23/19 10:32 AM, Fabian Grünbichler wrote:
two small nits on individual patches (could also be done as follow-ups,
but it requires a rebase already anyway), others looks good to go from
my side :)
thanks for the patience and work!
I'll rebase and fix the nits, then send it (hopefully) on
On 10/23/19 10:51 AM, Stefan Reiter wrote:
> On 10/23/19 10:32 AM, Fabian Grünbichler wrote:
>> two small nits on individual patches (could also be done as follow-ups,
>> but it requires a rebase already anyway), others looks good to go from
>> my side :)
>>
>> thanks for the patience and work!
>>
reverting a nonexisting option did not work with the latest changes
in pve-guest-common, because we do not delete the pending option
in 'add_to_pending_delete' anymore
this had the effect that we had following in the config:
[pending]
option: pendingvalue
delete: option
which would do the deletio
On 10/22/19 5:25 PM, Stefan Reiter wrote:
> As mentioned in #2408, live-migrating a VM between storages that use
> different scsi backends (scsi-hd, scsi-generic, scsi-block) breaks.
>
> To fix, from QEMU 4.1 machine types onward (to not break current
> behaviour any more), only use scsi-hd, as in
On 10/23/19 11:39 AM, Dominik Csapak wrote:
> reverting a nonexisting option did not work with the latest changes
> in pve-guest-common, because we do not delete the pending option
> in 'add_to_pending_delete' anymore
>
> this had the effect that we had following in the config:
> [pending]
> optio
postfix relies on /etc/aliases.db for forwarding mail, without this file
all mails get deferred. (see `man newaliases`)
Signed-off-by: Stoiko Ivanov
---
proxinstall | 2 ++
1 file changed, 2 insertions(+)
diff --git a/proxinstall b/proxinstall
index 6ee3aa0..5d02b34 100755
--- a/proxinstall
+++
The changeset fixes two issues with our ISO-installer:
* it ensures that 'newaliases is run upon new installations and once on upgrade
of pve-manger to a version > 6.0-10
* the written /etc/postfix/main.cf now contains 'compatibility_level=2'
One side-effect I'm not too sure about is, that if we
When installing from ISO '/etc/aliases' gets written correctly, however
postfix needs '/etc/aliases.db' (generated by running newaliases)
in order to work.
added to the postinst script to fix the issue for users having installed from
the ISO before this fix.
Signed-off-by: Stoiko Ivanov
---
deb
otherwise a warning was issued (when missing /etc/aliases.db) that the system
is using the backward compatible setting of $mydestination for $relay_domain
(see [0]).
[0] http://www.postfix.org/COMPATIBILITY_README.html#relay_domains
Signed-off-by: Stoiko Ivanov
---
proxinstall | 2 ++
1 file ch
On 10/23/19 6:10 PM, Stoiko Ivanov wrote:
> The changeset fixes two issues with our ISO-installer:
> * it ensures that 'newaliases is run upon new installations and once on
> upgrade
> of pve-manger to a version > 6.0-10
> * the written /etc/postfix/main.cf now contains 'compatibility_level=2'
>
On 10/23/19 10:27 AM, Tim Marx wrote:
> to improve UX, disabled fields shouldn't show validation errors.
can you please hint somewhere that not the ISO selector value itself,
but the radio-button boolean value for "use CD/DVD (ISO)"?
It's quite clear if one looks at the code but not so from the p
since we sort them while going through the delete hash, we can do it for
the other loops for consistency.
Signed-off-by: Oguz Bektas
---
src/PVE/LXC/Config.pm | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
index b744d4f..
On 10/22/19 11:17 AM, Fabian Grünbichler wrote:
> On October 21, 2019 12:12 pm, Wolfgang Link wrote:
>> On 10/18/19 11:22 AM, Fabian Grünbichler wrote:
>>> On October 14, 2019 1:08 pm, Wolfgang Link wrote:
+use base qw(PVE::SectionConfig);
>>> this would be the only SectionConfig that is not a
- mark it with coroutine_fn
- add an additional parameter 'name'
- return -1 on error (instead of 1)
- code cleanup
Signed-off-by: Dietmar Maurer
---
blockdev.c | 40 ++--
1 file changed, 26 insertions(+), 14 deletions(-)
diff --git a/blockdev.c b/blockdev.c
Signed-off-by: Dietmar Maurer
---
block/backup.c| 8 +++-
block/replication.c | 2 +-
blockdev.c| 10 ++
include/block/block_int.h | 4
4 files changed, 18 insertions(+), 6 deletions(-)
diff --git a/block/backup.c b/block/backup.c
index 5240f
The last block of a backup may be smaller than cluster_size.
Signed-off-by: Dietmar Maurer
---
block/backup.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/block/backup.c b/block/backup.c
index 2ccec79db6..cc20d77b9f 100644
--- a/block/backup.c
+++ b/block/backup.c
@@
24 matches
Mail list logo
