Re: [pve-devel] [PATCH pve-manager] POC: migrate_all: add auto best target selection

2019-10-07 Thread Alexandre DERUMIER
>>Great, no java ;P >>On a serious note, this look much more like something we can use. Yes, I have done a lot of search with something not too much complex, and portable with current code. >>IIUC, for now this works like a "re-distribute my VMs/CTs on the >>remaining nodes" yes >>What happ

Re: [pve-devel] [PATCH qemu-server] fix #2364: allow migration with local cloudinit disk in GUI

2019-10-07 Thread Mira Limbeck
Don't apply this. If we do it like this there's no local cloudinit disk conflict on live migration as well which is not supported. Looks like we have to do the check in the GUI. On 10/4/19 4:10 PM, Mira Limbeck wrote: Ignore a local cloudinit disk in the check for local disks. The cloudinit di

Re: [pve-devel] [PATCH v3 ha-manager 4/9] Add timeout parameter for shutdown

2019-10-07 Thread Fabian Ebner
On 10/4/19 5:34 PM, Thomas Lamprecht wrote: On 10/2/19 11:46 AM, Fabian Ebner wrote: Introduces a timeout parameter for shutting a resource down. If the parameter is 0, we perform a hard stop instead of a shutdown. Signed-off-by: Fabian Ebner --- src/PVE/HA/LRM.pm | 4 ++-- src

[pve-devel] [PATCH v3 pve-zsync 2/2] Detect other instances of the same job and improve checks for a disabled job

2019-10-07 Thread Fabian Ebner
A 'waiting' state is introduced and other 'waiting' and 'syncing' instances of the same job are now detected by moving the check out from the sync lock. There are two new checks that allow disabling a job while it is 'syncing' or 'waiting'. Previously when sync finished it would re-enable such a jo

[pve-devel] [PATCH v3 pve-zsync 1/2] Refactor locking

2019-10-07 Thread Fabian Ebner
This introduces a new locked() mechanism allowing to enclose locked sections in a cleaner way. There's only two types of locks namely one for state and cron (they are always read together and almost always written together) and one for sync. Signed-off-by: Fabian Ebner --- Changes from v2: *

[pve-devel] [PATCH v2 manager] fix #2364: allow offline migration with local cloudinit disk

2019-10-07 Thread Mira Limbeck
As the cloudinit disk itself does not get copied on an offline migration, just the config, there's no conflict. Ignore the local cloudinit disk on offline migration. Also adds a useful message when trying to live migrate with a local cloudinit disk. Signed-off-by: Mira Limbeck --- v2: - do the c

[pve-devel] cpu type ppc/s390

2019-10-07 Thread Tomas Dalebjörk
Hi I would like ask if it is possible to add other CPU types to the proxmox admin interface Such as PowerPC (ppc64le/be) and s390x I know that it is much slower than using it as native, but in some cases it might be performing good enogh? It can be goodif also proxmox can be hosted on other c

Re: [pve-devel] cpu type ppc/s390

2019-10-07 Thread Dietmar Maurer
> I would like ask if it is possible to add other CPU types to the proxmox > admin interface > Such as PowerPC (ppc64le/be) and s390x There are no plans to add ppc or s390. ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/c

[pve-devel] [PATCH docs] display: add URL and short explanation of SPICE

2019-10-07 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- There was no explanation of what SPICE is or a link to the project. qm.adoc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qm.adoc b/qm.adoc index 5f79547..e55fa50 100644 --- a/qm.adoc +++ b/qm.adoc @@ -636,7 +636,8 @@ necessary footnote

[pve-devel] [PATCH manager] ui: migrate: add checkbox to enable offline migration with local resources

2019-10-07 Thread Tim Marx
Added to make use of [0] and because it does make sense for non HA vm's as well, in accordance with #2241. [0] pve-ha-manager: 6e8b0c225405da9472f56fe5c94c94b204259caa Signed-off-by: Tim Marx --- www/manager6/window/Migrate.js | 63 +++--- 1 file changed, 50 insertion

[pve-devel] [PATCH qemu-server] Fix #2171: VM statefile was not activated

2019-10-07 Thread Alwin Antreich
Machine states that were created on snapshots with memory could not be restored on rollback. The state volume was not activated so KVM couldn't load the state. This patch moves the path generation into vm_start and de-/activates the state volume. Signed-off-by: Alwin Antreich --- PVE/QemuConfig

[pve-devel] [PATCH v4 cluster 03/12] Add "cpu-models.conf" to observed files

2019-10-07 Thread Stefan Reiter
Holds information about custom CPU models, section config style. Used in qemu-server. Signed-off-by: Stefan Reiter --- data/PVE/Cluster.pm | 1 + data/src/status.c | 1 + 2 files changed, 2 insertions(+) diff --git a/data/PVE/Cluster.pm b/data/PVE/Cluster.pm index 9cb68d8..f3f1704 100644 ---

[pve-devel] [PATCH v4 manager 01/12] Broadcast supported CPU flags

2019-10-07 Thread Stefan Reiter
pvestatd will check if the KVM version has changed using kvm_user_version (which automatically clears its cache if QEMU/KVM updates), and if it has, query supported CPU flags and broadcast them as key-value pairs to the cluster. If detection fails, we clear the kv-store and set up a delay (120s),

[pve-devel] [PATCH v4 qemu-server 06/12] Adapt CPUConfig to handle custom models

2019-10-07 Thread Stefan Reiter
Turn CPUConfig into a SectionConfig with parsing/writing support for custom CPU models. IO is handled using cfs. Namespacing will be provided using "custom-" prefix for custom model names (in VM config only, cpu-models.conf will contain unprefixed names). Signed-off-by: Stefan Reiter --- v4: Us

[pve-devel] [PATCH v4 qemu-server 07/12] Add overrides and convenience functions to CPUConfig

2019-10-07 Thread Stefan Reiter
Add two overrides to avoid writing redundant information to the config file. get_model_by_name is used to return a cpu config with default values filled out. Signed-off-by: Stefan Reiter --- v3 -> v4: * add is_custom_model v2 -> v3: * add validity checks to write_config PVE/QemuServer/CPUCo

[pve-devel] [PATCH v4 qemu-server 04/12] Add QEMU CPU flag querying helpers

2019-10-07 Thread Stefan Reiter
* query_understood_cpu_flags returns all flags that QEMU/KVM knows about * query_supported_cpu_flags returns all flags that QEMU/KVM can use on this particular host. To get supported flags, a temporary VM is started with QEMU, so we can issue the "query-cpu-model-expansion" QMP command. This is

[pve-devel] [PATCH v4 qemu-server 09/12] Add helpers to better structure CPU option handling

2019-10-07 Thread Stefan Reiter
To avoid hardcoding even more CPU-flag related things for custom CPU models, introduce a dynamic approach to resolving flags. resolve_cpu_flags takes a list of hashes (as documented in the comment) and resolves them to a valid "-cpu" argument without duplicates. This also helps by providing a reas

[pve-devel] [PATCH v4 qemu-server 05/12] Add CPUConfig file and migrate some helpers

2019-10-07 Thread Stefan Reiter
The package will be used for custom CPU models as a SectionConfig, hence the name. For now we simply move some CPU related helper functions and declarations over from QemuServer to reduce clutter there. qemu_machine_feature_enabled is moved to avoid a cyclic module dependency. Signed-off-by: Stef

[pve-devel] [PATCH v4 qemu-server 10/12] Rework get_cpu_options and allow custom CPU models

2019-10-07 Thread Stefan Reiter
If a cputype is custom (check via prefix), try to load options from the custom CPU model config, and set values accordingly. While at it, extract currently hardcoded values into seperate sub and add reasonings. Since the new flag resolving outputs flags in sorted order for consistency, adapt the

[pve-devel] [PATCH v4 qemu 02/12] Write understood CPU flags into static file

2019-10-07 Thread Stefan Reiter
located at /usr/share/kvm/cpu-flags-understood-$arch This file can be read by qemu-server's "query_understood_cpu_flags" function, avoiding a more expensive call to QEMU. For now, only x86_64 is implemented, since aarch64 doesn't print any flags when called this way. Signed-off-by: Stefan Reiter

[pve-devel] [PATCH v4 qemu-server 08/12] Verify VM-specific CPU configs seperately

2019-10-07 Thread Stefan Reiter
$cpu_fmt is being reused for custom CPUs as well as VM-specific CPU settings. The "pve-vm-cpu-conf" format is introduced to verify a config specifically for use as VM-specific settings. Signed-off-by: Stefan Reiter --- v3 -> v4: * use is_custom_model v2 -> v3: * move $cpu_fmt->{flags} changes h

[pve-devel] [PATCH v4 qemu-server 11/12] fix #2318: allow phys-bits and host-phys-bits CPU settings

2019-10-07 Thread Stefan Reiter
Can be specified for a particular VM or via a custom CPU model (VM takes precedence). QEMU's default limit only allows up to 1TB of RAM per VM. Increasing the physical address bits available to a VM can fix this. Signed-off-by: Stefan Reiter --- v2 -> v3: * add minimum to phys-bits (8) PVE/Q

[pve-devel] [PATCH v4 qemu-server 12/12] cfg2cmd: add test case for custom CPU model

2019-10-07 Thread Stefan Reiter
Requires a mock CPU-model config, which is given as a raw string to also test parsing capabilities. Signed-off-by: Stefan Reiter --- test/cfg2cmd/custom-cpu-model.conf | 8 test/run_config2command_tests.pl | 21 + 2 files changed, 29 insertions(+) create mode 100

[pve-devel] [PATCH v4 00/12] Add basics for custom CPU models

2019-10-07 Thread Stefan Reiter
Based on the RFC and following on- and off-list discussion about custom CPU models [0]. In essence, this revised patch allows a user to specify custom CPU models in /etc/pve/cpu-models.conf (section-config style [1]), where VMs using that CPU model inherit details from the definition. This removes

[pve-devel] [PATCH v4 docs 1/3] add spice enhancements documentation

2019-10-07 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- qm.adoc | 63 + 1 file changed, 63 insertions(+) diff --git a/qm.adoc b/qm.adoc index 0a1dfa6..6eada34 100644 --- a/qm.adoc +++ b/qm.adoc @@ -819,6 +819,69 @@ start after those where the parameter is set.

[pve-devel] [PATCH v4 manager 3/3] ui: vm-options: add spice enhancements

2019-10-07 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- As suggested by Thomas in [0] I removed the gettext around the feature names to have the same feature names accross all translations. This should help if people start searching for a problem with them. Removed the check if values is falsy because parsePropertySt

[pve-devel] [PATCH v4 manager 2/3] ui: add spice enhancements form component

2019-10-07 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- As suggested by Thomas in [0] I removed the gettext around the feature names to have the same feature names accross all translations. This should help if people start searching for a problem with them. The check if the hint to set SPICE in display is using a reg

[pve-devel] [PATCH v4 0/3] Fix #2041, #2272 GUI for Spice Enhancements

2019-10-07 Thread Aaron Lauterer
With the server side patches applied[0] the GUI part for this was missing. This patch series adds the two current SPICE enhancements (folder sharing, video streaming) to the Options panel of a VM along with the needed documentation. Adding them to the VM creation wizard has been postponed for now.

Re: [pve-devel] [PATCH v4 qemu-server 12/12] cfg2cmd: add test case for custom CPU model

2019-10-07 Thread Thomas Lamprecht
On 10/7/19 2:47 PM, Stefan Reiter wrote: > Requires a mock CPU-model config, which is given as a raw string to also > test parsing capabilities. > > Signed-off-by: Stefan Reiter > --- > test/cfg2cmd/custom-cpu-model.conf | 8 much thanks for the test. Normally the test result ".cmd" fi

[pve-devel] applied: [PATCH v4 docs 1/3] add spice enhancements documentation

2019-10-07 Thread Thomas Lamprecht
On 10/7/19 3:23 PM, Aaron Lauterer wrote: > Signed-off-by: Aaron Lauterer > --- > > qm.adoc | 63 + > 1 file changed, 63 insertions(+) > applied, thanks! Did a small fixup (4th order headings do not show up in PDFs/Manpages: 8< d

[pve-devel] applied: [PATCH v4 manager 2/3] ui: add spice enhancements form component

2019-10-07 Thread Thomas Lamprecht
On 10/7/19 3:23 PM, Aaron Lauterer wrote: > Signed-off-by: Aaron Lauterer > --- > > As suggested by Thomas in [0] I removed the gettext around the feature > names to have the same feature names accross all translations. This > should help if people start searching for a problem with them. > > Th

[pve-devel] applied: [PATCH v4 manager 3/3] ui: vm-options: add spice enhancements

2019-10-07 Thread Thomas Lamprecht
On 10/7/19 3:23 PM, Aaron Lauterer wrote: > Signed-off-by: Aaron Lauterer > --- > > As suggested by Thomas in [0] I removed the gettext around the feature > names to have the same feature names accross all translations. This > should help if people start searching for a problem with them. > > Re

[pve-devel] applied: [PATCH docs] display: add URL and short explanation of SPICE

2019-10-07 Thread Thomas Lamprecht
On 10/7/19 12:56 PM, Aaron Lauterer wrote: > Signed-off-by: Aaron Lauterer > --- > > There was no explanation of what SPICE is or a link to the project. > > qm.adoc | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/qm.adoc b/qm.adoc > index 5f79547..e55fa50 100644 > --

Re: [pve-devel] applied: [PATCH v4 docs 1/3] add spice enhancements documentation

2019-10-07 Thread Aaron Lauterer
On 10/7/19 4:06 PM, Thomas Lamprecht wrote: On 10/7/19 3:23 PM, Aaron Lauterer wrote: Signed-off-by: Aaron Lauterer --- qm.adoc | 63 + 1 file changed, 63 insertions(+) applied, thanks! Did a small fixup (4th order headings do no

Re: [pve-devel] cpu type ppc/s390

2019-10-07 Thread Tomas Dalebjörk
ok that is sad as qemu support other architectures so it cant be that difficult Skickat från min iPhone > 7 okt. 2019 kl. 12:32 skrev Dietmar Maurer : > >  >> >> I would like ask if it is possible to add other CPU types to the proxmox >> admin interface >> Such as PowerPC (ppc64le/be) and

Re: [pve-devel] cpu type ppc/s390

2019-10-07 Thread Thomas Lamprecht
On 10/7/19 4:54 PM, Tomas Dalebjörk wrote: > ok > > that is sad > as qemu support other architectures > so it cant be that difficult > Yes, qemu itself supports them, that's not the issue. But one needs to do the whole management around the CPU and it's platforms hardware, that's what Proxmox V

Re: [pve-devel] scsi-hd vs scsi-generic with iSCSI

2019-10-07 Thread Daniel Berteaud
- Le 2 Oct 19, à 18:41, Daniel Berteaud dan...@firewall-services.com a écrit : > - Le 30 Sep 19, à 11:52, Thomas Lamprecht t.lampre...@proxmox.com a écrit > : > >> >> Depends on the outcome of above, but effectively we would like to >> not have the choice between "working or not", so

Re: [pve-devel] cpu type ppc/s390

2019-10-07 Thread Tomas Dalebjörk
thanks for feedback you know that power is an open architecture that are growing on the market as it performs better than x Skickat från min iPhone > 7 okt. 2019 kl. 17:17 skrev Thomas Lamprecht : > > On 10/7/19 4:54 PM, Tomas Dalebjörk wrote: >> ok >> >> that is sad >> as qemu support othe

[pve-devel] Trying to use spice enhancements

2019-10-07 Thread Gilberto Nunes
Hi there I am trying to use spice foldersharing... I enable it with this command: qm set 100 -spice_enhancements foldersharing=1,videostreaming=all But when I try to start the VM I get this error: qm start 100 kvm: -device virtserialport,chardev=foldershare,name=org.spice-space.webdav.0: No 'virt

Re: [pve-devel] Trying to use spice enhancements

2019-10-07 Thread Gilberto Nunes
Never mind I forget to enable qemu agent in the VM... Thanks --- Gilberto Nunes Ferreira (47) 3025-5907 (47) 99676-7530 - Whatsapp / Telegram Skype: gilberto.nunes36 Em seg, 7 de out de 2019 às 14:46, Gilberto Nunes < gilberto.nune...@gmail.com> escreveu: > Hi there > > I am trying to

[pve-devel] Spice foldersharing

2019-10-07 Thread Gilberto Nunes
I get this error (spice-webdavd.exe:2080): phodav-←[1;31mERROR←[0m **: The service process could not connect to the service controller. Using windows xp... Already install spice-webdav and there's agent enabled in VM. I have enable spice foldersharing with qm set 100 -spice_enhancements folders

[pve-devel] [PATCH manager/widget-toolkit] pull pve-hint into proxmox-widet-toolkit

2019-10-07 Thread Stoiko Ivanov
Since we need the pve-hint css-class in pmg as well this patchset pulls the definition into proxmox-widget-toolkit and changes its use throughout pve-manager. widget-toolkit: Stoiko Ivanov (1): add pmx-hint css class css/ext6-pmx.css | 4 1 file changed, 4 insertions(+) pve-manager: Stoi

[pve-devel] [PATCH widget-toolkit 1/1] add pmx-hint css class

2019-10-07 Thread Stoiko Ivanov
since we need it in PMG as well - pull it here (and independently refactor pve-manager) Signed-off-by: Stoiko Ivanov --- This patch also got sent to pmg-de...@proxmox.com with the dkim-series css/ext6-pmx.css | 4 1 file changed, 4 insertions(+) diff --git a/css/ext6-pmx.css b/css/ext6-pmx

[pve-devel] [PATCH manager 1/1] change .pve-hint to .pmx-hint css-class

2019-10-07 Thread Stoiko Ivanov
With introducing pmx-hint to pmg as well, by adding a 'pmx-hint' css-class to proxmox-widget-toolkit, it makes sense to use the definition everywhere. this patch drops the .pve-hint class from pve's css and replaces all occurences in the GUI-source. Signed-off-by: Stoiko Ivanov --- www/css/ext6-

Re: [pve-devel] cpu type ppc/s390

2019-10-07 Thread Thomas Lamprecht
On 10/7/19 7:20 PM, Tomas Dalebjörk wrote: > thanks for feedback > > you know that power is an open architecture that are growing on the market as > it performs better than x > I never saw or used one, just heard some non-ideal stories about vendors[0]. So still waiting before calling this the

Re: [pve-devel] Spice foldersharing

2019-10-07 Thread Thomas Lamprecht
On 10/7/19 9:12 PM, Gilberto Nunes wrote: > I get this error > > (spice-webdavd.exe:2080): phodav-←[1;31mERROR←[0m **: The service process > could > not connect to the service controller. > > Using windows xp... Already install spice-webdav and there's agent enabled > in VM. which version did yo

Re: [pve-devel] Trying to use spice enhancements

2019-10-07 Thread Aaron Lauterer
Thanks for finding that! I'm looking into it. On 10/7/19 7:53 PM, Gilberto Nunes wrote: Never mind I forget to enable qemu agent in the VM... Thanks --- Gilberto Nunes Ferreira (47) 3025-5907 (47) 99676-7530 - Whatsapp / Telegram Skype: gilberto.nunes36 Em seg, 7 de out de 2019 às

Re: [pve-devel] [PATCH qemu-server] Fix #2171: VM statefile was not activated

2019-10-07 Thread Fabian Grünbichler
On October 7, 2019 2:41 pm, Alwin Antreich wrote: > Machine states that were created on snapshots with memory could not be > restored on rollback. The state volume was not activated so KVM couldn't > load the state. > > This patch moves the path generation into vm_start and de-/activates the > sta