[pve-devel] applied: [PATCH cluster] fix #1380: pvecm status: add general cluster information

2019-10-04 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- there is other information which can make sense, so follow-ups welcome. We could also call into "corosync-cmapctl totem" or add this upstream to get the current runtime information, which may be a bit better suited here.. data/PVE/CLI/pvecm.pm | 19 ++

[pve-devel] [PATCH qemu-server] fix #2395: check for iscsi on efidisk creation

2019-10-04 Thread Dominik Csapak
otherwise qemu-img uses its default intiator id which may not have access Signed-off-by: Dominik Csapak --- PVE/QemuServer.pm | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 8376260..2267a3a 100644 --- a/PVE/QemuServer.

Re: [pve-devel] [PATCH v2 container 16/18] adapt config PUT method for the new update_pct_config

2019-10-04 Thread Fabian Grünbichler
On October 3, 2019 4:32 pm, Oguz Bektas wrote: > On Wed, Oct 02, 2019 at 01:52:58PM +0200, Fabian Grünbichler wrote: >> On September 30, 2019 2:44 pm, Oguz Bektas wrote: >> > we don't need to extract 'delete' here, instead we pass it all as $param >> > and extract 'delete', 'revert' and most other

[pve-devel] [PATCH manager] fix #2389: ceph wizard showing network of target node

2019-10-04 Thread Mira Limbeck
Before this patch the wizard shows the available networks for the node one is connected to, not the actual target node where ceph is configured. This patch changes this to access the network information of the target node instead of the local one. It could be that not every node in the cluster is

[pve-devel] [PATCH v3 manager 2/3] ui: add spice enhancements form component

2019-10-04 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- www/manager6/Makefile | 1 + www/manager6/form/SpiceEnhancementSelector.js | 60 +++ 2 files changed, 61 insertions(+) create mode 100644 www/manager6/form/SpiceEnhancementSelector.js diff --git a/www/manager6/Makefile b

[pve-devel] [PATCH docs 1/3] add spice enhancements documentation

2019-10-04 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- qm.adoc | 56 1 file changed, 56 insertions(+) diff --git a/qm.adoc b/qm.adoc index 0a1dfa6..583a248 100644 --- a/qm.adoc +++ b/qm.adoc @@ -819,6 +819,62 @@ start after those where the parameter is set. Fu

[pve-devel] [PATCH v3 0/3] Fix #2041, #2272 GUI for Spice Enhancements

2019-10-04 Thread Aaron Lauterer
With the server side patches applied[0] the GUI part for this was missing. This patch series adds the two current SPICE enhancements (folder sharing, video streaming) to the Options panel of a VM along with the needed documentation. Adding them to the VM creation wizard has been postponed for now.

[pve-devel] [PATCH v3 manager 3/3] ui: vm-options: add spice enhancements

2019-10-04 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- removing the check if values is true and changing the parameters in parsePropertyString to `parsePropertyString(values || {})` as suggested in [0] does not work. parsePropertyString expects a string. Passing anything except a string containing a `key=value` (there

[pve-devel] applied: [PATCH manager] Harmonize reset buttons in "My Settings"

2019-10-04 Thread Thomas Lamprecht
On 10/3/19 11:58 AM, Dominic Jäger wrote: > - Rename both buttons to a single word as it is clear where they belong > to. Use "Reset" instead of "Clear" as you can rather "Reset a saved > user name" than "Clear a layout". > - Use container instead of panels as they are simpler (e.g. no "border:

Re: [pve-devel] [PATCH manager] fix #2389: ceph wizard showing network of target node

2019-10-04 Thread Thomas Lamprecht
On 10/4/19 11:29 AM, Mira Limbeck wrote: > Before this patch the wizard shows the available networks for the node > one is connected to, not the actual target node where ceph is > configured. This patch changes this to access the network information of > the target node instead of the local one. >

Re: [pve-devel] [PATCH manager] fix #2389: ceph wizard showing network of target node

2019-10-04 Thread Mira Limbeck
On 10/4/19 3:03 PM, Thomas Lamprecht wrote: On 10/4/19 11:29 AM, Mira Limbeck wrote: Before this patch the wizard shows the available networks for the node one is connected to, not the actual target node where ceph is configured. This patch changes this to access the network information of the t

Re: [pve-devel] [PATCH docs 1/3] add spice enhancements documentation

2019-10-04 Thread Thomas Lamprecht
On 10/4/19 12:09 PM, Aaron Lauterer wrote: > Signed-off-by: Aaron Lauterer > --- > qm.adoc | 56 > 1 file changed, 56 insertions(+) > > diff --git a/qm.adoc b/qm.adoc > index 0a1dfa6..583a248 100644 > --- a/qm.adoc > +++ b/qm.adoc > @@ -81

[pve-devel] [PATCH qemu-server] fix #2364: allow migration with local cloudinit disk in GUI

2019-10-04 Thread Mira Limbeck
Ignore a local cloudinit disk in the check for local disks. The cloudinit disk does not get migrated, only the config does. The disk itself gets recreated on the new node when the VM is started. Signed-off-by: Mira Limbeck --- PVE/API2/Qemu.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/

Re: [pve-devel] [PATCH v3 manager 3/3] ui: vm-options: add spice enhancements

2019-10-04 Thread Thomas Lamprecht
On 10/4/19 12:09 PM, Aaron Lauterer wrote: > Signed-off-by: Aaron Lauterer > --- > removing the check if values is true and changing the parameters in > parsePropertyString to `parsePropertyString(values || {})` as suggested > in [0] does not work. > parsePropertyString expects a string. Passing a

Re: [pve-devel] [PATCH v3 manager 2/3] ui: add spice enhancements form component

2019-10-04 Thread Thomas Lamprecht
On 10/4/19 12:09 PM, Aaron Lauterer wrote: > Signed-off-by: Aaron Lauterer > --- > www/manager6/Makefile | 1 + > www/manager6/form/SpiceEnhancementSelector.js | 60 +++ > 2 files changed, 61 insertions(+) > create mode 100644 www/manager6/form/SpiceEnhan

[pve-devel] applied: [PATCH v3 ha-manager 1/9] Move code updating resource config from API2::HA::Resources to HA::Config

2019-10-04 Thread Thomas Lamprecht
On 10/2/19 11:46 AM, Fabian Ebner wrote: > This makes it easier to update the resource configuration from within the > CRM/LRM stack, > which is needed for the new 'stop' command. > > Signed-off-by: Fabian Ebner > --- > src/PVE/API2/HA/Resources.pm | 34 + > src/

Re: [pve-devel] [PATCH v3 ha-manager 3/9] Implement update_service_config for simulation

2019-10-04 Thread Thomas Lamprecht
On 10/2/19 11:46 AM, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > src/PVE/HA/Sim/Hardware.pm | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/src/PVE/HA/Sim/Hardware.pm b/src/PVE/HA/Sim/Hardware.pm > index 9c0ad05..3cdc85b 100644 > --- a/src/PVE/HA/Sim/Hardwa

Re: [pve-devel] [PATCH v3 ha-manager 6/9] Add stop command to simulation

2019-10-04 Thread Thomas Lamprecht
On 10/2/19 11:46 AM, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > src/PVE/HA/Sim/Hardware.pm | 8 > 1 file changed, 8 insertions(+) > > diff --git a/src/PVE/HA/Sim/Hardware.pm b/src/PVE/HA/Sim/Hardware.pm > index 3cdc85b..121cd1b 100644 > --- a/src/PVE/HA/Sim/Hardware.pm >

Re: [pve-devel] [PATCH v3 ha-manager 5/9] Introduce crm-command to CLI and add stop as a subcommand

2019-10-04 Thread Thomas Lamprecht
On 10/2/19 11:46 AM, Fabian Ebner wrote: > This should reduce confusion between the old 'set --state stopped' and > the new 'stop' command by making it explicit that it is sent as a crm command. > > Signed-off-by: Fabian Ebner > --- > src/PVE/CLI/ha_manager.pm | 46 +

Re: [pve-devel] [PATCH v3 ha-manager 8/9] Log timeout parameter when present

2019-10-04 Thread Thomas Lamprecht
On 10/2/19 11:46 AM, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > src/PVE/HA/LRM.pm | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/src/PVE/HA/LRM.pm b/src/PVE/HA/LRM.pm > index e5eee94..95ec351 100644 > --- a/src/PVE/HA/LRM.pm > +++ b/src/PVE/HA/LRM.pm

Re: [pve-devel] [PATCH v3 ha-manager 4/9] Add timeout parameter for shutdown

2019-10-04 Thread Thomas Lamprecht
On 10/2/19 11:46 AM, Fabian Ebner wrote: > Introduces a timeout parameter for shutting a resource down. > If the parameter is 0, we perform a hard stop instead of a shutdown. > > Signed-off-by: Fabian Ebner > --- > src/PVE/HA/LRM.pm | 4 ++-- > src/PVE/HA/Resources.pm | 2 +-

[pve-devel] [RFC ha-manager] add migrate shutdown policy with an maintenance mode POC

2019-10-04 Thread Thomas Lamprecht
This adds handling for a new shutdown policy, namely "migrate". If that is set then the LRM doesn't queues stop jobs, but transitions to a new mode, namely 'maintenance'. The lrm modes now get passed from the CRM in the NodeStatus update method, this allows to detect such a mode and make node-stat