Re: [pve-devel] [PATCH v2 ha-manager 07/12] Add stop command to the API

2019-10-01 Thread Fabian Ebner
On 9/30/19 5:13 PM, Thomas Lamprecht wrote: On 9/30/19 9:22 AM, Fabian Ebner wrote: Signed-off-by: Fabian Ebner --- src/PVE/API2/HA/Resources.pm | 37 src/PVE/CLI/ha_manager.pm| 2 ++ 2 files changed, 39 insertions(+) besides the nit^Wfact that the

[pve-devel] [PATCH container 3/3] use snapshot_tree guest helper for pct listsnapshot

2019-10-01 Thread Oguz Bektas
adds feature parity between qm/pct 'listsnapshot' w.r.t. showing snapshot tree ordered by date. Signed-off-by: Oguz Bektas --- src/PVE/CLI/pct.pm | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/src/PVE/CLI/pct.pm b/src/PVE/CLI/pct.pm index 35ad72f..0dd694b 100755

[pve-devel] [PATCH qemu-server 2/3] use snapshot_tree guest helper for qm listsnapshot

2019-10-01 Thread Oguz Bektas
Signed-off-by: Oguz Bektas --- PVE/CLI/qm.pm | 53 +-- 1 file changed, 1 insertion(+), 52 deletions(-) diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm index 17935d0..40571ce 100755 --- a/PVE/CLI/qm.pm +++ b/PVE/CLI/qm.pm @@ -933,58 +933,7 @@ our $cmddef

[pve-devel] [PATCH guest-common 1/3] reformat code for snapshot tree into GuestHelpers

2019-10-01 Thread Oguz Bektas
qm/pct listsnapshot lack feature parity w.r.t. showing snapshots in a tree ordered by the date. by moving this code into GuestHelpers, it can be shared. Signed-off-by: Oguz Bektas --- PVE/GuestHelpers.pm | 54 + 1 file changed, 54 insertions(+) diff -

Re: [pve-devel] [PATCH guest-common 1/3] reformat code for snapshot tree into GuestHelpers

2019-10-01 Thread Oguz Bektas
correction: s/reformat/refactor On Tue, Oct 01, 2019 at 09:32:45AM +0200, Oguz Bektas wrote: > qm/pct listsnapshot lack feature parity w.r.t. showing snapshots in a > tree ordered by the date. by moving this code into GuestHelpers, it can > be shared. > > Signed-off-by: Oguz Bektas > --- > PVE/

Re: [pve-devel] [PATCH pve-zsync] Allow detecting a syncing instance of a job

2019-10-01 Thread Fabian Grünbichler
On September 30, 2019 12:55 pm, Fabian Ebner wrote: > Before, the check whether a syncing instance of the same job is already > present > was inside the locked section. This caused cron to continuously spawn new > instances of pve-zsync on syncs (or rather groups of syncs) taking longer > than 15

Re: [pve-devel] [PATCH pve-zsync] Allow detecting a syncing instance of a job

2019-10-01 Thread Fabian Ebner
On 10/1/19 10:29 AM, Fabian Grünbichler wrote: On September 30, 2019 12:55 pm, Fabian Ebner wrote: Before, the check whether a syncing instance of the same job is already present was inside the locked section. This caused cron to continuously spawn new instances of pve-zsync on syncs (or rather

[pve-devel] [PATCH storage] Use bigger timeouts for zfs operations

2019-10-01 Thread Fabian Ebner
Seems like 'zfs destroy' can take longer than 5 seconds, see [0]. I changed the timeout to 15 seconds and also changed the default timeout to 10 instead of 5 seconds, to be on the safe side for other commands like 'zfs create'. [0]: https://forum.proxmox.com/threads/timeout-beim-l%C3%B6schen-des-

Re: [pve-devel] [PATCH storage] Use bigger timeouts for zfs operations

2019-10-01 Thread Fabian Grünbichler
On October 1, 2019 12:17 pm, Fabian Ebner wrote: > Seems like 'zfs destroy' can take longer than 5 seconds, see [0]. > I changed the timeout to 15 seconds and also changed the default > timeout to 10 instead of 5 seconds, to be on the safe side > for other commands like 'zfs create'. > > [0]: > h

[pve-devel] applied: [PATCH guest-common 1/3] reformat code for snapshot tree into GuestHelpers

2019-10-01 Thread Thomas Lamprecht
On 10/1/19 9:32 AM, Oguz Bektas wrote: > qm/pct listsnapshot lack feature parity w.r.t. showing snapshots in a > tree ordered by the date. by moving this code into GuestHelpers, it can > be shared. > > Signed-off-by: Oguz Bektas > --- > PVE/GuestHelpers.pm | 54 ++

Re: [pve-devel] [PATCH container 3/3] use snapshot_tree guest helper for pct listsnapshot

2019-10-01 Thread Thomas Lamprecht
On 10/1/19 9:33 AM, Oguz Bektas wrote: > adds feature parity between qm/pct 'listsnapshot' w.r.t. showing > snapshot tree ordered by date. > > Signed-off-by: Oguz Bektas > --- > src/PVE/CLI/pct.pm | 11 +-- > 1 file changed, 1 insertion(+), 10 deletions(-) > > diff --git a/src/PVE/CLI/p

Re: [pve-devel] [PATCH v2 manager 01/12] Broadcast supported CPU flags

2019-10-01 Thread Thomas Lamprecht
On 9/30/19 12:58 PM, Stefan Reiter wrote: > pvestatd will check if the KVM version has changed using > kvm_user_version (which automatically clears its cache if QEMU/KVM > updates), and if it has, query supported CPU flags and broadcast them as > a key-value pair to the cluster. > > Detects value

Re: [pve-devel] [PATCH v2 qemu-server 02/12] Add QEMU CPU flag querying helpers

2019-10-01 Thread Thomas Lamprecht
On 9/30/19 12:58 PM, Stefan Reiter wrote: > * query_understood_cpu_flags returns all flags that QEMU/KVM knows about > * query_supported_cpu_flags returns all flags that QEMU/KVM can use on > this particular host. > > To get supported flags, a temporary VM is started with QEMU, so we can > issue

Re: [pve-devel] [PATCH v2 qemu-server 03/12] Add CPUConfig file and migrate some CPU helpers

2019-10-01 Thread Thomas Lamprecht
On 9/30/19 12:58 PM, Stefan Reiter wrote: > The package will be used for custom CPU models as a SectionConfig, hence > the name. For now we simply move some CPU related helper functions and > declarations over from QemuServer to reduce clutter there. Single thing I'm not too sure is how "qemu_mach

Re: [pve-devel] [PATCH v2 qemu-server 10/12] cfg2cmd: fix tests for new CPU flag resolving

2019-10-01 Thread Thomas Lamprecht
On 9/30/19 12:58 PM, Stefan Reiter wrote: > The new flag resolving outputs flags in sorted order for consistency, > adapt the test cases to not break. > > Only the order is changed, not which flags are present. I'd like to have this change paired with the commit which triggers it, to not break bu

Re: [pve-devel] [PATCH v2 ha-manager 07/12] Add stop command to the API

2019-10-01 Thread Thomas Lamprecht
On 10/1/19 9:28 AM, Fabian Ebner wrote: > On 9/30/19 5:13 PM, Thomas Lamprecht wrote: >> On 9/30/19 9:22 AM, Fabian Ebner wrote: >>> Signed-off-by: Fabian Ebner >>> --- >>>   src/PVE/API2/HA/Resources.pm | 37 >>>   src/PVE/CLI/ha_manager.pm    |  2 ++ >>>   2 f

[pve-devel] applied: [PATCH zfsonlinux] followup: fpu struct initialized member was removed with 5.2

2019-10-01 Thread Thomas Lamprecht
That's why it was guarded with the "HAVE_KERNEL_FPU_INITIALIZED" defined in the first place.. Signed-off-by: Thomas Lamprecht --- ...r-save-restore-is-also-required-on-5.patch | 26 ++- 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/debian/patches/0008-SIMD-FPU-

Re: [pve-devel] [PATCH v2 qemu-server 02/12] Add QEMU CPU flag querying helpers

2019-10-01 Thread Thomas Lamprecht
On 9/30/19 12:58 PM, Stefan Reiter wrote: > * query_understood_cpu_flags returns all flags that QEMU/KVM knows about Why isn't that information generated and pve-qemu built-time and shipped in /usr/share or the like? It won't change independently of qemu so could make sense? Swaps way more expensi

Re: [pve-devel] [PATCH v2 qemu-server 04/12] Adapt CPUConfig to handle custom models

2019-10-01 Thread Thomas Lamprecht
On 9/30/19 12:58 PM, Stefan Reiter wrote: > Turn CPUConfig into a SectionConfig with parsing/writing support for > custom CPU models. IO is handled using cfs. > > The "custom" parameter provides differentiation between custom and > default types, even if the name is the same ('namespacing'). > >

Re: [pve-devel] [PATCH v2 qemu-server 05/12] Add overrides and convenience functions to CPUConfig

2019-10-01 Thread Thomas Lamprecht
On 9/30/19 12:58 PM, Stefan Reiter wrote: > Add two overrides to avoid writing redundant information to the config > file. > > get_model_by_name is used to return a cpu config with default values > filled out. > > Signed-off-by: Stefan Reiter > --- > PVE/QemuServer/CPUConfig.pm | 48 +++

Re: [pve-devel] [PATCH v2 qemu-server 06/12] Verify VM-specific CPU configs seperately

2019-10-01 Thread Thomas Lamprecht
On 9/30/19 12:58 PM, Stefan Reiter wrote: > $cpu_fmt is being reused for custom CPUs as well as VM-specific CPU > settings. The "pve-vm-cpu-conf" format is introduced to verify a config > specifically for use as VM-specific settings. > > Signed-off-by: Stefan Reiter > --- > PVE/QemuServer.pm

Re: [pve-devel] [PATCH v2 qemu-server 09/12] fix #2318: allow phys-bits and host-phys-bits CPU settings

2019-10-01 Thread Thomas Lamprecht
On 9/30/19 12:58 PM, Stefan Reiter wrote: > Can be specified for a particular VM or via a custom CPU model (VM takes > precedence). Maybe add a hint for why this is needed at all here too, something like: > allows to boot a VM with more than 1TB of memory > ... ? else I've no idea what this is fo

[pve-devel] applied: [PATCH v2 qemu-server 12/12] cfg2cmd: fix descriptions of cfg2cmd test cases

2019-10-01 Thread Thomas Lamprecht
On 9/30/19 12:58 PM, Stefan Reiter wrote: > Signed-off-by: Stefan Reiter > --- > > Independant from the rest of the series. > > test/cfg2cmd/i440fx-win10-hostpci.conf | 2 +- > test/cfg2cmd/q35-linux-hostpci.conf| 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/te