[pve-devel] [PATCH v2 ha-manager 04/12] Implement update_service_config for simulation

Signed-off-by: Fabian Ebner --- src/PVE/HA/Sim/Hardware.pm | 16 1 file changed, 16 insertions(+) diff --git a/src/PVE/HA/Sim/Hardware.pm b/src/PVE/HA/Sim/Hardware.pm index 8bd5cbd..d2c0ec0 100644 --- a/src/PVE/HA/Sim/Hardware.pm +++ b/src/PVE/HA/Sim/Hardware.pm @@ -109,6 +109,2

[pve-devel] [PATCH v2 ha-manager 06/12] Use timeout for shutdown in LRM

Signed-off-by: Fabian Ebner --- src/PVE/HA/LRM.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/PVE/HA/LRM.pm b/src/PVE/HA/LRM.pm index 3b4a572..e5eee94 100644 --- a/src/PVE/HA/LRM.pm +++ b/src/PVE/HA/LRM.pm @@ -535,7 +535,7 @@ sub manage_resources { my $req_

[pve-devel] [PATCH v2 ha-manager 01/12] Make parameters for LRM resource commands more flexible

This will allow for new parameters beside 'target' to be used. This is in preparation to allow for a 'timeout' parameter for a new 'stop' command. Signed-off-by: Fabian Ebner --- src/PVE/HA/LRM.pm | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/PVE/HA/LRM.

[pve-devel] [PATCH v2 ha-manager 11/12] Log timeout parameter when present

Signed-off-by: Fabian Ebner --- src/PVE/HA/LRM.pm | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/PVE/HA/LRM.pm b/src/PVE/HA/LRM.pm index e5eee94..95ec351 100644 --- a/src/PVE/HA/LRM.pm +++ b/src/PVE/HA/LRM.pm @@ -774,7 +774,11 @@ sub exec_resource_agent { r

[pve-devel] [PATCH v2 ha-manager 07/12] Add stop command to the API

Signed-off-by: Fabian Ebner --- src/PVE/API2/HA/Resources.pm | 37 src/PVE/CLI/ha_manager.pm| 2 ++ 2 files changed, 39 insertions(+) diff --git a/src/PVE/API2/HA/Resources.pm b/src/PVE/API2/HA/Resources.pm index 2b62ee8..ecc5f0c 100644 --- a/src/PVE/API

[pve-devel] [PATCH v2 ha-manager 08/12] Rename target to param in simulation

In preparation to introduce a stop command with a timeout parameter. Signed-off-by: Fabian Ebner --- src/PVE/HA/Sim/Hardware.pm | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/PVE/HA/Sim/Hardware.pm b/src/PVE/HA/Sim/Hardware.pm index d2c0ec0..ac0c142 10

[pve-devel] [PATCH v2 ha-manager 09/12] Add stop command to simulation

Signed-off-by: Fabian Ebner --- src/PVE/HA/Sim/Hardware.pm | 8 1 file changed, 8 insertions(+) diff --git a/src/PVE/HA/Sim/Hardware.pm b/src/PVE/HA/Sim/Hardware.pm index ac0c142..7e1a8bc 100644 --- a/src/PVE/HA/Sim/Hardware.pm +++ b/src/PVE/HA/Sim/Hardware.pm @@ -543,6 +543,7 @@ sub ge

[pve-devel] [PATCH v2 ha-manager 05/12] Add timeout parameter for shutdown

Introduces a timeout parameter for shutting a resource down. If the parameter is 0, we perform a hard stop instead of a shutdown. Signed-off-by: Fabian Ebner --- src/PVE/HA/Resources.pm | 2 +- src/PVE/HA/Resources/PVECT.pm | 14 ++ src/PVE/HA/Resources/PVEVM.pm | 16 +

[pve-devel] [PATCH v2 ha-manager 00/12] Implement a stop command for HA

This patch series introduces a new 'stop' command for ha-manager. The command takes a timeout parameter and in case it is 0, it performs a hard stop. The series also includes a test for the new command. A few changes to how parameters were handled in CRM/LRM were necessary as well as allowing the

[pve-devel] [PATCH v2 ha-manager 03/12] Add update_service_config to HA environment interface

Signed-off-by: Fabian Ebner --- src/PVE/HA/Env.pm | 6 ++ src/PVE/HA/Env/PVE2.pm | 6 ++ src/PVE/HA/Sim/Env.pm | 6 ++ 3 files changed, 18 insertions(+) diff --git a/src/PVE/HA/Env.pm b/src/PVE/HA/Env.pm index bb37486..7acd7c5 100644 --- a/src/PVE/HA/Env.pm +++ b/src/PVE/HA/Env

[pve-devel] [PATCH v2 ha-manager 02/12] Move code updating resource config from API2::HA::Resources to HA::Config

This makes it easier to update the resource configuration from within the CRM/LRM stack, which is needed for the new 'stop' command. Signed-off-by: Fabian Ebner --- src/PVE/API2/HA/Resources.pm | 34 + src/PVE/HA/Config.pm | 37 +++

[pve-devel] [PATCH v2 ha-manager 12/12] Add test for the stop command

Signed-off-by: Fabian Ebner --- src/test/test-stop-command1/README | 2 + src/test/test-stop-command1/cmdlist | 8 +++ src/test/test-stop-command1/hardware_status | 5 ++ src/test/test-stop-command1/log.expect | 69 + src/test/test-stop-command1/manage

[pve-devel] [PATCH v2 ha-manager 10/12] Add crm command 'stop'

Not every command parameter is 'target' anymore, so it was necessary to modify the parsing of $sd->{cmd}. Just changing the state to request_stop is not enough, we need to actually update the service configuration as well. Signed-off-by: Fabian Ebner --- src/PVE/HA/Manager.pm | 27 +

[pve-devel] [PATCH pve-network 3/8] add faucet sdn controller plugins

1 plugin for controller, 1 plugin for dataplane This is not 100% complete, but it's a proof of concept to test differents sdn controller Signed-off-by: Alexandre Derumier --- PVE/API2/Network/SDN.pm| 3 + PVE/Network/SDN.pm | 19 ++ PVE/Network/SDN/FaucetPlugi

[pve-devel] [PATCH pve-network 4/8] add evpnplugin (splitted from vxlanplugin)

Signed-off-by: Alexandre Derumier --- PVE/API2/Network/SDN.pm| 1 + PVE/Network/SDN.pm | 2 + PVE/Network/SDN/EvpnPlugin.pm | 200 + PVE/Network/SDN/Makefile | 2 +- PVE/Network/SDN/VxlanPlugin.pm | 54 - test/documentation

[pve-devel] [PATCH pve-network 5/8] add controller_reload

Signed-off-by: Alexandre Derumier --- PVE/Network/SDN.pm | 17 + PVE/Network/SDN/FaucetPlugin.pm | 11 +++ PVE/Network/SDN/FrrPlugin.pm| 18 ++ PVE/Network/SDN/Plugin.pm | 6 ++ 4 files changed, 52 insertions(+) diff --git a/PVE

[pve-devel] [PATCH pve-network 7/8] add qinq plugin

move code from vlanplugin, add transport tag option Signed-off-by: Alexandre Derumier --- PVE/API2/Network/SDN.pm | 1 + PVE/Network/SDN.pm| 2 + PVE/Network/SDN/Makefile | 2 +- PVE/Network/SDN/QinQPlugin.pm | 81 +++ PVE/Network/SDN/Vla

[pve-devel] [PATCH pve-network 0/8] generic sdn controller plugins + improvments

This patch serie mainly rework the plugins to manage sdn controllers. currently it was working with frr only, now it's possible to define differents plugins for sdn controllers. Frr specific code has been move to his own plugins too. For true sdn, we have 2 plugins, 1 for dataplane (switch/bridge

[pve-devel] [PATCH pve-network 8/8] api2 : sdn : add role and type to index

Signed-off-by: Alexandre Derumier --- PVE/API2/Network/SDN.pm | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/PVE/API2/Network/SDN.pm b/PVE/API2/Network/SDN.pm index 36d293d..b6dd23e 100644 --- a/PVE/API2/Network/SDN.pm +++ b/PVE/API2/Network/SDN.pm @@ -61,7 +61,10

[pve-devel] [PATCH pve-network 2/8] vxlan: move transport controller config to frrplugin

To be able to use differents controllers model Signed-off-by: Alexandre Derumier --- PVE/Network/SDN.pm | 4 +-- PVE/Network/SDN/FrrPlugin.pm | 51 ++ PVE/Network/SDN/VxlanPlugin.pm | 50 - 3 files changed, 53 inserti

[pve-devel] [PATCH pve-network 6/8] rename plugins with controllers

For true sdn, We have 2 plugins, 1 for dataplane (switch), 1 for controlplane (controller) rename: - Frr to EvpnController - Faucet to FaucetController - OvsFaucet to Faucet Signed-off-by: Alexandre Derumier --- PVE/API2/Network/SDN.pm | 4 +- PVE/Network/SDN.pm

[pve-devel] [PATCH pve-network 1/8] make sdn controller plugin generic

move all code for frr to frrplugin, rename router option to controller. This will allow to manage more controller in the future (ovn, faucet,) Signed-off-by: Alexandre Derumier --- PVE/Network/SDN.pm | 148 +++-- PVE/Network/SDN/FrrPlugin.pm | 114 +

[pve-devel] [PATCH pve-manager] api2: network : reload sdn controller generic

From: root use config generation && reloading from plugins (require my last pve-network patch serie) Signed-off-by: Alexandre Derumier --- PVE/API2/Network.pm | 25 + 1 file changed, 5 insertions(+), 20 deletions(-) diff --git a/PVE/API2/Network.pm b/PVE/API2/Network.p

Re: [pve-devel] [PATCH v2 container] don't duplicate lxc.idmap entries during restore

seems good to me. (note: maybe send in again as separate mail? had to edit the mail because commit message wasn't picked up right and apply with --ignore-whitespace) Tested-by: Oguz Bektas On Wed, Sep 25, 2019 at 02:37:32PM +0200, Fabian Grünbichler wrote: > On September 25, 2019 1:30 pm, Oguz B

[pve-devel] [PATCH v2 pve-manager] api2: network : reload sdn controller generic

use config generation && reloading from plugins (require my last pve-network patch serie) Signed-off-by: Alexandre Derumier --- PVE/API2/Network.pm | 25 + 1 file changed, 5 insertions(+), 20 deletions(-) diff --git a/PVE/API2/Network.pm b/PVE/API2/Network.pm index fa605

[pve-devel] applied: [PATCH RESEND container] restore lxc.* entries once

either via recover_config, OR via restore_configuration. non-root behaviour stays the same. Tested-by: Oguz Bektas Signed-off-by: Fabian Grünbichler --- Note: added Tested-by src/PVE/API2/LXC.pm | 4 ++-- src/PVE/LXC/Create.pm | 16 ++-- 2 files changed, 8 insertions(+), 12 del

[pve-devel] [PATCH manager] ui: qemubiosedit: add gettext to efi disk hint

Signed-off-by: Aaron Lauterer --- Put the hint in one line because AFAIU our tooling cannot handle multiline gettext calls. www/manager6/qemu/QemuBiosEdit.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/www/manager6/qemu/QemuBiosEdit.js b/www/manager6/qemu/QemuBiosEdit

[pve-devel] [PATCH qemu-server] qemu 4.0 : add Cascadelake-Server && KnightsMill cpu models

Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 70ed910..8376260 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -146,6 +146,9 @@ my $cpu_vendor_list = { 'Skylake-Client-IBRS'

[pve-devel] [PATCH pve-manager] cpumodel: qemu 4.0: add Skylake-Server, Cascadelake-Server, KnightsMill

Signed-off-by: Alexandre Derumier --- www/manager6/form/CPUModelSelector.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/www/manager6/form/CPUModelSelector.js b/www/manager6/form/CPUModelSelector.js index 9eb5b0e9..505d27c8 100644 --- a/www/manager6/form/CPUModelSelector.js +++ b/www/m

Re: [pve-devel] scsi-hd vs scsi-generic with iSCSI

On 9/30/19 8:00 AM, Daniel Berteaud wrote: > - Le 30 Sep 19, à 7:04, Thomas Lamprecht t.lampre...@proxmox.com a écrit : > >> But the interesting thing would be, why is there an issue with scsi-generic, >> i.e., the underlying issue for the two Bugs. IIUC, Dietmar had in mind to >> try to fix t

[pve-devel] [PATCH pve-zsync] Allow detecting a syncing instance of a job

Before, the check whether a syncing instance of the same job is already present was inside the locked section. This caused cron to continuously spawn new instances of pve-zsync on syncs (or rather groups of syncs) taking longer than 15 minutes, see [0] in the forum. This patch introduces a new lock

[pve-devel] [PATCH v2 00/12] Add basics for custom CPU models

Based on the RFC and following on- and off-list discussion about custom CPU models [0]. In essence, this revised patch allows a user to specify custom CPU models in /etc/pve/cpu-models.conf (section-config style [1]), where VMs using that CPU model inherit details from the definition. This removes

[pve-devel] [PATCH v2 manager 01/12] Broadcast supported CPU flags

pvestatd will check if the KVM version has changed using kvm_user_version (which automatically clears its cache if QEMU/KVM updates), and if it has, query supported CPU flags and broadcast them as a key-value pair to the cluster. Detects value regressions and handles them gracefully (i.e. if query

[pve-devel] [PATCH v2 qemu-server 02/12] Add QEMU CPU flag querying helpers

* query_understood_cpu_flags returns all flags that QEMU/KVM knows about * query_supported_cpu_flags returns all flags that QEMU/KVM can use on this particular host. To get supported flags, a temporary VM is started with QEMU, so we can issue the "query-cpu-model-expansion" QMP command. This is

[pve-devel] [PATCH v2 qemu-server 04/12] Adapt CPUConfig to handle custom models

Turn CPUConfig into a SectionConfig with parsing/writing support for custom CPU models. IO is handled using cfs. The "custom" parameter provides differentiation between custom and default types, even if the name is the same ('namespacing'). Signed-off-by: Stefan Reiter --- PVE/QemuServer/CPUCon

[pve-devel] [PATCH v2 qemu-server 09/12] fix #2318: allow phys-bits and host-phys-bits CPU settings

Can be specified for a particular VM or via a custom CPU model (VM takes precedence). Signed-off-by: Stefan Reiter --- PVE/QemuServer/CPUConfig.pm | 24 1 file changed, 24 insertions(+) diff --git a/PVE/QemuServer/CPUConfig.pm b/PVE/QemuServer/CPUConfig.pm index e595a69

[pve-devel] [PATCH v2 qemu-server 12/12] cfg2cmd: fix descriptions of cfg2cmd test cases

Signed-off-by: Stefan Reiter --- Independant from the rest of the series. test/cfg2cmd/i440fx-win10-hostpci.conf | 2 +- test/cfg2cmd/q35-linux-hostpci.conf| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test/cfg2cmd/i440fx-win10-hostpci.conf b/test/cfg2cmd/i440fx-wi

[pve-devel] [PATCH v2 qemu-server 06/12] Verify VM-specific CPU configs seperately

$cpu_fmt is being reused for custom CPUs as well as VM-specific CPU settings. The "pve-vm-cpu-conf" format is introduced to verify a config specifically for use as VM-specific settings. Signed-off-by: Stefan Reiter --- PVE/QemuServer.pm | 2 +- PVE/QemuServer/CPUConfig.pm | 68 +++

[pve-devel] [PATCH v2 qemu-server 11/12] cfg2cmd: add test case for custom CPU model

Requires a mock CPU-model config, which is given as a raw string to also test parsing capabilities. Signed-off-by: Stefan Reiter --- test/cfg2cmd/custom-cpu-model.conf | 8 test/run_config2command_tests.pl | 21 + 2 files changed, 29 insertions(+) create mode 100

[pve-devel] [PATCH v2 qemu-server 10/12] cfg2cmd: fix tests for new CPU flag resolving

The new flag resolving outputs flags in sorted order for consistency, adapt the test cases to not break. Only the order is changed, not which flags are present. Signed-off-by: Stefan Reiter --- test/cfg2cmd/i440fx-win10-hostpci.conf.cmd | 2 +- test/cfg2cmd/minimal-defaults.conf.cmd | 2 +-

[pve-devel] [PATCH v2 qemu-server 07/12] Add helpers to better structure CPU option handling

To avoid hardcoding even more CPU-flag related things for custom CPU models, introduce a dynamic approach to resolving flags. resolve_cpu_flags takes a list of hashes (as documented in the comment) and resolves them to a valid "-cpu" argument without duplicates. This also helps by providing a reas

[pve-devel] [PATCH v2 qemu-server 03/12] Add CPUConfig file and migrate some CPU helpers

The package will be used for custom CPU models as a SectionConfig, hence the name. For now we simply move some CPU related helper functions and declarations over from QemuServer to reduce clutter there. Signed-off-by: Stefan Reiter --- PVE/QemuServer.pm | 242 +-

[pve-devel] [PATCH v2 qemu-server 08/12] Rework get_cpu_options and allow custom CPU models

If the "custom" property on the cpu config is set, try to load the cputype from the custom CPU model config, and set values accordingly. While at it, extract currently hardcoded values into seperate sub and add reasonings. Signed-off-by: Stefan Reiter --- It was quite interesting to dig through

[pve-devel] [PATCH v2 qemu-server 05/12] Add overrides and convenience functions to CPUConfig

Add two overrides to avoid writing redundant information to the config file. get_model_by_name is used to return a cpu config with default values filled out. Signed-off-by: Stefan Reiter --- PVE/QemuServer/CPUConfig.pm | 48 + 1 file changed, 48 insertions(+)

[pve-devel] [PATCH v2 guest-common 01/18] refactor pending changes related config code into AbstractConfig

also use a better naming scheme for methods: split_flagged_list -> parse_pending_delete join_flagged_list -> print_pending_delete vmconfig_delete_pending_option -> add_to_pending_delete vmconfig_undelete_pending_option -> remove_from_pending_delete vmconfig_cleanup_pending -> cleanup_pending Sign

[pve-devel] [PATCH v2 qemu-server 06/18] refactor pending changes related code

most of the pending changes related code has been moved into AbstractConfig, so we have to call them as class methods from QemuConfig instead. Signed-off-by: Oguz Bektas --- PVE/API2/Qemu.pm | 14 - PVE/QemuServer.pm | 79 +-- 2 files changed

[pve-devel] [PATCH v2 qemu-server 05/18] use load_current_config for config GET call

Signed-off-by: Oguz Bektas --- PVE/API2/Qemu.pm | 35 +-- 1 file changed, 1 insertion(+), 34 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 267a08e..aa1cd16 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -865,40 +865,7 @@ __PACKAGE__-

[pve-devel] [PATCH v2 qemu-server 07/18] use format_pending from GuestHelpers for 'qm pending' command

Signed-off-by: Oguz Bektas --- PVE/CLI/qm.pm | 28 +--- 1 file changed, 1 insertion(+), 27 deletions(-) diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm index 17935d0..2f1969a 100755 --- a/PVE/CLI/qm.pm +++ b/PVE/CLI/qm.pm @@ -898,33 +898,7 @@ our $cmddef = {

[pve-devel] [PATCH v2 00/18] lxc pending changes

this series makes it possible to add/delete/revert pending changes in the backend for containers. this v2 took longer than expected, mainly because there were small bugs popping up everywhere, everytime i tried to change anything :) big thanks to fabian for the extensive review on v1, and for put

[pve-devel] [PATCH v2 qemu-server 04/18] overwrite load_current_config from AbstractConfig

we overwrite the load_current_config method from AbstractConfig, in order to handle cipassword. Signed-off-by: Oguz Bektas --- PVE/QemuConfig.pm | 14 ++ 1 file changed, 14 insertions(+) diff --git a/PVE/QemuConfig.pm b/PVE/QemuConfig.pm index edbf1a7..7f229b3 100644 --- a/PVE/QemuC

[pve-devel] [PATCH v2 container 11/18] use load_current_config for config GET call

Signed-off-by: Oguz Bektas --- src/PVE/API2/LXC/Config.pm | 22 -- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/src/PVE/API2/LXC/Config.pm b/src/PVE/API2/LXC/Config.pm index 769fc3b..7eaef74 100644 --- a/src/PVE/API2/LXC/Config.pm +++ b/src/PVE/API2/LXC/Confi

[pve-devel] [PATCH v2 guest-common 02/18] refactor method used by config GET calls into AbstractConfig

since this method will be both used by qemu and lxc config GET calls, it makes sense to move it into AbstractConfig. only difference is that qemu also hides the cipassword when it's set. this can be handled by having qemu overwrite the method and add the cipassword code. Signed-off-by: Oguz Bektas

[pve-devel] [PATCH v2 guest-common 03/18] refactor code from qm/pct 'pending' call into AbstractConfig

Signed-off-by: Oguz Bektas --- PVE/GuestHelpers.pm | 26 ++ 1 file changed, 26 insertions(+) diff --git a/PVE/GuestHelpers.pm b/PVE/GuestHelpers.pm index ebe2781..a16433f 100644 --- a/PVE/GuestHelpers.pm +++ b/PVE/GuestHelpers.pm @@ -60,4 +60,30 @@ sub exec_hookscript {

[pve-devel] [PATCH v2 container 10/18] adapt CT config parser for pending changes

config parser can now read/write [pve:pending] section. this was named such, instead of [PENDING], after on- and offline discussion regarding namespacing the pending section and snapshots. this also adds an optional non-capturing regex group into the parser for [snap: snapname] entries which can b

[pve-devel] [PATCH v2 container 08/18] add lxc/pending API path

Signed-off-by: Oguz Bektas --- src/PVE/API2/LXC.pm | 88 + 1 file changed, 88 insertions(+) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index 07280fb..9c040d1 100644 --- a/src/PVE/API2/LXC.pm +++ b/src/PVE/API2/LXC.pm @@ -515,6 +515,7 @@ __P

[pve-devel] [PATCH v2 container 09/18] add 'pct pending'

same as 'qm pending', the code is shared via GuestHelpers Signed-off-by: Oguz Bektas --- src/PVE/CLI/pct.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/PVE/CLI/pct.pm b/src/PVE/CLI/pct.pm index 35ad72f..476f44d 100755 --- a/src/PVE/CLI/pct.pm +++ b/src/PVE/CLI/pct.pm @@ -7,6 +7,7

[pve-devel] [PATCH v2 container 12/18] skip pending changes while cloning

Signed-off-by: Oguz Bektas --- src/PVE/API2/LXC.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index 9c040d1..2cb9f9d 100644 --- a/src/PVE/API2/LXC.pm +++ b/src/PVE/API2/LXC.pm @@ -1441,6 +1441,7 @@ __PACKAGE__->register_method({ #

[pve-devel] [PATCH v2 container 15/18] add revert parameter to config PUT

Signed-off-by: Oguz Bektas --- src/PVE/API2/LXC/Config.pm | 5 + 1 file changed, 5 insertions(+) diff --git a/src/PVE/API2/LXC/Config.pm b/src/PVE/API2/LXC/Config.pm index 7eaef74..2c036f5 100644 --- a/src/PVE/API2/LXC/Config.pm +++ b/src/PVE/API2/LXC/Config.pm @@ -102,6 +102,11 @@ __PACKAGE

[pve-devel] [PATCH v2 container 18/18] add vmconfig_hotplug_pending and vmconfig_apply_pending

vmconfig_hotplug_pending is responsible for checking if a key/value pair in the pending section can be hotplugged, if yes; perform a generic replace, or perform specific actions for hotplugging the special cases. vmconfig_apply_pending is only supposed to be called when ct isn't live. Signed-off-

[pve-devel] [PATCH v2 container 16/18] adapt config PUT method for the new update_pct_config

we don't need to extract 'delete' here, instead we pass it all as $param and extract 'delete', 'revert' and most other things in update_pct_config Signed-off-by: Oguz Bektas --- src/PVE/API2/LXC/Config.pm | 55 -- 1 file changed, 5 insertions(+), 50 deletions(

[pve-devel] [PATCH v2 container 14/18] apply pending changes during container start

Signed-off-by: Oguz Bektas --- src/PVE/LXC.pm | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index 475d9be..65c41f5 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.pm @@ -1930,6 +1930,13 @@ sub userns_command { sub vm_start { my ($vmid, $conf, $skip

[pve-devel] [PATCH v2 container 13/18] skip pending changes while taking backup

Signed-off-by: Oguz Bektas --- src/PVE/VZDump/LXC.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/src/PVE/VZDump/LXC.pm b/src/PVE/VZDump/LXC.pm index ad5ecc8..2a6449c 100644 --- a/src/PVE/VZDump/LXC.pm +++ b/src/PVE/VZDump/LXC.pm @@ -288,6 +288,7 @@ sub assemble { delete $conf->{lock}

[pve-devel] [PATCH v2 container 17/18] rework update_pct_config to write into pending section

use vmconfig_hotplug_pending or vmconfig_apply_pending to apply the pending changes, depending on whether the CT is on- or offline. Signed-off-by: Oguz Bektas --- src/PVE/LXC/Config.pm | 334 ++ 1 file changed, 106 insertions(+), 228 deletions(-) diff --g

Re: [pve-devel] [PATCH pve-zsync] Allow detecting a syncing instance of a job

On 9/30/19 12:55 PM, Fabian Ebner wrote: > Before, the check whether a syncing instance of the same job is already > present > was inside the locked section. This caused cron to continuously spawn new > instances of pve-zsync on syncs (or rather groups of syncs) taking longer > than 15 minutes, se

[pve-devel] applied: [PATCH qemu-server] qemu 4.0 : add Cascadelake-Server && KnightsMill cpu models

On 9/30/19 11:43 AM, Alexandre Derumier wrote: > Signed-off-by: Alexandre Derumier > --- > PVE/QemuServer.pm | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm > index 70ed910..8376260 100644 > --- a/PVE/QemuServer.pm > +++ b/PVE/QemuServer.pm > @@

[pve-devel] applied: [PATCH manager] ui: qemubiosedit: add gettext to efi disk hint

On 9/30/19 11:42 AM, Aaron Lauterer wrote: > Signed-off-by: Aaron Lauterer > --- > > Put the hint in one line because AFAIU our tooling cannot handle > multiline gettext calls. > applied, and yes that's the case. > www/manager6/qemu/QemuBiosEdit.js | 3 +-- > 1 file changed, 1 insertion(+), 2

[pve-devel] applied: [PATCH pve-manager] cpumodel: qemu 4.0: add Skylake-Server, Cascadelake-Server, KnightsMill

On 9/30/19 11:47 AM, Alexandre Derumier wrote: > Signed-off-by: Alexandre Derumier > --- > www/manager6/form/CPUModelSelector.js | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/www/manager6/form/CPUModelSelector.js > b/www/manager6/form/CPUModelSelector.js > index 9eb5b0e9..505d27c8

[pve-devel] applied: [PATCH v2 ha-manager 01/12] Make parameters for LRM resource commands more flexible

On 9/30/19 9:22 AM, Fabian Ebner wrote: > This will allow for new parameters beside 'target' to be used. > This is in preparation to allow for a 'timeout' parameter for a new 'stop' > command. > > Signed-off-by: Fabian Ebner > --- > src/PVE/HA/LRM.pm | 14 +++--- > 1 file changed, 7 ins

Re: [pve-devel] [PATCH v2 ha-manager 02/12] Move code updating resource config from API2::HA::Resources to HA::Config

On 9/30/19 9:22 AM, Fabian Ebner wrote: > This makes it easier to update the resource configuration from within the > CRM/LRM stack, > which is needed for the new 'stop' command. > > Signed-off-by: Fabian Ebner > --- > src/PVE/API2/HA/Resources.pm | 34 + > src/P

Re: [pve-devel] [PATCH v2 ha-manager 03/12] Add update_service_config to HA environment interface

On 9/30/19 9:22 AM, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > src/PVE/HA/Env.pm | 6 ++ > src/PVE/HA/Env/PVE2.pm | 6 ++ > src/PVE/HA/Sim/Env.pm | 6 ++ > 3 files changed, 18 insertions(+) > > diff --git a/src/PVE/HA/Env.pm b/src/PVE/HA/Env.pm > index bb37486..7

Re: [pve-devel] [PATCH v2 ha-manager 04/12] Implement update_service_config for simulation

On 9/30/19 9:22 AM, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > src/PVE/HA/Sim/Hardware.pm | 16 > 1 file changed, 16 insertions(+) > > diff --git a/src/PVE/HA/Sim/Hardware.pm b/src/PVE/HA/Sim/Hardware.pm > index 8bd5cbd..d2c0ec0 100644 > --- a/src/PVE/HA/Sim/Hardw

Re: [pve-devel] [PATCH v2 ha-manager 06/12] Use timeout for shutdown in LRM

On 9/30/19 9:22 AM, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > src/PVE/HA/LRM.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/PVE/HA/LRM.pm b/src/PVE/HA/LRM.pm > index 3b4a572..e5eee94 100644 > --- a/src/PVE/HA/LRM.pm > +++ b/src/PVE/HA/LRM.pm >

Re: [pve-devel] [PATCH v2 ha-manager 07/12] Add stop command to the API

On 9/30/19 9:22 AM, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > src/PVE/API2/HA/Resources.pm | 37 > src/PVE/CLI/ha_manager.pm| 2 ++ > 2 files changed, 39 insertions(+) besides the nit^Wfact that the commit subject should read "Add stop co

[pve-devel] applied: [PATCH v2 ha-manager 08/12] Rename target to param in simulation

On 9/30/19 9:22 AM, Fabian Ebner wrote: > In preparation to introduce a stop command with a timeout parameter. > > Signed-off-by: Fabian Ebner > --- > src/PVE/HA/Sim/Hardware.pm | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) > applied __