The reason for why we did not do this in the first place was the fact
that the "usb3" flag could be set in older qemu-server versions, we
just ignored it but not filtered it out of the config..
That means there can be VMs out there which would now become a
different HW layout, and issue for migrat
Signed-off-by: Fabian Ebner
---
src/PVE/HA/LRM.pm | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/PVE/HA/LRM.pm b/src/PVE/HA/LRM.pm
index 3b4a572..7002ddd 100644
--- a/src/PVE/HA/LRM.pm
+++ b/src/PVE/HA/LRM.pm
@@ -535,7 +535,7 @@ sub manage_resources {
my $re
Makes update_resources_config accessible via the HA environment.
Signed-off-by: Fabian Ebner
---
src/PVE/HA/Env.pm | 6 ++
src/PVE/HA/Env/PVE2.pm | 6 ++
src/PVE/HA/Sim/Env.pm | 6 ++
3 files changed, 18 insertions(+)
diff --git a/src/PVE/HA/Env.pm b/src/PVE/HA/Env.pm
index bb
This patch series introduces a new 'stop' command for ha-manager.
The command takes a timeout parameter and in case it is 0, it performs a hard
stop.
The series also includes a test for the new command.
A few changes to how parameters were handled in CRM/LRM were necessary
as well as allowing the
Signed-off-by: Fabian Ebner
---
src/PVE/HA/Manager.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/HA/Manager.pm b/src/PVE/HA/Manager.pm
index 8031ca1..3c4cf61 100644
--- a/src/PVE/HA/Manager.pm
+++ b/src/PVE/HA/Manager.pm
@@ -342,7 +342,7 @@ sub update_crm_commands
This makes it easier to update the resource configuration from within the
CRM/LRM stack,
which is needed for the new 'stop' command.
Signed-off-by: Fabian Ebner
---
src/PVE/API2/HA/Resources.pm | 31 +--
src/PVE/HA/Config.pm | 34 +
Introduces a timeout parameter for shutting a resource down.
If the parameter is 0, we perform a hard stop instead of a shutdown.
Signed-off-by: Fabian Ebner
---
src/PVE/HA/Resources.pm | 2 +-
src/PVE/HA/Resources/PVECT.pm | 14 ++
src/PVE/HA/Resources/PVEVM.pm | 16 +
Signed-off-by: Fabian Ebner
---
src/PVE/API2/HA/Resources.pm | 37
src/PVE/CLI/ha_manager.pm| 2 ++
2 files changed, 39 insertions(+)
diff --git a/src/PVE/API2/HA/Resources.pm b/src/PVE/API2/HA/Resources.pm
index 0682b57..4e7205f 100644
--- a/src/PVE/API
Signed-off-by: Fabian Ebner
---
src/test/test-stop-command1/README | 2 +
src/test/test-stop-command1/cmdlist | 8 +++
src/test/test-stop-command1/hardware_status | 5 ++
src/test/test-stop-command1/log.expect | 69 +
src/test/test-stop-command1/manage
Signed-off-by: Fabian Ebner
---
I thought that logging the timeout parameter might be useful,
since it is readily available and since it is used for
the shutdown/stop distinction.
src/PVE/HA/LRM.pm | 2 +-
src/test/test-cfs-unavailable1/log.expect | 2 +-
src/test/te
Signed-off-by: Fabian Ebner
---
The name 'target' doesn't fit with the 'stop' command,
so I wanted to change it.
I went with 'param', but suggestions are welcome.
src/PVE/HA/Sim/Hardware.pm | 26 +-
1 file changed, 17 insertions(+), 9 deletions(-)
diff --git a/src/PVE/H
This will allow for new parameters beside 'target' to be used.
This is in preparation to allow for a 'timeout' parameter for a new 'stop'
command.
Signed-off-by: Fabian Ebner
---
src/PVE/HA/LRM.pm | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/PVE/HA/LRM.
Signed-off-by: Fabian Ebner
---
src/PVE/HA/Sim/Hardware.pm | 16
1 file changed, 16 insertions(+)
diff --git a/src/PVE/HA/Sim/Hardware.pm b/src/PVE/HA/Sim/Hardware.pm
index 8bd5cbd..d2c0ec0 100644
--- a/src/PVE/HA/Sim/Hardware.pm
+++ b/src/PVE/HA/Sim/Hardware.pm
@@ -109,6 +109,2
Not every command parameter is 'target' anymore, so
it was necessary to modify the parsing of $sd->{cmd}.
Just changing the state to request_stop is not enough,
we need to actually update the service configuration as well.
Signed-off-by: Fabian Ebner
---
src/PVE/HA/Manager.pm | 27 +
Signed-off-by: Fabian Ebner
---
src/PVE/API2/HA/Resources.pm | 10 +-
src/PVE/HA/Manager.pm | 1 -
src/PVE/HA/Resources/PVEVM.pm | 1 -
3 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/src/PVE/API2/HA/Resources.pm b/src/PVE/API2/HA/Resources.pm
index 4e7205f..cf75
I tried applying your patch, but it failed. Looks like the formatting is
wrong.
Some things inline.
On 9/1/19 8:22 PM, Marlin Cremers wrote:
The current implementation of Cloud-Init uses user data to set the
hostname, username, password and SSH keys of the virtual machine.
This has affect that
This (obviously) depends on the patch series for the HA stop command.
With this the corresponding API calls to ha-manager are initiated;
previously everything resulted in "--state stopped" and therefore
a shutdown with 60 seconds timeout.
Signed-off-by: Fabian Ebner
---
PVE/API2/Qemu.pm | 5 +++-
On 9/26/19 1:38 PM, Fabian Ebner wrote:
> Signed-off-by: Fabian Ebner
> ---
> src/PVE/HA/LRM.pm | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/src/PVE/HA/LRM.pm b/src/PVE/HA/LRM.pm
> index 3b4a572..7002ddd 100644
> --- a/src/PVE/HA/LRM.pm
> +++ b/src/PVE/HA/LRM.pm
Signed-off-by: Aaron Lauterer
---
www/manager6/form/USBSelector.js | 10 --
1 file changed, 10 deletions(-)
diff --git a/www/manager6/form/USBSelector.js b/www/manager6/form/USBSelector.js
index ed35bde0..82b59722 100644
--- a/www/manager6/form/USBSelector.js
+++ b/www/manager6/form/USBS
Enable USB3 by default. There are no restrictions anymore that the speed
of the dev must match the USB3 speed. The xhci controller can deal with
USB 2 and 1 devices. USB3 devices can be plugged in a USB2 (ehci)
controller.
When using a USB device for Spice passthrough my tests showed that USB2
dev
On 9/26/19 1:38 PM, Fabian Ebner wrote:
> Signed-off-by: Fabian Ebner
> ---
>
> The name 'target' doesn't fit with the 'stop' command,
> so I wanted to change it.
> I went with 'param', but suggestions are welcome.
>
can be OK, but would be two patches (or maybe but the change to $param in
the
On 9/26/19 1:38 PM, Fabian Ebner wrote:
> Signed-off-by: Fabian Ebner
> ---
> src/PVE/HA/Manager.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/PVE/HA/Manager.pm b/src/PVE/HA/Manager.pm
> index 8031ca1..3c4cf61 100644
> --- a/src/PVE/HA/Manager.pm
> +++ b/src/PVE
On 9/26/19 1:38 PM, Fabian Ebner wrote:
> Signed-off-by: Fabian Ebner
> ---
> src/PVE/API2/HA/Resources.pm | 10 +-
> src/PVE/HA/Manager.pm | 1 -
> src/PVE/HA/Resources/PVEVM.pm | 1 -
> 3 files changed, 5 insertions(+), 7 deletions(-)
>
applied, thanks!
___
On 9/26/19 1:38 PM, Fabian Ebner wrote:
> This patch series introduces a new 'stop' command for ha-manager.
> The command takes a timeout parameter and in case it is 0, it performs a hard
> stop.
> The series also includes a test for the new command.
> A few changes to how parameters were handled
On 9/25/19 10:28 AM, Daniel Berteaud wrote:
> When working with several ZFS over iSCSI / LIO storages, we might lookup
> between them with less than 15 sec interval.
> Previously, the cache of the previous storage was used, which was breaking
> disk move for example
>
looks Ok from a quick glance
- Le 26 Sep 19, à 15:26, Thomas Lamprecht t.lampre...@proxmox.com a écrit :
> On 9/25/19 10:28 AM, Daniel Berteaud wrote:
>> When working with several ZFS over iSCSI / LIO storages, we might lookup
>> between them with less than 15 sec interval.
>> Previously, the cache of the previous storag
On 9/25/19 10:28 AM, Daniel Berteaud wrote:
> extract_volname can return an undef $volname
>
thanks for noticing, the proposed change would've worked just fine, but
I like return-early style a bit more, also saw a missed opportunity to
reuse a variable in the $extract_volname call, so I pushed ou
On 9/25/19 10:28 AM, Daniel Berteaud wrote:
> So it won't clash with another backstore in another pool
>
> Signed-off-by: Daniel Berteaud
> ---
> PVE/Storage/LunCmd/LIO.pm | 20
> 1 file changed, 20 insertions(+)
not tested but looks good to me.
>
> diff --git a/PVE/Stora
On 9/26/19 1:02 PM, Dominic Jäger wrote:
> However, now the "Clear User name" button is the only one that is left below.
> Screenshots of the current state and my proposal are attached.
>
> We could
>
> 1.
> 1.a move the user name more to the left, such that the distance is the same
> as betwee
On 9/26/19 3:03 PM, Aaron Lauterer wrote:
> Enable USB3 by default. There are no restrictions anymore that the speed
> of the dev must match the USB3 speed. The xhci controller can deal with
> USB 2 and 1 devices. USB3 devices can be plugged in a USB2 (ehci)
> controller.
>
> When using a USB devi
On 9/26/19 3:03 PM, Aaron Lauterer wrote:
> Signed-off-by: Aaron Lauterer
> ---
> www/manager6/form/USBSelector.js | 10 --
> 1 file changed, 10 deletions(-)
>
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.c
This serie fixes support of several ZFS pools exported by the same
server (through different targets) when using LIO. It fixes bug 2384
Changes since V1
* Avoid nested hash accesses
* Re-use variables
Daniel Berteaud (3):
LIO: Make the target cache works per target and portal
LIO: Prefix
So it won't clash with another backstore in another pool
Signed-off-by: Daniel Berteaud
---
PVE/Storage/LunCmd/LIO.pm | 21 +
1 file changed, 21 insertions(+)
diff --git a/PVE/Storage/LunCmd/LIO.pm b/PVE/Storage/LunCmd/LIO.pm
index 2fd3181..122c203 100644
--- a/PVE/Storage/L
Signed-off-by: Daniel Berteaud
---
PVE/Storage/LunCmd/LIO.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/PVE/Storage/LunCmd/LIO.pm b/PVE/Storage/LunCmd/LIO.pm
index 122c203..15ddabf 100644
--- a/PVE/Storage/LunCmd/LIO.pm
+++ b/PVE/Storage/LunCmd/LIO.pm
@@ -255,7 +255,7
When working with several ZFS over iSCSI / LIO storages, we might lookup
between them with less than 15 sec interval.
Previously, the cache of the previous storage was used, which was breaking
disk move for example
Signed-off-by: Daniel Berteaud
---
PVE/Storage/LunCmd/LIO.pm | 36 +++
On 9/25/19 6:12 PM, Mira Limbeck wrote:
> This removes the cloudinit disk from the list of drives to clone. As the
> cloudinit disk is recreated on every VM start, it's not necessary to
> clone it.
>
> Signed-off-by: Mira Limbeck
> ---
> PVE/API2/Qemu.pm | 4 ++--
> PVE/QemuServer.pm | 8 --
On 9/26/19 5:26 PM, Daniel Berteaud wrote:
> This serie fixes support of several ZFS pools exported by the same
> server (through different targets) when using LIO. It fixes bug 2384
>
> Changes since V1
> * Avoid nested hash accesses
> * Re-use variables
>
> Daniel Berteaud (3):
> LIO: Mak
- Le 26 Sep 19, à 18:46, Thomas Lamprecht t.lampre...@proxmox.com a écrit :
>>
>> Changes since V1
>> * Avoid nested hash accesses
>> * Re-use variables
>>
>> Daniel Berteaud (3):
>> LIO: Make the target cache works per target and portal
>> LIO: Prefix backstores with the pool name
>
On 9/26/19 6:52 PM, Daniel Berteaud wrote:
> - Le 26 Sep 19, à 18:46, Thomas Lamprecht t.lampre...@proxmox.com a écrit
> :
>
>>>
>>> Changes since V1
>>> * Avoid nested hash accesses
>>> * Re-use variables
>>>
>>> Daniel Berteaud (3):
>>> LIO: Make the target cache works per target and
- Le 26 Sep 19, à 19:02, Thomas Lamprecht t.lampre...@proxmox.com a écrit :
>>
>> Thanks to you for reviewing / merging.
>> Should I close bug #2384 now ? (not sure if you have some particular
>> workflow on
>> BZ)
>
> Hmm, as you're here not only the Reporter but effectively also the
> Ass
Hi,
I have noticed that when you upgrade libknet1 (and fix the crash of corosync),
corosync is not auto restarted.
Maybe should we bump the corosync package too to force a restart ?
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.prox
41 matches
Mail list logo
