[pve-devel] [PATCH storage 3/3] Prefix backstores with the pool name

2019-09-25 Thread Daniel Berteaud
So it won't clash with another backstore in another pool Signed-off-by: Daniel Berteaud --- PVE/Storage/LunCmd/LIO.pm | 20 1 file changed, 20 insertions(+) diff --git a/PVE/Storage/LunCmd/LIO.pm b/PVE/Storage/LunCmd/LIO.pm index 5d7a21d..80133d4 100644 --- a/PVE/Storage/Lu

[pve-devel] [PATCH storage 1/3] Make the target cache works per target and portal

2019-09-25 Thread Daniel Berteaud
When working with several ZFS over iSCSI / LIO storages, we might lookup between them with less than 15 sec interval. Previously, the cache of the previous storage was used, which was breaking disk move for example Signed-off-by: Daniel Berteaud --- PVE/Storage/LunCmd/LIO.pm | 20 ++-

[pve-devel] [PATCH storage 2/3] Ensure $volname is defined before using it

2019-09-25 Thread Daniel Berteaud
extract_volname can return an undef $volname Signed-off-by: Daniel Berteaud --- PVE/Storage/LunCmd/LIO.pm | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/PVE/Storage/LunCmd/LIO.pm b/PVE/Storage/LunCmd/LIO.pm index 5f9794d..5d7a21d 100644 --- a/PVE/Storage/LunCmd/LIO.p

[pve-devel] [PATCH storage 0/3] Fix 2384, several pools from same server

2019-09-25 Thread Daniel Berteaud
This serie fixes support of several ZFS pools exported by the same server (through different targets) when using LIO. It fixes bug 2384 Daniel Berteaud (3): Make the target cache works per target and portal Ensure $volname is defined before using it Prefix backstores with the pool name PVE

Re: [pve-devel] [PATCH container] don't duplicate lxc.idmap entries during restore

2019-09-25 Thread Fabian Grünbichler
On September 24, 2019 4:04 pm, Oguz Bektas wrote: > merging $conf->{lxc} causes lxc.idmap entries to be duplicated in the > restored configuration. instead, we can overwrite the contents from the > extracted configuration file. this way we don't duplicate these entries. > (having duplicate idmap en

[pve-devel] [PATCH v2 container] don't duplicate lxc.idmap entries during restore

2019-09-25 Thread Oguz Bektas
merging $conf->{lxc} causes lxc.idmap entries to be duplicated in the restored configuration. instead, we can overwrite the contents from the extracted configuration file. this way we don't duplicate these entries. (having duplicate idmap entries causes container to crash during start) Co-develope

[pve-devel] [PATCH manager 1/2] ui: vm/usbedit: add gettext to label

2019-09-25 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- www/manager6/qemu/USBEdit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/qemu/USBEdit.js b/www/manager6/qemu/USBEdit.js index 8cad8fc5..f41c3d21 100644 --- a/www/manager6/qemu/USBEdit.js +++ b/www/manager6/qemu/USBEdit.js @@ -

[pve-devel] [PATCH manager 2/2] ui: vm/usbedit: refactor usb3 checkbox handling

2019-09-25 Thread Aaron Lauterer
USB3 checkbox was always checked if the device / port supports USB3 even though USB3 was disabled on purpose. The behaviour now is that for an existing configuration the checkbox reflects what is set. When selecting a device or port that is not the configured one the checkbox reflects the USB3 sup

Re: [pve-devel] [PATCH v2 container] don't duplicate lxc.idmap entries during restore

2019-09-25 Thread Fabian Grünbichler
On September 25, 2019 1:30 pm, Oguz Bektas wrote: > merging $conf->{lxc} causes lxc.idmap entries to be duplicated in the > restored configuration. instead, we can overwrite the contents from the > extracted configuration file. this way we don't duplicate these entries. > (having duplicate idmap en

Re: [pve-devel] [PATCH qemu-server] fix #2382: delete cloudinit disk before restoring

2019-09-25 Thread Thomas Lamprecht
On 9/24/19 3:40 PM, Mira Limbeck wrote: > The fix introduced in commit bf4a933 did not work as intended. We're > iterating over the $oldconf, not over $virtdev_hash. This means > $drive->{is_cloudinit} is always undefined. Instead use the more costly > call to drive_is_cloudinit. would not call th

[pve-devel] [PATCH v2 qemu-server] fix #2382: delete cloudinit disk before restoring

2019-09-25 Thread Mira Limbeck
The fix introduced in commit bf4a933 did not work as intended. We're iterating over the $oldconf, not over $virtdev_hash. This means $drive->{is_cloudinit} is always undefined. Instead use the $exclude_cloudinit parameter from drive_is_cdrom(). Signed-off-by: Mira Limbeck --- v2: set $exclude_clo

[pve-devel] applied: [PATCH v2 qemu-server] fix #2382: delete cloudinit disk before restoring

2019-09-25 Thread Thomas Lamprecht
On 9/25/19 3:30 PM, Mira Limbeck wrote: > The fix introduced in commit bf4a933 did not work as intended. We're > iterating over the $oldconf, not over $virtdev_hash. This means > $drive->{is_cloudinit} is always undefined. Instead use the $exclude_cloudinit > parameter from drive_is_cdrom(). > > S

[pve-devel] applied: [PATCH qemu-server] Whitespace cleanup

2019-09-25 Thread Thomas Lamprecht
On 9/17/19 4:47 PM, Aaron Lauterer wrote: > Signed-off-by: Aaron Lauterer > --- > PVE/CLI/qmrestore.pm | 18 +- > PVE/QMPClient.pm | 38 +++--- > PVE/QemuConfig.pm| 2 +- > PVE/QemuServer/Memory.pm | 2 +- > PVE/VZDump/QemuServ

[pve-devel] [PATCH qemu-server] fix #2344: allow ':cloudinit' in drive_is_cloudinit

2019-09-25 Thread Mira Limbeck
Allow 'cloudinit' and ':cloudinit' in drive_is_cloudinit so cloudinit disks are recognized by drive_is_cdrom even if they have not been renamed to 'vm--cloudinit' yet. This fixes the check_replication sub not recognizing the cloudinit disk when regenerating the cloudinit image or adding a new cloud

Re: [pve-devel] [PATCH qemu-server] fix #2344: allow ':cloudinit' in drive_is_cloudinit

2019-09-25 Thread Thomas Lamprecht
On 9/25/19 5:35 PM, Mira Limbeck wrote: > Allow 'cloudinit' and ':cloudinit' in drive_is_cloudinit so > cloudinit disks are recognized by drive_is_cdrom even if they have not > been renamed to 'vm--cloudinit' yet. > This fixes the check_replication sub not recognizing the cloudinit disk > when rege

[pve-devel] [PATCH qemu-server] fix #2217: don't copy cloudinit disk on clone

2019-09-25 Thread Mira Limbeck
This removes the cloudinit disk from the list of drives to clone. As the cloudinit disk is recreated on every VM start, it's not necessary to clone it. Signed-off-by: Mira Limbeck --- PVE/API2/Qemu.pm | 4 ++-- PVE/QemuServer.pm | 8 2 files changed, 2 insertions(+), 10 deletions(-) d

Re: [pve-devel] [PATCH manager 2/2] ui: vm/usbedit: refactor usb3 checkbox handling

2019-09-25 Thread Thomas Lamprecht
On 9/25/19 2:30 PM, Aaron Lauterer wrote: > USB3 checkbox was always checked if the device / port supports USB3 > even though USB3 was disabled on purpose. > > The behaviour now is that for an existing configuration the checkbox > reflects what is set. When selecting a device or port that is not t

[pve-devel] applied: [PATCH manager 1/2] ui: vm/usbedit: add gettext to label

2019-09-25 Thread Thomas Lamprecht
On 9/25/19 2:30 PM, Aaron Lauterer wrote: > Signed-off-by: Aaron Lauterer > --- > www/manager6/qemu/USBEdit.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/www/manager6/qemu/USBEdit.js b/www/manager6/qemu/USBEdit.js > index 8cad8fc5..f41c3d21 100644 > --- a/www/manage