Thanks to Stefan and Thomas for the suggestions.
Changes from v1:
* update parameter description
* warn instead of die
Signed-off-by: Fabian Ebner
---
PVE/API2/Qemu.pm | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 8be0b
otherwise a user with only VM.Config.HWType cannot
delete a 'pending' usbX: spice or serial: socket option
Signed-off-by: Dominik Csapak
---
PVE/API2/Qemu.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 3355c8b..5814f94 100644
On 9/23/19 10:50 AM, Dominik Csapak wrote:
> otherwise a user with only VM.Config.HWType cannot
> delete a 'pending' usbX: spice or serial: socket option
>
> Signed-off-by: Dominik Csapak
> ---
> PVE/API2/Qemu.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/PVE/A
On 9/23/19 9:56 AM, Fabian Ebner wrote:
> Thanks to Stefan and Thomas for the suggestions.
>
> Changes from v1:
> * update parameter description
> * warn instead of die
This information is better to go a bit below, namely...
>
> Signed-off-by: Fabian Ebner
> ---
.. here, after the "---" and b
I did some short tests with the latest commits and there is the
following problem:
Adding a USB3 device or port will result in such an error msg:
Parameter verification failed. (400)
usb1: invalid format - duplicate key in comma-separated list property: usb3
The parameter sen
On 9/18/19 5:15 PM, Daniel Berteaud wrote:
> This patch serie fixes a few minor problems with ZFS over iSCSI
> in general, and in the LIO backend. It also enable unmap support.
>
> Change from V1 :
> * Fix linked clone support in ZFSPlugin instead of LIO
>
> Daniel Berteaud (3):
> Don't remov
- Le 23 Sep 19, à 16:35, Thomas Lamprecht t.lampre...@proxmox.com a écrit :
>>
>
> Thanks for your contribution!
And thanks for your review ;-)
> Changes looks OK to me, reviewed all three patches.
>
> The only thing left from allowing me to apply this would be the
> need of a signed CL
On 9/23/19 4:23 PM, Aaron Lauterer wrote:
> I did some short tests with the latest commits and there is the following
> problem:
>
> Adding a USB3 device or port will result in such an error msg:
>
> Parameter verification failed. (400)
>
> usb1: invalid format - duplicate key in comma-
On 9/23/19 4:57 PM, Daniel Berteaud wrote:
> - Le 23 Sep 19, à 16:35, Thomas Lamprecht t.lampre...@proxmox.com a écrit
> :
>> Thanks for your contribution!
>
> And thanks for your review ;-)
>
>> Changes looks OK to me, reviewed all three patches.
>>
>> The only thing left from allowing me t
On 9/10/19 2:57 PM, Dominik Csapak wrote:
> useful for vm/ct tags
a short sentence which describes the format would be appreciated..
Also, I'd like to keep format registrations here relatively minimal,
I mean they do not need to have the wide spread use all over our
projects like default options n
On 9/10/19 2:57 PM, Dominik Csapak wrote:
> this series lets users add tags to guest configs
> these do not have any concrete meaning but are intended to be used
> by management software such as config management systems
>
Looks OK, besides some comments in the common patch.
I'd like to have basi
On Mon, 23 Sep 2019 16:35:00 +0200
Thomas Lamprecht wrote:
> > PVE/Storage/ZFSPlugin.pm | 10 +-
Could this be a fix to
https://bugzilla.proxmox.com/show_bug.cgi?id=2176 ?
--
Hilsen/Regards
Michael Rasmussen
Get my public GnuPG keys:
michael rasmussen cc
https://pgp.key-server.io/pk
On 9/23/19 7:22 PM, Michael Rasmussen wrote:
> On Mon, 23 Sep 2019 16:35:00 +0200
> Thomas Lamprecht wrote:
>
>>> PVE/Storage/ZFSPlugin.pm | 10 +-
> Could this be a fix to
> https://bugzilla.proxmox.com/show_bug.cgi?id=2176 ?
>
I guess not, as this affects only the LIO sub-plugin,
and
On Tue, 24 Sep 2019 07:13:21 +0200
Thomas Lamprecht wrote:
> On 9/23/19 7:22 PM, Michael Rasmussen wrote:
> > On Mon, 23 Sep 2019 16:35:00 +0200
> > Thomas Lamprecht wrote:
> >
> >>> PVE/Storage/ZFSPlugin.pm | 10 +-
> > Could this be a fix to
> > https://bugzilla.proxmox.com/show_
On 9/24/19 7:47 AM, Michael Rasmussen wrote:
> On Tue, 24 Sep 2019 07:13:21 +0200
> Thomas Lamprecht wrote:
>
>> On 9/23/19 7:22 PM, Michael Rasmussen wrote:
>>> On Mon, 23 Sep 2019 16:35:00 +0200
>>> Thomas Lamprecht wrote:
>>>
> PVE/Storage/ZFSPlugin.pm | 10 +-
>>> Could thi
On 9/24/19 8:09 AM, Thomas Lamprecht wrote:
> On 9/24/19 7:47 AM, Michael Rasmussen wrote:
>> On Tue, 24 Sep 2019 07:13:21 +0200
>> Thomas Lamprecht wrote:
>>
>>> On 9/23/19 7:22 PM, Michael Rasmussen wrote:
On Mon, 23 Sep 2019 16:35:00 +0200
Thomas Lamprecht wrote:
>> PVE/
On 9/23/19 5:30 PM, Thomas Lamprecht wrote:
On 9/10/19 2:57 PM, Dominik Csapak wrote:
useful for vm/ct tags
a short sentence which describes the format would be appreciated..
Also, I'd like to keep format registrations here relatively minimal,
I mean they do not need to have the wide spread us
On 9/23/19 5:34 PM, Thomas Lamprecht wrote:
On 9/10/19 2:57 PM, Dominik Csapak wrote:
this series lets users add tags to guest configs
these do not have any concrete meaning but are intended to be used
by management software such as config management systems
Looks OK, besides some comments in
On 9/23/19 2:19 PM, Thomas Lamprecht wrote:
On 9/23/19 9:56 AM, Fabian Ebner wrote:
Thanks to Stefan and Thomas for the suggestions.
Changes from v1:
* update parameter description
* warn instead of die
This information is better to go a bit below, namely...
Signed-off-by: Fabian Ebner
---
19 matches
Mail list logo
