[pve-devel] [PATCH manager 2/2] Add online help to VM bios settings

2019-09-18 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- www/manager6/qemu/QemuBiosEdit.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager6/qemu/QemuBiosEdit.js b/www/manager6/qemu/QemuBiosEdit.js index a0fad159..7283df74 100644 --- a/www/manager6/qemu/QemuBiosEdit.js +++ b/www/manager6/qemu/QemuBiosEd

[pve-devel] [PATCH manager 1/2] Add online help to VM display settings

2019-09-18 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- www/manager6/qemu/DisplayEdit.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager6/qemu/DisplayEdit.js b/www/manager6/qemu/DisplayEdit.js index e5af00aa..8c54b7a7 100644 --- a/www/manager6/qemu/DisplayEdit.js +++ b/www/manager6/qemu/DisplayEdit.js

[pve-devel] [PATCH manager 0/2] Add online help links where missing

2019-09-18 Thread Aaron Lauterer
I found two spots where documentation is available but the help button was missing. Aaron Lauterer (2): Add online help to VM display settings Add online help to VM bios settings www/manager6/qemu/DisplayEdit.js | 1 + www/manager6/qemu/QemuBiosEdit.js | 1 + 2 files changed, 2 insertions(+

[pve-devel] openvswitch /etc/network/interfaces -> auto xxx need to be removed

2019-09-18 Thread Alexandre DERUMIER
Hi, user have reported problem with openvswitch here: https://forum.proxmox.com/threads/so-is-openvswitch-bonding-just-broken-on-pve-6-whats-going-on.58020/ "auto ..." should be removed , to avoid race condition with systemd. The official documentation have been updated for this, with config ex

Re: [pve-devel] [PATCH storage 3/3] Fix volume name identification with linked clones

2019-09-18 Thread Daniel Berteaud
- Le 17 Sep 19, à 12:44, Daniel Berteaud dan...@firewall-services.com a écrit : > Linked clones has an image like base-100-disk-0/vm-101-disk-0 > The previous regex didn't catched it, and thus, resizing a linked clone > failed > --- > PVE/Storage/LunCmd/LIO.pm | 2 +- > 1 file changed, 1 inse

[pve-devel] applied: [PATCH manager v2 1/4] Cleanup: align backslashes in manager6 Makefile

2019-09-18 Thread Dominik Csapak
applied, thanks ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager v2 2/4] spice: Add enhancements form component

2019-09-18 Thread Dominik Csapak
On 9/17/19 11:35 AM, Aaron Lauterer wrote: Signed-off-by: Aaron Lauterer --- www/manager6/Makefile | 1 + www/manager6/form/SpiceEnhancementSelector.js | 72 +++ 2 files changed, 73 insertions(+) create mode 100644 www/manager6/form/SpiceEnhancement

Re: [pve-devel] [PATCH manager v2 3/4] spice: Add enhanecements to VM Options panel

2019-09-18 Thread Dominik Csapak
On 9/17/19 11:35 AM, Aaron Lauterer wrote: Signed-off-by: Aaron Lauterer --- www/manager6/Utils.js| 18 ++ www/manager6/qemu/Options.js | 13 + 2 files changed, 31 insertions(+) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index 6a489e7e..a9

Re: [pve-devel] [PATCH manager v2 4/4] spice: Add enhancements to VM Creation wizard

2019-09-18 Thread Dominik Csapak
lgtm, i find it understandable that the 'spice enhancments' are disabled because spice is not selected, but maybe someone else has a comment on that? On 9/17/19 11:35 AM, Aaron Lauterer wrote: For a cleaner UI the SCSI Controller (pveScsiHwSelector) is moved to the left column below the VGA sele

Re: [pve-devel] [PATCH] Implement support for Cloud-Init vendor data

2019-09-18 Thread Mira Limbeck
Hi, Thanks for the clarification. I haven't yet had time to take a closer look. As this is your first patch please send the signed CLA[1] to off...@proxmox.com Some things inline. [1] https://pve.proxmox.com/wiki/Developer_Documentation#Software_License_and_Copyright On 9/4/19 4:29 PM, M

Re: [pve-devel] [PATCH manager v2 2/4] spice: Add enhancements form component

2019-09-18 Thread Aaron Lauterer
On 9/18/19 12:11 PM, Dominik Csapak wrote: On 9/17/19 11:35 AM, Aaron Lauterer wrote: Signed-off-by: Aaron Lauterer ---   www/manager6/Makefile |  1 +   www/manager6/form/SpiceEnhancementSelector.js | 72 +++   2 files changed, 73 insertions(+)   create

Re: [pve-devel] [PATCH manager v2 3/4] spice: Add enhanecements to VM Options panel

2019-09-18 Thread Aaron Lauterer
On 9/18/19 12:12 PM, Dominik Csapak wrote: On 9/17/19 11:35 AM, Aaron Lauterer wrote: Signed-off-by: Aaron Lauterer ---   www/manager6/Utils.js    | 18 ++   www/manager6/qemu/Options.js | 13 +   2 files changed, 31 insertions(+) diff --git a/www/manager6/Utils

[pve-devel] [PATCH widget-toolkit] Cleanup whitespace

2019-09-18 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- button/Button.js | 4 ++-- data/DiffStore.js | 4 ++-- data/reader/JsonObject.js | 14 +++--- mixin/CBind.js| 14 +++--- node/TimeView.js | 14 +++--- panel/RRDChart.js | 14 +++--- w

[pve-devel] [PATCH storage V2 0/3] Fixes in ZFS over iSCSI

2019-09-18 Thread Daniel Berteaud
This patch serie fixes a few minor problems with ZFS over iSCSI in general, and in the LIO backend. It also enable unmap support. Change from V1 : * Fix linked clone support in ZFSPlugin instead of LIO Daniel Berteaud (3): Don't remove and recreate lun when changing a volume Enable unmap su

[pve-devel] [PATCH storage V2 1/3] Don't remove and recreate lun when changing a volume

2019-09-18 Thread Daniel Berteaud
It's not needed, LIO sees the new size automatically. And it was broken anyway. Partially fix #2335 Signed-off-by: Daniel Berteaud --- PVE/Storage/LunCmd/LIO.pm | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/PVE/Storage/LunCmd/LIO.pm b/PVE/Storage/LunCmd/LIO.pm in

[pve-devel] [PATCH storage V2 3/3] Parse volname where needed

2019-09-18 Thread Daniel Berteaud
The common ZFSPlugin was missing volume name parsing in a few places. This was not a problem for standard volumes, but broke functionnalities (like resize, snapshot, rollback) with linked clones as the name of the zvol must be extracted from the entry in the config (remove base-X-disk-Y prefix) Si

[pve-devel] [PATCH storage V2 2/3] Enable unmap support

2019-09-18 Thread Daniel Berteaud
In the default config, emulate_tpu is set to 0, which disables unmap support. Once enabled, trim can run from guest to reclaim free space. Signed-off-by: Daniel Berteaud --- PVE/Storage/LunCmd/LIO.pm | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/PVE/Storage/LunCmd/LIO