[pve-devel] applied: [PATCH v2 container] fix issue where ttys aren't correctly set after restore

2019-09-17 Thread Wolfgang Bumiller
applied On Fri, Sep 13, 2019 at 12:35:57PM +0200, Oguz Bektas wrote: > restore from unpriv to priv causes a problem with the log-in from web > console, since the /etc/securetty file isn't modified after a restore to > reflect that change (/dev/lxc/tty1 and so on). > > template_fixup is normally c

[pve-devel] applied: [PATCH storage] Actually use target_volid

2019-09-17 Thread Wolfgang Bumiller
applied On Wed, Sep 11, 2019 at 11:46:19AM +0200, Fabian Ebner wrote: > Migration with --targetstorage was broken because of this. > > Signed-off-by: Fabian Ebner > --- > PVE/Storage.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/PVE/Storage.pm b/PVE/Storage.pm

Re: [pve-devel] [PATCH manager 2/4] spice: Add enhancements form component

2019-09-17 Thread Aaron Lauterer
On 9/16/19 2:44 PM, Stefan Reiter wrote: Tried my hand at a proper code review, I like the patches in general. On 9/13/19 3:16 PM, Aaron Lauterer wrote: Signed-off-by: Aaron Lauterer ---   www/manager6/Makefile |  1 +   www/manager6/form/SpiceEnhancementSelector.js |

Re: [pve-devel] [PATCH manager 3/4] spice: Add enhancements to VM Options panel

2019-09-17 Thread Aaron Lauterer
On 9/16/19 2:44 PM, Stefan Reiter wrote: On 9/13/19 3:16 PM, Aaron Lauterer wrote: Signed-off-by: Aaron Lauterer ---   www/manager6/Utils.js    | 18 ++   www/manager6/qemu/Options.js | 13 +   2 files changed, 31 insertions(+) diff --git a/www/manager6/Utils.js

Re: [pve-devel] [PATCH manager 3/4] spice: Add enhancements to VM Options panel

2019-09-17 Thread Aaron Lauterer
On 9/16/19 2:56 PM, Christian Ebner wrote: On September 16, 2019 2:44 PM Stefan Reiter wrote: +render_spice_enhancements: function(value) { + if (!value) { + return Proxmox.Utils.disabledText; + } + var props = PVE.Parser.parsePropertyString(value); +

Re: [pve-devel] [PATCH manager 4/4] spice: Add enhancements to VM Creation wizard

2019-09-17 Thread Aaron Lauterer
On 9/16/19 2:44 PM, Stefan Reiter wrote: Akin to what you mentioned on the cover, there's a connection missing between the "Graphic card" field and the SPICE ones - there is no clear indication of *why* they are disabled by default in a new VM. Maybe make it a section of some sort titled "SP

[pve-devel] [PATCH manager v2 3/4] spice: Add enhanecements to VM Options panel

2019-09-17 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- www/manager6/Utils.js| 18 ++ www/manager6/qemu/Options.js | 13 + 2 files changed, 31 insertions(+) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index 6a489e7e..a9adb382 100644 --- a/www/manager6/Utils.js +++ b/

[pve-devel] [PATCH manager v2 1/4] Cleanup: align backslashes in manager6 Makefile

2019-09-17 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- www/manager6/Makefile | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/www/manager6/Makefile b/www/manager6/Makefile index 7ee7cd40..82e25c79 100644 --- a/www/manager6/Makefile +++ b/www/manager6/Makefile @@ -14,7 +14,7 @@ JSSRC=

[pve-devel] [PATCH manager v2 2/4] spice: Add enhancements form component

2019-09-17 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- www/manager6/Makefile | 1 + www/manager6/form/SpiceEnhancementSelector.js | 72 +++ 2 files changed, 73 insertions(+) create mode 100644 www/manager6/form/SpiceEnhancementSelector.js diff --git a/www/manager6/Makefile b

[pve-devel] [PATCH manager v2 4/4] spice: Add enhancements to VM Creation wizard

2019-09-17 Thread Aaron Lauterer
For a cleaner UI the SCSI Controller (pveScsiHwSelector) is moved to the left column below the VGA selector. The new Spice enhancements components is placed in the right column and enabled if qxl/spice is selected in the VGA selector. Signed-off-by: Aaron Lauterer --- www/manager6/qemu/SystemEdi

[pve-devel] [PATCH manager v2 0/4] Fix #2041, #2272 GUI for Spice Enhancements

2019-09-17 Thread Aaron Lauterer
With the server side patches applied[0] the GUI part for this was missing. This patch series adds the two current SPICE enhancements (folder sharing, video streaming) to the Options panel of a VM and to the VM creation wizard. Updates to the documentation and links in the GUI will follow. v1 ->

[pve-devel] [PATCH storage 3/3] Fix volume name identification with linked clones

2019-09-17 Thread Daniel Berteaud
Linked clones has an image like base-100-disk-0/vm-101-disk-0 The previous regex didn't catched it, and thus, resizing a linked clone failed --- PVE/Storage/LunCmd/LIO.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/Storage/LunCmd/LIO.pm b/PVE/Storage/LunCmd/LIO.pm index

[pve-devel] [PATCH storage 0/3] Fixes for LIO backend

2019-09-17 Thread Daniel Berteaud
This patch serie fix a few minor problems with LIO backend for ZFS over iSCSI, especially with volume resizing. It also enable unmap support Daniel Berteaud (3): Don't remove and recreate lun when changing a volume Enable unmap support Fix volume name identification with linked clones PVE/

[pve-devel] [PATCH storage 1/3] Don't remove and recreate lun when changing a volume

2019-09-17 Thread Daniel Berteaud
It's not needed, LIO sees the new size automatically. And it was broken anyway. Partially fix #2335 --- PVE/Storage/LunCmd/LIO.pm | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/PVE/Storage/LunCmd/LIO.pm b/PVE/Storage/LunCmd/LIO.pm index e0fac82..1ddc02d 100644 --- a

[pve-devel] [PATCH storage 2/3] Enable unmap support

2019-09-17 Thread Daniel Berteaud
In the default config, emulate_tpu is set to 0, which disables unmap support. Once enabled, trim can run from guest to reclaim free space. --- PVE/Storage/LunCmd/LIO.pm | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/PVE/Storage/LunCmd/LIO.pm b/PVE/Storage/LunCmd/LIO.pm i

Re: [pve-devel] [PATCH storage 0/3] Fixes for LIO backend

2019-09-17 Thread Stoiko Ivanov
Hi, Thanks for the patches and the work you put into them. On a first quick glance the changes look reasonable. I'll try to take a more detailed look and do some testing in the coming 1-2 weeks and provide some feedback! Best Regards, stoiko On Tue, 17 Sep 2019 12:44:01 +0200 Daniel Berteaud

[pve-devel] [PATCH qemu-server] Whitespace cleanup

2019-09-17 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- PVE/CLI/qmrestore.pm | 18 +- PVE/QMPClient.pm | 38 +++--- PVE/QemuConfig.pm| 2 +- PVE/QemuServer/Memory.pm | 2 +- PVE/VZDump/QemuServer.pm | 2 +- 5 files changed, 31 insertions(+), 31 del