Re: [pve-devel] [PATCH v2 qemu-server] add check to resize disk if current size could not be determined

I think in the situation this problem popped up qemu-img info didn't return at all. In fact the configured timeout probably aborted execution of run_command and therefore if we would have had the warning this would have been an obvious error and easy to debug, but please correct me if I'm wrong?

Re: [pve-devel] applied-series: [PATCH storage 2/2] warn if filesize info couldn't be read due to error

> Thomas Lamprecht hat am 9. September 2019 15:41 > geschrieben: > > > On 09.09.19 12:56, Tim Marx wrote: > > This sh > > abrupt CI message ending? > haha weird, sorry for that. > > Signed-off-by: Tim Marx > > --- > > PVE/Storage/Plugin.pm | 2 ++ > > 1 file changed, 2 insertions(+) >

Re: [pve-devel] [PATCH container 1/9] add pending section to lxc config parser/writer

On September 11, 2019 2:02 pm, Thomas Lamprecht wrote: > On 11.09.19 09:39, Fabian Grünbichler wrote: >> NAK, this breaks existing configs with a snapshot called pending (which >> is an allowed snapshot name, and not such an uncommon word that we can >> confidently say that noone would be affecte

Re: [pve-devel] [PATCH storage] Actually use target_volid

On 9/11/19 1:18 PM, Thomas Lamprecht wrote: On 11.09.19 11:46, Fabian Ebner wrote: Migration with --targetstorage was broken because of this. Signed-off-by: Fabian Ebner --- PVE/Storage.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/Storage.pm b/PVE/Storage.p

[pve-devel] [PATCH storage] set filesize to undef on error during qemu-img info

Signed-off-by: Tim Marx --- PVE/Storage/Plugin.pm | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/PVE/Storage/Plugin.pm b/PVE/Storage/Plugin.pm index 39622f3..08cb260 100644 --- a/PVE/Storage/Plugin.pm +++ b/PVE/Storage/Plugin.pm @@ -738,9 +738,18 @@ sub file_size_

[pve-devel] [PATCH v3 qemu-server] add check to resize disk if current size could not be determined

This check ensures that disks aren't unintentionally shrunken, if the size is zero due to an underlying problem. --- PVE/API2/Qemu.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 3355c8b..e09a0f7 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.p

[pve-devel] [PATCH v3 container 1/2] whitespace cleanup

--- src/PVE/API2/LXC.pm | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index 9ddaf58..faec445 100644 --- a/src/PVE/API2/LXC.pm +++ b/src/PVE/API2/LXC.pm @@ -212,7 +212,7 @@ __PACKAGE__->register_method({ if ($restore

[pve-devel] [PATCH v3 container 2/2] add check to resize disk if current size could not be determined

This check ensures that disks aren't unintentionally shrunken, if the size is zero due to an underlying problem. --- src/PVE/API2/LXC.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index faec445..fbc4659 100644 --- a/src/PVE/API2/LXC.pm +++ b/sr

[pve-devel] [PATCH widget-toolkit] add qmreboot task description

Signed-off-by: Dominik Csapak --- Utils.js | 1 + 1 file changed, 1 insertion(+) diff --git a/Utils.js b/Utils.js index 533272d..aac877a 100644 --- a/Utils.js +++ b/Utils.js @@ -475,6 +475,7 @@ Ext.define('Proxmox.Utils', { utilities: { qmstop: [ 'VM', gettext('Stop') ], qmreset:

[pve-devel] [PATCH manager] gui: qemu: add reboot button

Signed-off-by: Dominik Csapak --- www/manager6/qemu/Config.js | 8 1 file changed, 8 insertions(+) diff --git a/www/manager6/qemu/Config.js b/www/manager6/qemu/Config.js index b56f3779..65b0cbbf 100644 --- a/www/manager6/qemu/Config.js +++ b/www/manager6/qemu/Config.js @@ -143,6 +143,14

[pve-devel] [PATCH ceph] build: use dgit for download target

since it has all the necessary wrapping to download and verify dscs from arbitraty repositories, without being affected by the system's APT state and configuration. Signed-off-by: Fabian Grünbichler --- Makefile | 13 +++-- upstream-key.asc | 29 + 2 f