[pve-devel] [PATCH docs] update supported browsers

2019-09-04 Thread Dominik Csapak
we do not support ie11 anymore due to some es6 features we use Signed-off-by: Dominik Csapak --- pve-system-requirements.adoc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pve-system-requirements.adoc b/pve-system-requirements.adoc index 40965db..0a4ba6c 100644 --- a/pve-

[pve-devel] [PATCH pve-docs] bgp-evpn : add route reflectors documentation

2019-09-04 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- vxlan-and-evpn.adoc | 75 + 1 file changed, 75 insertions(+) diff --git a/vxlan-and-evpn.adoc b/vxlan-and-evpn.adoc index 703329d..09babf3 100644 --- a/vxlan-and-evpn.adoc +++ b/vxlan-and-evpn.adoc @@ -1824,4 +1824

Re: [pve-devel] [PATCH qemu-server] fix #1934: add qemu fw_cfg variables via 'tags'

2019-09-04 Thread Fabian Grünbichler
On September 4, 2019 8:49 am, Dominik Csapak wrote: > On 9/2/19 2:14 PM, Fabian Grünbichler wrote: >> On August 23, 2019 2:03 pm, Dominik Csapak wrote: >>> this add the 'tags' property to vms, which has the format: >> >> why 'tags'? seems rather generic for what it does ;) > > because the request

[pve-devel] [PATCH pve-common] etc_network_interfaces : add uplink-id option

2019-09-04 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- src/PVE/INotify.pm | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm index 8b49f5a..fd54313 100644 --- a/src/PVE/INotify.pm +++ b/src/PVE/INotify.pm @@ -955,6 +955,7 @@ sub __read_et

[pve-devel] [PATCH manager] Split CPU Model Selector into visual sections

2019-09-04 Thread Stefan Reiter
Most of the code is adapted from KVComboBox, from which it inherited before, with some generic code removed. The templating code adds a header for every group transition it encounters, thus providing support for arbitrary groups (e.g. custom models in the future). Functionality is the same as bef

[pve-devel] applied: [PATCH manager v2] Close #2262: Add noVNC scale setting

2019-09-04 Thread Thomas Lamprecht
On 03.09.19 12:13, Dominic Jäger wrote: > Add a setting to choose the scale mode of the noVNC pop-up as well as > the embedded console in the content panel to "My Settings". Having both > set to local scaling was the most important use-case for the users. One > setting for both places is the simple

[pve-devel] applied: [PATCH v3 qemu-server] Fix #2041, #2272 Add Spice enhancements

2019-09-04 Thread Thomas Lamprecht
On 22.08.19 17:33, Aaron Lauterer wrote: > This adds a new config option called `spice_enhancements` with two > optional settings: > > * videostreaming > * foldersharing > > Signed-off-by: Aaron Lauterer > --- > > v2 -> v3: > > Move the video-streaming string creation out of the '-spice' strin

[pve-devel] applied-series: [PATCH v3 docs 1/5] Mention GUI for creating a cluster and adding nodes

2019-09-04 Thread Thomas Lamprecht
On 28.08.19 10:55, Stefan Reiter wrote: > Signed-off-by: Stefan Reiter > --- > > Sorry for missing 2/2 on previous patch series, had some trouble with the > mailing list not accepting my mails. > > v3: > * Changed "Add Node" section to allow better image placement > > v2: > * Changed some wordi

[pve-devel] [RFC qemu-server] rewrite description for vm_config

2019-09-04 Thread Oguz Bektas
the description doesn't match the default behaviour, which is to replace the current values with pending ones in the returned config, unless the 'current' option is passed. Signed-off-by: Oguz Bektas --- i tried to come up with a reasonable description, but sending it as RFC just in case someone

Re: [pve-devel] [PATCH] Implement support for Cloud-Init vendor data

2019-09-04 Thread Mira Limbeck
Hi, Thank you for the patch, will take a closer look as soon as possible. Three things: 1) What's your use case that 'vendor-data' is required or preferred instead of 'user-data'? 2) Did you test it with configdrive2 (on Linux and Windows)? You change it not only for nocloud, but also for c

[pve-devel] applied: [RFC PATCH common] cli: prettify tables even more

2019-09-04 Thread Thomas Lamprecht
On 21.08.19 14:33, Wolfgang Bumiller wrote: > Separate the header with a double line. > > Signed-off-by: Wolfgang Bumiller > --- > src/PVE/CLIFormatter.pm | 18 +- > 1 file changed, 17 insertions(+), 1 deletion(-) > applied, thanks!

[pve-devel] applied: [PATCH v4 apiclient] fix #2227: enable totp codes to be passed in cli

2019-09-04 Thread Thomas Lamprecht
On 16.08.19 13:51, Oguz Bektas wrote: > this patch enables to pass totp codes during cluster join if tfa has > been enabled for root@pam (or any other user actually, but having it enabled > on > root causes problems during cluster join). > > u2f support is not yet implemented. > > Co-developed-b

[pve-devel] [PATCH v2 manager] Split CPU Model Selector into visual sections

2019-09-04 Thread Stefan Reiter
Most of the code is adapted from KVComboBox, from which it inherited before, with some generic code removed. The templating code adds a header for every group transition it encounters, thus providing support for arbitrary groups (e.g. custom models in the future). Signed-off-by: Stefan Reiter --

[pve-devel] applied: [PATCH common 2/2] Cleanup to make style consistent

2019-09-04 Thread Thomas Lamprecht
On 28.08.19 11:22, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > src/PVE/SectionConfig.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/PVE/SectionConfig.pm b/src/PVE/SectionConfig.pm > index a760459..394aae6 100644 > --- a/src/PVE/SectionConfig.pm > ++

[pve-devel] applied: [PATCH common 1/2] Fix 2339: Handle multiple blank lines correctly

2019-09-04 Thread Thomas Lamprecht
On 28.08.19 11:22, Fabian Ebner wrote: > It turns out that the line number counting was also broken (even on files > without multiple blanks), since the body of the while inside the nextline > subroutine would not be executed for a blank. > I guess the subroutine was intended to skip comments and

[pve-devel] applied: [PATCH v3 qemu 5/7] Newline cleanup

2019-09-04 Thread Thomas Lamprecht
On 01.07.19 15:43, Christian Ebner wrote: > Signed-off-by: Christian Ebner > --- > PVE/API2/Qemu.pm | 9 - > 1 file changed, 9 deletions(-) > applied, thanks! ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bi

[pve-devel] applied: [PATCH v3 container 3/7] Newline cleanups

2019-09-04 Thread Thomas Lamprecht
On 01.07.19 15:43, Christian Ebner wrote: > Signed-off-by: Christian Ebner > --- > src/PVE/API2/LXC.pm | 4 > 1 file changed, 4 deletions(-) > applied, thanks! ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/

Re: [pve-devel] [PATCH] Implement support for Cloud-Init vendor data

2019-09-04 Thread Marlin Cremers
Op wo 4 sep. 2019 om 15:59 schreef Mira Limbeck : > > Hi, > > Thank you for the patch, will take a closer look as soon as possible. > > Three things: > > 1) What's your use case that 'vendor-data' is required or preferred > instead of 'user-data'? Vendor data is configuration information that is

[pve-devel] applied: [PATCH v3 guest-common 2/2] fix #1291: implement remove_vmid_jobs for ReplicationConfig

2019-09-04 Thread Thomas Lamprecht
On 01.07.19 15:43, Christian Ebner wrote: > Allows to remove replication jobs from the config based on the vmid. > > Signed-off-by: Christian Ebner > --- > PVE/ReplicationConfig.pm | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/PVE/ReplicationConfig.pm b/PVE/Replicatio

Re: [pve-devel] [PATCH v3 guest-common 1/2] fix #1291: implement remove_vmid_from_backup_jobs

2019-09-04 Thread Thomas Lamprecht
On 01.07.19 15:43, Christian Ebner wrote: > remove_vmid_from_backup_jobs updates the vzdump.cron backup jobs, > excluding the given vmid. > > Signed-off-by: Christian Ebner > --- > PVE/VZDump/Plugin.pm | 46 > 1 file changed, 46 insertions(+) > > dif

[pve-devel] applied: [PATCH ifupdown2] add patch to add arp-accept option

2019-09-04 Thread Thomas Lamprecht
On 03.09.19 10:07, Alexandre Derumier wrote: > needed for bgp-evpn > > upstream pull request: > https://github.com/CumulusNetworks/ifupdown2/pull/121 > > Signed-off-by: Alexandre Derumier > --- > .../pve/0009-add-arp-accept-option.patch | 55 +++ > debian/patches/series

[pve-devel] applied: [PATCH pve-docs] bgp-evpn : add route reflectors documentation

2019-09-04 Thread Thomas Lamprecht
On 04.09.19 09:02, Alexandre Derumier wrote: > Signed-off-by: Alexandre Derumier > --- > vxlan-and-evpn.adoc | 75 + > 1 file changed, 75 insertions(+) > > diff --git a/vxlan-and-evpn.adoc b/vxlan-and-evpn.adoc > index 703329d..09babf3 100644 > --- a/v

Re: [pve-devel] applied: [PATCH pve-docs] bgp-evpn : add route reflectors documentation

2019-09-04 Thread Alexandre DERUMIER
Thanks thomas, and sorry for the trailing whitespaces :/ - Mail original - De: "Thomas Lamprecht" À: "pve-devel" , "aderumier" Envoyé: Mercredi 4 Septembre 2019 17:01:11 Objet: applied: [pve-devel] [PATCH pve-docs] bgp-evpn : add route reflectors documentation On 04.09.19 09:02, Alexan

Re: [pve-devel] applied: [PATCH pve-docs] bgp-evpn : add route reflectors documentation

2019-09-04 Thread Thomas Lamprecht
On 04.09.19 17:02, Alexandre DERUMIER wrote: > Thanks thomas, and sorry for the trailing whitespaces :/ no worries, `sed -i 's/\s\+$//' vxlan-and-evpn.adoc` wasn't really much work :-) > > - Mail original - > De: "Thomas Lamprecht" > À: "pve-devel" , "aderumier" > Envoyé: Mercredi 4 S

[pve-devel] applied: [PATCH pve-network] don't regenerate frr config if no router is defined

2019-09-04 Thread Thomas Lamprecht
On 04.09.19 07:49, Alexandre Derumier wrote: > Signed-off-by: Alexandre Derumier > --- > PVE/Network/SDN.pm | 2 ++ > test/generateconfig.pl | 8 +--- > 2 files changed, 7 insertions(+), 3 deletions(-) > applied, thanks! ___ pve-devel mailing

[pve-devel] [PATCH 0/2] code refactoring for lxc pending changes feature

2019-09-04 Thread Oguz Bektas
this patch series moves some pending changes related functions into AbstractConfig. the only thing that changes is that these are now class methods, since they need to be inherited in LXC::Config and QemuConfig. (the functionality in Qemu side should stay the same) for now, vmconfig_apply_pending

[pve-devel] [PATCH guest-common 1/2] move pending changes related functions into AbstractConfig

2019-09-04 Thread Oguz Bektas
some functions from Qemu w.r.t. pending changes can be moved to AbstractConfig, in order to make them available for both QemuConfig and LXC::Config. Signed-off-by: Oguz Bektas --- PVE/AbstractConfig.pm | 79 +++ 1 file changed, 79 insertions(+) diff --git

[pve-devel] [PATCH qemu-server 2/2] move pending changes related functions from QemuServer to QemuConfig

2019-09-04 Thread Oguz Bektas
we now inherit these from AbstractConfig, so they need to be defined/overwritten in QemuConfig instead of QemuServer. Signed-off-by: Oguz Bektas --- this patch requires my previous patch from pve-guest-common. everything should work the same as before when both patches are applied. PVE/API2/Q

Re: [pve-devel] applied: [RFC PATCH common] cli: prettify tables even more

2019-09-04 Thread Dietmar Maurer
What about my doubts? AFAIK nobody answered my mail? (or maybe i missed a mail) > On 4 September 2019 16:06 Thomas Lamprecht wrote: > > > On 21.08.19 14:33, Wolfgang Bumiller wrote: > > Separate the header with a double line. > > > > Signed-off-by: Wolfgang Bumiller > > --- > > src/PVE/CLIF

[pve-devel] [PATCH pve-docs] bgp-evpn : use ip-forward options on vnet interfaces

2019-09-04 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- vxlan-and-evpn.adoc | 92 +++-- 1 file changed, 72 insertions(+), 20 deletions(-) diff --git a/vxlan-and-evpn.adoc b/vxlan-and-evpn.adoc index 09babf3..f4465d6 100644 --- a/vxlan-and-evpn.adoc +++ b/vxlan-and-evpn.adoc

Re: [pve-devel] applied: [RFC PATCH common] cli: prettify tables even more

2019-09-04 Thread Thomas Lamprecht
On 04.09.19 19:36, Dietmar Maurer wrote: > What about my doubts? AFAIK nobody answered my mail? (or maybe i missed a > mail) > Wolfgang did answer: > On Wed, Aug 21, 2019 at 09:35:56PM +0200, Dietmar Maurer wrote: >> Are your sure common terminals support those characters? >> >> They did not wh

Re: [pve-devel] applied: [RFC PATCH common] cli: prettify tables even more

2019-09-04 Thread Dietmar Maurer
ok, sorry for the noise ... > On 5 September 2019 07:08 Thomas Lamprecht wrote: > > > On 04.09.19 19:36, Dietmar Maurer wrote: > > What about my doubts? AFAIK nobody answered my mail? (or maybe i missed a > > mail) > > > > Wolfgang did answer: > > > On Wed, Aug 21, 2019 at 09:35:56PM +0200