Re: [pve-devel] [PATCH manager] pve5to6: Add warning for some Gluster versions

2019-09-02 Thread Fabian Grünbichler
On August 28, 2019 1:25 pm, Dominic Jäger wrote: > After Fabian had sent his patch [0] we actually thought that this patch > for pve5to6 would be obsolete. Upgrades as well as fresh installs worked > flawlessly in my tests. Consequently, I removed the hint from the > upgrade documentation [1] an

Re: [pve-devel] applied: [RFC container] mountpoints: create parent dirs with correct owner

2019-09-02 Thread Fabian Grünbichler
On August 26, 2019 1:30 pm, Thomas Lamprecht wrote: > On 24.07.19 13:37, Fabian Grünbichler wrote: >> otherwise unprivileged containers might end up with directories that >> they cannot modify since they are owned by the user root in the host >> namespace, instead of root inside the container. >>

[pve-devel] applied: [PATCH cluster] pmxcfs: dcdb: fix returned pointer value:

2019-09-02 Thread Thomas Lamprecht
On 9/2/19 10:47 AM, Wolfgang Bumiller wrote: > Commit 926f961f62f5 used a new temporary pointer variable > for type correctness, but the return value was still using > the previous variable which had not been moved forward > anymore. > > Fixes: 926f961f62f5 ("pmxcfs dcdb: fix pointer void* aritmet

[pve-devel] [PATCH pve-docs 09/12] Fix typo in pvesr.adoc

2019-09-02 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- pvesr.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pvesr.adoc b/pvesr.adoc index 2bcc4d9..83ab268 100644 --- a/pvesr.adoc +++ b/pvesr.adoc @@ -214,7 +214,7 @@ to Node B manually. WARNING: If expected votes are set avoid changes which

[pve-devel] [PATCH pve-docs 10/12] Fix typos in pveum.adoc

2019-09-02 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- pveum.adoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pveum.adoc b/pveum.adoc index 77f7aec..37347e6 100644 --- a/pveum.adoc +++ b/pveum.adoc @@ -442,7 +442,7 @@ Each(`and`) or any(`or`) further element in the current list has to be

[pve-devel] [PATCH pve-docs 02/12] Fix typos in local-zfs.adoc

2019-09-02 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- local-zfs.adoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/local-zfs.adoc b/local-zfs.adoc index af330e1..b4fb7db 100644 --- a/local-zfs.adoc +++ b/local-zfs.adoc @@ -236,7 +236,7 @@ As `` it is possible to use more devices, like it's

[pve-devel] [PATCH pve-docs 05/12] Fix typos in pve-gui.adoc

2019-09-02 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- pve-gui.adoc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pve-gui.adoc b/pve-gui.adoc index 2d1cd28..0a84a01 100644 --- a/pve-gui.adoc +++ b/pve-gui.adoc @@ -60,7 +60,7 @@ When you connect to the server, you will first see the login wind

[pve-devel] [PATCH pve-docs 03/12] Fix typo in output-format.adoc

2019-09-02 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- output-format.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/output-format.adoc b/output-format.adoc index 03c1253..3dcfa38 100644 --- a/output-format.adoc +++ b/output-format.adoc @@ -8,7 +8,7 @@ FORMAT_OPTIONS endif::manvolnum[] It i

[pve-devel] [PATCH pve-docs 06/12] Fix typos in pveceph.adoc

2019-09-02 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- pveceph.adoc | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/pveceph.adoc b/pveceph.adoc index 72210f3..ebf9ef7 100644 --- a/pveceph.adoc +++ b/pveceph.adoc @@ -243,7 +243,7 @@ The Ceph Monitor (MON) footnote:[Ceph Monitor http

[pve-devel] [PATCH pve-docs 12/12] Fix typos in vzdump.adoc

2019-09-02 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- vzdump.adoc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/vzdump.adoc b/vzdump.adoc index fb1ac3d..e990982 100644 --- a/vzdump.adoc +++ b/vzdump.adoc @@ -78,7 +78,7 @@ consistency, the use of the `snapshot` mode is recommended instead. `

[pve-devel] [PATCH pve-docs 08/12] Fix typos in pvesm.adoc

2019-09-02 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- pvesm.adoc | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/pvesm.adoc b/pvesm.adoc index 5300f50..c2be9fe 100644 --- a/pvesm.adoc +++ b/pvesm.adoc @@ -40,7 +40,7 @@ copy VM image data, so live migration is very fast in that case.

[pve-devel] [PATCH pve-docs 11/12] Fix typos in system-booting.adoc

2019-09-02 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- system-booting.adoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/system-booting.adoc b/system-booting.adoc index 8400a26..d3d7813 100644 --- a/system-booting.adoc +++ b/system-booting.adoc @@ -120,7 +120,7 @@ initrd /EFI/proxmox/5.0.1

[pve-devel] [PATCH pve-docs 04/12] Fix typo in pct.adoc

2019-09-02 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- pct.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pct.adoc b/pct.adoc index 2cb4bbe..2f1d329 100644 --- a/pct.adoc +++ b/pct.adoc @@ -739,7 +739,7 @@ If you have a cluster, you can migrate your Containers with This works as long as you

[pve-devel] [PATCH pve-docs 01/12] Fix typos in ha-manager.adoc

2019-09-02 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- ha-manager.adoc | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/ha-manager.adoc b/ha-manager.adoc index 00a96e9..284e5fb 100644 --- a/ha-manager.adoc +++ b/ha-manager.adoc @@ -100,7 +100,7 @@ carefully calculate the benefits, and comp

[pve-devel] [PATCH pve-docs 07/12] Fix typos in pvecm.adoc

2019-09-02 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- pvecm.adoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pvecm.adoc b/pvecm.adoc index e986a75..0c7e14c 100644 --- a/pvecm.adoc +++ b/pvecm.adoc @@ -40,7 +40,7 @@ Grouping nodes into a cluster has the following advantages: * Centraliz

Re: [pve-devel] [PATCH pve-docs 08/12] Fix typos in pvesm.adoc

2019-09-02 Thread Stefan Reiter
Looked through the patches, nice job catching all those. One thing inline. On 9/2/19 11:19 AM, Fabian Ebner wrote: Signed-off-by: Fabian Ebner --- pvesm.adoc | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/pvesm.adoc b/pvesm.adoc index 5300f50..c2be9fe 1006

Re: [pve-devel] [PATCH arch-pacman] updated to 5.1.3-1

2019-09-02 Thread Thomas Lamprecht
On 8/30/19 5:36 PM, Oguz Bektas wrote: > Signed-off-by: Oguz Bektas > --- > Makefile | 2 +- > debian/changelog | 6 ++ > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index 014851c..b58177c 100644 > --- a/Makefile > +++ b/Makefile > @@ -1,5 +

Re: [pve-devel] [PATCH pve-docs 12/12] Fix typos in vzdump.adoc

2019-09-02 Thread Stefan Reiter
On 9/2/19 11:20 AM, Fabian Ebner wrote: Signed-off-by: Fabian Ebner --- vzdump.adoc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/vzdump.adoc b/vzdump.adoc index fb1ac3d..e990982 100644 --- a/vzdump.adoc +++ b/vzdump.adoc @@ -78,7 +78,7 @@ consistency, the use of the

[pve-devel] applied: [PATCH pve-docs 02/12] Fix typos in local-zfs.adoc

2019-09-02 Thread Thomas Lamprecht
On 9/2/19 11:19 AM, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > local-zfs.adoc | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/local-zfs.adoc b/local-zfs.adoc > index af330e1..b4fb7db 100644 > --- a/local-zfs.adoc > +++ b/local-zfs.adoc > @@ -236,7 +2

[pve-devel] applied: [PATCH pve-docs 01/12] Fix typos in ha-manager.adoc

2019-09-02 Thread Thomas Lamprecht
On 9/2/19 11:19 AM, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > ha-manager.adoc | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > applied, thanks! ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxm

[pve-devel] applied: [PATCH pve-docs 03/12] Fix typo in output-format.adoc

2019-09-02 Thread Thomas Lamprecht
On 9/2/19 11:19 AM, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > output-format.adoc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/output-format.adoc b/output-format.adoc > index 03c1253..3dcfa38 100644 > --- a/output-format.adoc > +++ b/output-format.adoc

[pve-devel] applied: [PATCH pve-docs 04/12] Fix typo in pct.adoc

2019-09-02 Thread Thomas Lamprecht
On 9/2/19 11:19 AM, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > pct.adoc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/pct.adoc b/pct.adoc > index 2cb4bbe..2f1d329 100644 > --- a/pct.adoc > +++ b/pct.adoc > @@ -739,7 +739,7 @@ If you have a cluster, you c

Re: [pve-devel] [PATCH manager] pve5to6: Add warning for some Gluster versions

2019-09-02 Thread Dominic Jäger
I tested this On 9/2/19 10:06 AM, Fabian Grünbichler wrote: > the end result is that you need to (...) do the upgrade with > > -o Dpkg::Options::="--force-overwrite" > > added to the apt upgrade command and added it to the the PVE 5 to 6 upgrade guide [0]. Thank you, Fabian! [0] https://pve.

[pve-devel] applied: [PATCH pve-docs 05/12] Fix typos in pve-gui.adoc

2019-09-02 Thread Thomas Lamprecht
On 9/2/19 11:19 AM, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > pve-gui.adoc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > applied, thanks! ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi

[pve-devel] applied: [PATCH pve-docs 06/12] Fix typos in pveceph.adoc

2019-09-02 Thread Thomas Lamprecht
On 9/2/19 11:19 AM, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > pveceph.adoc | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > applied, thanks! ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.pr

[pve-devel] applied: [PATCH pve-docs 07/12] Fix typos in pvecm.adoc

2019-09-02 Thread Thomas Lamprecht
On 9/2/19 11:19 AM, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > pvecm.adoc | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > applied, thanks! ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi

[pve-devel] applied: [PATCH pve-docs 08/12] Fix typos in pvesm.adoc

2019-09-02 Thread Thomas Lamprecht
On 9/2/19 11:19 AM, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > pvesm.adoc | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > applied, with a followup for Stefans improved suggestion, thanks to both! ___ pve-devel

[pve-devel] applied: [PATCH pve-docs 09/12] Fix typo in pvesr.adoc

2019-09-02 Thread Thomas Lamprecht
On 9/2/19 11:19 AM, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > pvesr.adoc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/pvesr.adoc b/pvesr.adoc > index 2bcc4d9..83ab268 100644 > --- a/pvesr.adoc > +++ b/pvesr.adoc > @@ -214,7 +214,7 @@ to Node B manually

[pve-devel] applied: [PATCH pve-docs 10/12] Fix typos in pveum.adoc

2019-09-02 Thread Thomas Lamprecht
On 9/2/19 11:19 AM, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > pveum.adoc | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > applied, thanks! ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi

[pve-devel] applied: [PATCH pve-docs 11/12] Fix typos in system-booting.adoc

2019-09-02 Thread Thomas Lamprecht
On 9/2/19 11:20 AM, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > system-booting.adoc | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) applied, thanks! ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.

[pve-devel] applied: [PATCH pve-docs 12/12] Fix typos in vzdump.adoc

2019-09-02 Thread Thomas Lamprecht
On 9/2/19 11:20 AM, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > vzdump.adoc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > applied, with a follow up to replace the "Proxmox VE" instances with our "{pve}" template, as Stefan suggested. There where two other uses of t

[pve-devel] [PATCH manager] Add support for up to 10 PCI devices

2019-09-02 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- www/manager6/qemu/HardwareView.js | 4 ++-- www/manager6/qemu/PCIEdit.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js index 606c66e5..28384d37 100644 --- a/www/m

[pve-devel] [PATCH qemu-server 0/1 pve-manager 0/1] Fix #2347 Support 10 PCI(e) devices

2019-09-02 Thread Aaron Lauterer
This patch series adds support for up to 10 PCI(e) devices. I tried to not spread out the needed pci addresses. A few things regarding the file `pve-q35-4.0.cfg`: * Some consideration and feedback is probably needed for `ich9-pcie-port-{9,10}` and their `addr` field. * Adding the PCI root por

[pve-devel] [PATCH qemu-server 1/1] Add support for up to 10 PCI(e) devices

2019-09-02 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- PVE/QemuServer.pm | 2 +- PVE/QemuServer/PCI.pm | 18 + pve-q35-4.0.cfg | 60 +++ 3 files changed, 79 insertions(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 6e3b19e..45

Re: [pve-devel] [RFC PATCH http-server 1/1] allow ticket in auth header as fallback

2019-09-02 Thread Thomas Lamprecht
It would be great to have a better commit message, or better said: one at all. You cover-letter looks like it could be a good fit for that here, almost as-is. On 8/30/19 2:12 PM, Tim Marx wrote: > Signed-off-by: Tim Marx > --- > PVE/APIServer/AnyEvent.pm | 5 + > PVE/APIServer/Formatter.pm

[pve-devel] applied: [PATCH v2 pve-docs] update vxlan-evpn doc

2019-09-02 Thread Thomas Lamprecht
On 8/30/19 10:35 AM, Alexandre Derumier wrote: > Now that vrf leaking is supported with default vrf, > setup is more simple for exit node. (not need extra interface) > > Also cleanup symmetric config > > Signed-off-by: Alexandre Derumier > --- > vxlan-and-evpn.adoc | 231 ---

Re: [pve-devel] [PATCH qemu-server 1/2] Add USB3 support to Spice USB redirection

2019-09-02 Thread Thomas Lamprecht
On 8/30/19 9:40 AM, Aaron Lauterer wrote: > Signed-off-by: Aaron Lauterer > --- > PVE/QemuServer/USB.pm | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/PVE/QemuServer/USB.pm b/PVE/QemuServer/USB.pm > index a2097b9..05c78cf 100644 > --- a/PVE/QemuServer/USB.pm > ++

Re: [pve-devel] [PATCH qemu-server 2/2] Fix local resources check for USB3 Spice devices

2019-09-02 Thread Thomas Lamprecht
On 8/30/19 9:40 AM, Aaron Lauterer wrote: > The check relied on the fact, that spice usb devices could not be usb3 > in the past. and then what...? Maybe add: > and thus the exact match for "spice" was enough. Albeit that's wrong too, any user could set the usb3 just fine, we did not throw an e

Re: [pve-devel] [RFC PATCH http-server 1/1] allow ticket in auth header as fallback

2019-09-02 Thread Tim Marx
> Thomas Lamprecht hat am 2. September 2019 13:31 > geschrieben: > > > It would be great to have a better commit message, or better said: > one at all. You cover-letter looks like it could be a good fit for > that here, almost as-is. > I expected this to get some feedback as it is RFC, the

Re: [pve-devel] [PATCH qemu-server] fix #1934: add qemu fw_cfg variables via 'tags'

2019-09-02 Thread Fabian Grünbichler
On August 23, 2019 2:03 pm, Dominik Csapak wrote: > this add the 'tags' property to vms, which has the format: why 'tags'? seems rather generic for what it does ;) > > key=value(;key=value)* > > each value will be set as > > -fw_cfg 'name=opt/com.proxmox/$key,string=$value' > (qemu recommends

Re: [pve-devel] [PATCH qemu-server] fix #1934: add qemu fw_cfg variables via 'tags'

2019-09-02 Thread Thomas Lamprecht
On 9/2/19 2:14 PM, Fabian Grünbichler wrote: > On August 23, 2019 2:03 pm, Dominik Csapak wrote: >> this add the 'tags' property to vms, which has the format: > > why 'tags'? seems rather generic for what it does ;) Second, tags is a NAK from me. Maybe just "fw_cfg" (or a variation), the Webinte

Re: [pve-devel] [PATCH qemu-server 1/2] Add USB3 support to Spice USB redirection

2019-09-02 Thread Aaron Lauterer
On 9/2/19 1:57 PM, Thomas Lamprecht wrote: On 8/30/19 9:40 AM, Aaron Lauterer wrote: Signed-off-by: Aaron Lauterer --- PVE/QemuServer/USB.pm | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/PVE/QemuServer/USB.pm b/PVE/QemuServer/USB.pm index a2097b9..05c78cf 1006

Re: [pve-devel] Gitlab-ci

2019-09-02 Thread Fabian Grünbichler
On August 27, 2019 11:24 am, Alexandre DERUMIER wrote: > Hi, > > I think 1 benefit of gitlab,github,... is the tracking of merge request. IMHO this is a big downside of Github and Gitlab - cleanly checking out an older iteration of a PR/MR is very cumbersome (and wasn't even really possible for

Re: [pve-devel] [RFC PATCH http-server 1/1] allow ticket in auth header as fallback

2019-09-02 Thread Thomas Lamprecht
On 9/2/19 2:15 PM, Tim Marx wrote: > >> Thomas Lamprecht hat am 2. September 2019 13:31 >> geschrieben: >> >> >> It would be great to have a better commit message, or better said: >> one at all. You cover-letter looks like it could be a good fit for >> that here, almost as-is. >> > > I expect

Re: [pve-devel] Gitlab-ci

2019-09-02 Thread Thomas Lamprecht
On 9/2/19 2:33 PM, Fabian Grünbichler wrote: >> I'm curious, do you use some kind of email scripts, special email client, to >> manage current workflow ? >> (Sometime I'm lost myself with my patches ;) > most of the actively reviewing people use either (neo)mutt or some > variant of notmuch, but

Re: [pve-devel] [PATCH qemu-server] fix #1934: add qemu fw_cfg variables via 'tags'

2019-09-02 Thread Fabian Grünbichler
On September 2, 2019 2:27 pm, Thomas Lamprecht wrote: > On 9/2/19 2:14 PM, Fabian Grünbichler wrote: >> On August 23, 2019 2:03 pm, Dominik Csapak wrote: >>> this add the 'tags' property to vms, which has the format: >> >> why 'tags'? seems rather generic for what it does ;) > > Second, tags is a

Re: [pve-devel] [PATCH manager] Add USB3 support for Spice USB redirection

2019-09-02 Thread Thomas Lamprecht
maybe add a note that you just copied this from another part of the code.. On 8/30/19 9:40 AM, Aaron Lauterer wrote: > Signed-off-by: Aaron Lauterer > --- > www/manager6/qemu/USBEdit.js | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/www/manager6/qemu/USBEdit.js

[pve-devel] [PATCH storage] Fix #2346: rbd: storage shows wrong %-usage

2019-09-02 Thread Alwin Antreich
The patch uses the value from the new field 'stored' if it is available. In Ceph 14.2.2 the storage calculation changed to a per pool basis. This introduced an additional field 'stored' that holds the amount of data that has been written to the pool. While the field 'used' now has the data after r

Re: [pve-devel] [PATCH qemu-server 1/2] Add USB3 support to Spice USB redirection

2019-09-02 Thread Thomas Lamprecht
On 9/2/19 2:29 PM, Aaron Lauterer wrote: > > > On 9/2/19 1:57 PM, Thomas Lamprecht wrote: >> On 8/30/19 9:40 AM, Aaron Lauterer wrote: >>> Signed-off-by: Aaron Lauterer >>> --- >>>   PVE/QemuServer/USB.pm | 7 +-- >>>   1 file changed, 5 insertions(+), 2 deletions(-) >>> >>> diff --git a/PVE/

Re: [pve-devel] [PATCH storage] Fix #2346: rbd: storage shows wrong %-usage

2019-09-02 Thread Thomas Lamprecht
On 9/2/19 3:49 PM, Alwin Antreich wrote: > The patch uses the value from the new field 'stored' if it is available. > > In Ceph 14.2.2 the storage calculation changed to a per pool basis. This > introduced an additional field 'stored' that holds the amount of data > that has been written to the po

[pve-devel] [PATCH qemu-server 3/7] Add QEMU CPU flag querying helpers

2019-09-02 Thread Stefan Reiter
* query_understood_cpu_flags returns all flags that QEMU/KVM knows about * query_supported_cpu_flags returns all flags that QEMU/KVM can use on this particular host. To get supported flags, a temporary VM is started with QEMU, so we can issue the "query-cpu-model-expansion" QMP command. This is

[pve-devel] [PATCH 0/7] Add basics for custom CPU models

2019-09-02 Thread Stefan Reiter
Based on the RFC and following on- and off-list discussion about custom CPU models [0]. In essence, this revised patch allows a user to specify custom CPU models in /etc/pve/cpu-models.conf (section-config style [1]), where VMs using that CPU model inherit details from the definition. This removes

[pve-devel] [PATCH qemu 1/7] Trigger pve-api-updates on update

2019-09-02 Thread Stefan Reiter
A QEMU update can change supported CPU flags, thus we need to restart API services (especially pvestatd) to refresh their cached values. Signed-off-by: Stefan Reiter --- debian/triggers | 1 + 1 file changed, 1 insertion(+) create mode 100644 debian/triggers diff --git a/debian/triggers b/debi

[pve-devel] [PATCH qemu-server 7/7] Allow custom CPU types in API

2019-09-02 Thread Stefan Reiter
Custom CPU types can be specified via the API, but to prevent arbitrary ones we have to manually check if the given model exists (as default or custom). Signed-off-by: Stefan Reiter --- PVE/QemuServer.pm | 31 +-- 1 file changed, 29 insertions(+), 2 deletions(-) diff

[pve-devel] [PATCH manager 2/7] Broadcast supported CPU flags

2019-09-02 Thread Stefan Reiter
pvestatd will read supported CPU flags once on startup (since these never change during runtime, and QEMU updates trigger a service restart), then broadcasts them as a key-value pair to the cluster. Signed-off-by: Stefan Reiter --- Changes from RFC: * Cache joined value * Add eval around QEMU q

[pve-devel] [PATCH qemu-server 6/7] Handle CPU flags defined in custom CPU type

2019-09-02 Thread Stefan Reiter
Special care is taken not to overwrite any special flags, or ones manually set on the VM by the user. We warn if a flag is overruled. Signed-off-by: Stefan Reiter --- PVE/QemuServer.pm | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/PVE/QemuServer.p

[pve-devel] [PATCH qemu-server 5/7] Support custom CPU types in get_cpu_options

2019-09-02 Thread Stefan Reiter
Supports custom basemodels (model shown to QEMU, i.e. must be a default model), vendors and (host-)phys-bits for VMs with large amounts of RAM (see bug #2318). Signed-off-by: Stefan Reiter --- PVE/QemuServer.pm | 32 +++- 1 file changed, 31 insertions(+), 1 deletion(-

[pve-devel] [PATCH qemu-server 4/7] Add CustomCPUConfig for storing/parsing custom CPU models

2019-09-02 Thread Stefan Reiter
Inherits from SectionConfig to provide base parsing infrastructure. Use with helper functions: * config_from_file gives bless'd config * get_model_by_name returns a "formatted" hash for a single CPU model * config_to_file writes changes back File reads are cached in a local hash. Signed-off-by:

[pve-devel] applied-series: [PATCH v2 pve-network 00/13] pve-network improvements

2019-09-02 Thread Thomas Lamprecht
Hi, On 29.08.19 12:32, Alexandre Derumier wrote: > pve-network is now able to generate bgp evpn configuration, > so we have a true anycast routable vxlan sdn now :) great! > > It's still missing configuration for outside gateway, > but 2vms in 2differents vnet/subnet should be already able to c