[pve-devel] [PATCH i18n] Add comment about make update

2019-08-29 Thread Dominic Jäger
Signed-off-by: Dominic Jäger --- I did not know that we have to run 'make update' when adding a new language to i18n and have overseen a lot of errors as a consequence [0]. We might want to give (new) developers a hint at some place so that something like this does not happen anymore. The patch is

Re: [pve-devel] [PATCH docs] pve-network: add short section explaining Open vSwitch

2019-08-29 Thread Christian Ebner
Okay, I can do that. Will dig a little bit deeper into Linux bridges and their current capabilities as well as OVS. Thx for your feedback! > On August 28, 2019 10:32 AM Thomas Lamprecht wrote: > > > On 28.08.19 10:10, Aaron Lauterer wrote: > > > > > > On 8/28/19 9:42 AM, Thomas Lamprecht w

Re: [pve-devel] [PATCH i18n] Add comment about make update

2019-08-29 Thread Stefan Reiter
On 8/29/19 10:06 AM, Dominic Jäger wrote: Signed-off-by: Dominic Jäger --- I did not know that we have to run 'make update' when adding a new language to i18n and have overseen a lot of errors as a consequence [0]. We might want to give (new) developers a hint at some place so that something lik

[pve-devel] [PATCH v2 pve-network 00/13] pve-network improvements

2019-08-29 Thread Alexandre Derumier
Hi, pve-network is now able to generate bgp evpn configuration, so we have a true anycast routable vxlan sdn now :) It's still missing configuration for outside gateway, but 2vms in 2differents vnet/subnet should be already able to communicate. Frr6 from debian buster official repo seem to be bu

[pve-devel] [PATCH v2 pve-network 06/13] add frr plugin

2019-08-29 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/API2/Network/SDN.pm | 1 + PVE/Network/SDN.pm | 2 + PVE/Network/SDN/FrrPlugin.pm | 93 PVE/Network/SDN/Makefile | 2 +- PVE/Network/SDN/Plugin.pm| 6 +++ 5 files changed, 103 insertions(+),

[pve-devel] [PATCH v2 pve-network 02/13] add new status sub and move code from test

2019-08-29 Thread Alexandre Derumier
old status sub was renamed ifquery_check also check if local config exist or if local config is too old. (fixme : compare mtime, maybe could we use some kind of version for this?) we can have 4 status code: - pending : local config is absent but sdn.cfg exist - unknown : local config is too old,

[pve-devel] [PATCH v2 pve-network 01/13] add generate_etc_network_config && write_etc_network_config subs

2019-08-29 Thread Alexandre Derumier
moved from test script, also skip vnet generation instead die in case of error Signed-off-by: Alexandre Derumier --- PVE/Network/SDN.pm | 73 + test/generateconfig.pl | 81 ++ 2 files changed, 76 insertions(+), 78 de

[pve-devel] [PATCH v2 pve-network 13/13] add documentation.txt

2019-08-29 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- test/documentation.txt | 82 ++ 1 file changed, 82 insertions(+) create mode 100644 test/documentation.txt diff --git a/test/documentation.txt b/test/documentation.txt new file mode 100644 index 000..567b798 --- /

[pve-devel] [PATCH v2 pve-network 12/13] sdn: add write_frr_config

2019-08-29 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Network/SDN.pm | 13 + test/generateconfig.pl | 5 + 2 files changed, 18 insertions(+) diff --git a/PVE/Network/SDN.pm b/PVE/Network/SDN.pm index 80a70d8..1e89d97 100644 --- a/PVE/Network/SDN.pm +++ b/PVE/Network/SDN.pm @@ -259,6 +25

[pve-devel] [PATCH v2 pve-network 07/13] vxlanplugin: add vrf and vrfvxlan

2019-08-29 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/VxlanPlugin.pm | 45 -- 1 file changed, 43 insertions(+), 2 deletions(-) diff --git a/PVE/Network/SDN/VxlanPlugin.pm b/PVE/Network/SDN/VxlanPlugin.pm index ae1f86a..c93dbc4 100644 --- a/PVE/Network/SDN/VxlanPlu

[pve-devel] [PATCH v2 pve-network 09/13] generate network config in a hash

2019-08-29 Thread Alexandre Derumier
more clean and avoid duplicate interface Signed-off-by: Alexandre Derumier --- PVE/Network/SDN.pm | 26 -- PVE/Network/SDN/FrrPlugin.pm | 33 ++-- PVE/Network/SDN/VlanPlugin.pm | 32 ++-- PVE/Network/SDN/VxlanPlugin.pm | 95 +

[pve-devel] [PATCH v2 pve-network 10/13] sdn: add generate_frr_config

2019-08-29 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Network/SDN.pm | 94 ++ PVE/Network/SDN/FrrPlugin.pm | 15 ++ PVE/Network/SDN/VlanPlugin.pm | 4 +- PVE/Network/SDN/VxlanPlugin.pm | 55 ++-- test/generateconfig.pl | 5 +- 5 fil

[pve-devel] [PATCH v2 pve-network 08/13] vxlan: add support for ipv4/ipv6/mac for anycast routing

2019-08-29 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/VnetPlugin.pm | 7 --- PVE/Network/SDN/VxlanPlugin.pm | 11 +-- 2 files changed, 13 insertions(+), 5 deletions(-) diff --git a/PVE/Network/SDN/VnetPlugin.pm b/PVE/Network/SDN/VnetPlugin.pm index 6da17b7..09e9372 100644 --- a/PVE

[pve-devel] [PATCH v2 pve-network 03/13] api2: add local endpoint for listing content of a transportzone

2019-08-29 Thread Alexandre Derumier
pveset get /nodes//sdn//content ┌─┬┐ │ vnet│ status │ ├─┼┤ │ vnet100 │ error │ ├─┼┤ │ vnet101 │ error │ └─┴┘ Signed-off-by: Alexandre Derumier --- PVE/API2/Network/Makefile | 2 + PVE/API2/Network/SDN/Content.pm | 80 +

[pve-devel] [PATCH v2 pve-network 04/13] api2: add local endpoint for listing transportzones status

2019-08-29 Thread Alexandre Derumier
pvesh get /nodes//sdn/ ┌─┬───┐ │ sdn │ status│ ├─┼───┤ │ transportzone10 │ error │ ├─┼───┤ │ zone1 │ available │ ├─┼───┤ │ zone4 │ available │ └─┴─

[pve-devel] [PATCH v2 pve-network 11/13] add update_delete hook on frr related options

2019-08-29 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/FrrPlugin.pm | 20 --- PVE/Network/SDN/VxlanPlugin.pm | 35 ++ 2 files changed, 52 insertions(+), 3 deletions(-) diff --git a/PVE/Network/SDN/FrrPlugin.pm b/PVE/Network/SDN/FrrPlugin.pm index

[pve-devel] [PATCH v2 pve-network 05/13] make Vxlanplugin generic for multicast/unicast/frr

2019-08-29 Thread Alexandre Derumier
if no multicast or unicast address is defined, default to frr Signed-off-by: Alexandre Derumier --- PVE/API2/Network/SDN.pm | 2 +- PVE/Network/SDN.pm| 4 +- PVE/Network/SDN/Makefile | 2 +- PVE/Network/SDN/Plugin.pm

Re: [pve-devel] [PATCH i18n] Add comment about make update

2019-08-29 Thread Thomas Lamprecht
On 29.08.19 10:39, Stefan Reiter wrote: > On 8/29/19 10:06 AM, Dominic Jäger wrote: >> Signed-off-by: Dominic Jäger >> --- >> I did not know that we have to run 'make update' when adding a new >> language to i18n and have overseen a lot of errors as a consequence [0]. >> We might want to give (new

[pve-devel] [PATCH cluster] pmxcfs: get config properties: ensure we do not read after the config

2019-08-29 Thread Thomas Lamprecht
pmxcfs files need to be treated as blobs, while we can have some assumptions on certain files, like the $vmid.conf ones, we should still cope with problematic files. Especially, the files may not end with \0, so always ensure that we read at most file-size bytes. Replace strtok_r, which assumes th

Re: [pve-devel] ifupdown2 pve package missing in buster/proxmox6 repo

2019-08-29 Thread Mira Limbeck
Allowing multiple bridges to be vlan-aware requires a change in the config. See https://github.com/CumulusNetworks/ifupdown2/issues/92#issuecomment-458135952 Without this change you get "error: ignoring interface . Only one object with attribute 'bridge-vlan-aware yes' allowed." for every add

[pve-devel] applied: [PATCH cluster 1/2] cfs-utils cluster_config_version: actually enforce config_length when matching

2019-08-29 Thread Thomas Lamprecht
Fix out-of-bound read found with AddressSanitizer Signed-off-by: Thomas Lamprecht --- data/src/cfs-utils.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/data/src/cfs-utils.c b/data/src/cfs-utils.c index 2c91621..acf65b2 100644 --- a/data/src/cfs-utils.c +++ b/data/src/c

[pve-devel] applied: [PATCH cluster 2/2] check_memdb: free data to allow building with memory leak sanitizer

2019-08-29 Thread Thomas Lamprecht
while this "memory leak" was irrelevant (short running anyway, so the OS could clean up after us just fine) let's free the malloced stuff nonetheless - this allows to build with -fsanitize=address and -fsanitize=undefined Signed-off-by: Thomas Lamprecht --- data/src/check_memdb.c | 3 +++ 1 file

[pve-devel] [PATCH pve-docs] update vxlan-evpn doc

2019-08-29 Thread Alexandre Derumier
Now that vrf leaking is supported with default vrf, setup is more simple for exit node. (not need extra interface) Also cleanup symmetric config Signed-off-by: Alexandre Derumier --- vxlan-and-evpn.adoc | 239 +++- 1 file changed, 59 insertions(+), 180 de

Re: [pve-devel] ifupdown2 pve package missing in buster/proxmox6 repo

2019-08-29 Thread Alexandre DERUMIER
Thanks for reporting, Seem that a previous patch has been lost with the update to 1.28 https://git.proxmox.com/?p=ifupdown2.git;a=blob;f=debian/patches/pve/0001-config-tuning.patch;h=8e35cba84c4ce412faa1614c4ec39f28c4bbb553;hb=a850e8b1e64787cedd821e8131ba3b045fd352c3 - Mail original - De

Re: [pve-devel] ifupdown2 pve package missing in buster/proxmox6 repo

2019-08-29 Thread Thomas Lamprecht
On 30.08.19 03:14, Alexandre DERUMIER wrote: > Thanks for reporting, > > Seem that a previous patch has been lost with the update to 1.28 > > https://git.proxmox.com/?p=ifupdown2.git;a=blob;f=debian/patches/pve/0001-config-tuning.patch;h=8e35cba84c4ce412faa1614c4ec39f28c4bbb553;hb=a850e8b1e64787c