[pve-devel] [PATCH common] Fix 2339: Handle multiple blank lines correctly

Otherwise two blank lines between sections cause the loop to end prematurely. Signed-off-by: Fabian Ebner --- src/PVE/SectionConfig.pm | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/PVE/SectionConfig.pm b/src/PVE/SectionConfig.pm index dcecce6..1bb285f 100644 --- a/s

[pve-devel] applied: [PATCH firewall] fix use of uninitialized value

On 26.08.19 14:55, Mira Limbeck wrote: > $param->{rename} was not checked for definedness even though it is > optional. This lead to a 'use of uninitialized value' when just updating > the cidr. > > Signed-off-by: Mira Limbeck > --- > src/PVE/API2/Firewall/Aliases.pm | 3 ++- > 1 file changed, 2

Re: [pve-devel] Gitlab-ci

Hi, I think 1 benefit of gitlab,github,... is the tracking of merge request. (To not lost some patches series send months ago). For code review it great too. (make comments directly in the merge) I'm curious, do you use some kind of email scripts, special email client, to manage current workfl

[pve-devel] [PATCH docs] pve-network: add short section explaining Open vSwitch

Signed-off-by: Christian Ebner --- pve-network.adoc | 140 ++- 1 file changed, 139 insertions(+), 1 deletion(-) diff --git a/pve-network.adoc b/pve-network.adoc index b2dae97..e8f17af 100644 --- a/pve-network.adoc +++ b/pve-network.adoc @@ -489,7 +489,

[pve-devel] [PATCH v2 docs 1/2] Mention GUI for creating a cluster and adding nodes

Signed-off-by: Stefan Reiter --- v2: * Changed some wording to remove "you"s and made sections clearer. Big thanks to Aaron for the helpful review. * Do not remove [[pvecm_create_cluster]] tag pvecm.adoc | 77 -- 1 file changed, 58 insertio

[pve-devel] ifupdown2 pve package missing in buster/proxmox6 repo

Hi, the ifupdown2 pve package is missing from buster/proxmox6 repo. Could you add it ? Thanks Alexandre ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH docs] pve-network: add short section explaining Open vSwitch

Some notes from my side, changing sentence structure to put the important parts to the beginning and using a more active voice. Some typos and missed use of {pve} got changed as well. More inline :) On 8/27/19 12:27 PM, Christian Ebner wrote: Signed-off-by: Christian Ebner --- pve-network.

Re: [pve-devel] [PATCH common] Fix 2339: Handle multiple blank lines correctly

On 27.08.19 09:01, Fabian Ebner wrote: > Otherwise two blank lines between sections cause the loop to end prematurely. > > Signed-off-by: Fabian Ebner > --- > src/PVE/SectionConfig.pm | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/src/PVE/SectionConfig.pm b/src/PVE

Re: [pve-devel] ifupdown2 pve package missing in buster/proxmox6 repo

Hi, On 27.08.19 16:28, Alexandre DERUMIER wrote: > Hi, > > the ifupdown2 pve package is missing from buster/proxmox6 repo. > > Could you add it ? yes, as we had the same version as Debian Buster it seemed I missed to re-upload it.. I'd then already update to 1.2.8 or? Currently in the proces