Re: [pve-devel] [RFC PATCH common] cli: prettify tables even more

2019-08-22 Thread Wolfgang Bumiller
On Wed, Aug 21, 2019 at 09:35:56PM +0200, Dietmar Maurer wrote: > Are your sure common terminals support those characters? > > They did not when I tested ... Curious, when using utf-8 encoding for those characters I wouldn't see how these characters would be any more special than any other? In an

[pve-devel] [PATCH manager 1/2] fix #2340: gui: ceph: handle 'null' versions for hosts

2019-08-22 Thread Dominik Csapak
the api returns 'null' for a host that is in the crushmap, but without actual version information, so just check for falsyness instead of 'undefined', else we run later into javascript exceptions and no content on the osd page Signed-off-by: Dominik Csapak --- i am not so sure if the api return '

[pve-devel] [PATCH manager 2/2] fix #2341: ceph: osd create: allow db/wal on partioned disks

2019-08-22 Thread Dominik Csapak
It was intended that for partitioned disks, we create one and use it. Instead the code died always when the disk was used and not of type 'LVM' We now check correctly the 2 cases: * used for partitions and has gpt * used and lvm The remaining api call handles those two cases correctly Signed-off

[pve-devel] [PATCH storage 1/2] fix #2216: Allow .img files in 'iso' type storages

2019-08-22 Thread Stefan Reiter
To maintain full (backwards) compatibility, leave the type name as 'iso' - this makes this patch work without changing every consumer of storage APIs. Note that currently these files can only be attached as a CDROM/DVD drive, so USB-only imgs can be uploaded but might not work in VMs. Signed-off-

[pve-devel] [PATCH manager 2/2] Show supported file types in upload file selector

2019-08-22 Thread Stefan Reiter
By default, all file types are shown, but the user now has the option of filtering only by supported types in the file selector dialog. Signed-off-by: Stefan Reiter --- www/manager6/storage/ContentView.js | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/www/manager6/st

Re: [pve-devel] [PATCH storage 1/2] fix #2216: Allow .img files in 'iso' type storages

2019-08-22 Thread Dominik Csapak
comments inline On 8/22/19 1:35 PM, Stefan Reiter wrote: To maintain full (backwards) compatibility, leave the type name as 'iso' - this makes this patch work without changing every consumer of storage APIs. Note that currently these files can only be attached as a CDROM/DVD drive, so USB-only

Re: [pve-devel] [PATCH manager 2/2] Show supported file types in upload file selector

2019-08-22 Thread Dominik Csapak
looks ok, a bit weird, but researching showed that there are no extjs builtin ways for this, so... Acked-by: Dominik Csapak On 8/22/19 1:35 PM, Stefan Reiter wrote: By default, all file types are shown, but the user now has the option of filtering only by supported types in the file selector

[pve-devel] applied: [PATCH manager] ui: vm memory: correctly set initial maxValue for balloon

2019-08-22 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- www/manager6/qemu/MemoryEdit.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager6/qemu/MemoryEdit.js b/www/manager6/qemu/MemoryEdit.js index 4c4d1815..d1284716 100644 --- a/www/manager6/qemu/MemoryEdit.js +++ b/www/manager6/qemu/MemoryEdit.js @@

[pve-devel] applied: [PATCH manager 1/2] fix #2340: gui: ceph: handle 'null' versions for hosts

2019-08-22 Thread Thomas Lamprecht
On 8/22/19 12:26 PM, Dominik Csapak wrote: > the api returns 'null' for a host that is in the crushmap, but > without actual version information, so just check for falsyness instead > of 'undefined', else we run later into javascript exceptions and no > content on the osd page > > Signed-off-by: D

[pve-devel] applied: [PATCH manager 2/2] fix #2341: ceph: osd create: allow db/wal on partioned disks

2019-08-22 Thread Thomas Lamprecht
On 8/22/19 12:26 PM, Dominik Csapak wrote: > It was intended that for partitioned disks, we create one and use it. > Instead the code died always when the disk was used and not of type 'LVM' > > We now check correctly the 2 cases: > * used for partitions and has gpt > * used and lvm > > The remai

[pve-devel] [PATCH v2 manager 2/2] Show supported file types in upload file selector

2019-08-22 Thread Stefan Reiter
By default, all file types are shown, but the user now has the option of filtering only by supported types in the file selector dialog. Signed-off-by: Stefan Reiter Acked-by: Dominik Csapak --- I found it weird too, but also couldn't find a different way to go about it... www/manager6/storage

[pve-devel] [PATCH v2 storage 1/2] fix #2216: Allow .img files in 'iso' type storages

2019-08-22 Thread Stefan Reiter
To maintain full (backwards) compatibility, leave the type name as 'iso' - this makes this patch work without changing every consumer of storage APIs. Note that currently these files can only be attached as a CDROM/DVD drive, so USB-only images can be uploaded but might not work in VMs. Signed-of

Re: [pve-devel] [PATCH v2 qemu-server] Fix #2041, #2272 Add Spice enhancements

2019-08-22 Thread Dominik Csapak
looks good, but 2 comments inline On 8/20/19 6:02 PM, Aaron Lauterer wrote: This adds a new config option called `spice_enhancements` with two optional settings: * videostreaming * foldersharing Signed-off-by: Aaron Lauterer v1 -> v2: format changes suggested by dominik: * changed descriptio

[pve-devel] [PATCH docs 1/2] Mention GUI for creating a cluster and adding nodes

2019-08-22 Thread Stefan Reiter
Signed-off-by: Stefan Reiter --- pvecm.adoc | 81 -- 1 file changed, 60 insertions(+), 21 deletions(-) diff --git a/pvecm.adoc b/pvecm.adoc index e986a75..5379c3f 100644 --- a/pvecm.adoc +++ b/pvecm.adoc @@ -103,25 +103,33 @@ to the other with

Re: [pve-devel] [PATCH docs 1/2] Mention GUI for creating a cluster and adding nodes

2019-08-22 Thread Thomas Lamprecht
On 8/22/19 4:53 PM, Stefan Reiter wrote: > Signed-off-by: Stefan Reiter > --- > pvecm.adoc | 81 -- > 1 file changed, 60 insertions(+), 21 deletions(-) > > diff --git a/pvecm.adoc b/pvecm.adoc > index e986a75..5379c3f 100644 > --- a/pvecm.adoc

[pve-devel] [PATCH v3 qemu-server] Fix #2041, #2272 Add Spice enhancements

2019-08-22 Thread Aaron Lauterer
This adds a new config option called `spice_enhancements` with two optional settings: * videostreaming * foldersharing Signed-off-by: Aaron Lauterer --- v2 -> v3: Move the video-streaming string creation out of the '-spice' string for backwards compatibility. Remove the `// 0` from setting the