add the dirs to the proxy and the css file to the index template
Signed-off-by: Dominik Csapak
---
PVE/Service/pveproxy.pm | 2 ++
www/index.html.tpl | 1 +
2 files changed, 3 insertions(+)
diff --git a/PVE/Service/pveproxy.pm b/PVE/Service/pveproxy.pm
index a07330c4..dd123dd8 100755
--- a
Signed-off-by: Dominik Csapak
---
Makefile| 18 +-
css/Makefile| 13 +
defines.mk | 15 +++
images/Makefile | 13 +
4 files changed, 46 insertions(+), 13 deletions(-)
create mode 100644 css/Makefile
create mode 100644 defines.
when we have a combogrid that may be empty, we now show a
little 'x' where the user can delete the content
this is not shown when the field is not allowed to be empty
we add a new css for this because triggers need a background image
with a very specific layout:
110x22px which is 5 icons in one
this series adds a clear trigger for the combogrid where allowblank
is set to true
i am not sure about the dependencies, but the second patch from
widget-toolkit 'needs' the pve-manager changes already, so maybe
a versioned 'breaks' is in order?
also we could do the same for pmg-api/gui but we do
since commit 05d9252c00dcb3bc4d0be8e4ab869afaddd25f47 we can use the
Font Awesome icons without them being shown in the remove dialog, so
convert more to them - they are vectors and look a bit better.
Also ensure that all icons are rendered as fixed width, with fa-fw
Signed-off-by: Thomas Lamprec
The latest changes to our audio device implemenation [0] changed the
naming of the device id to "audio" which in practice resulted in
"audio0".
This conflicts with the predefined audio device in the Q35 configs
that is also using "audio0". The result is that a VM with a configured
audio device and
On 7/24/19 12:03 PM, Aaron Lauterer wrote:
The latest changes to our audio device implemenation [0] changed the
naming of the device id to "audio" which in practice resulted in
"audio0".
This conflicts with the predefined audio device in the Q35 configs
that is also using "audio0". The result is
looks okay, one comment inline
On 7/15/19 12:28 PM, Dominic Jäger wrote:
The StdRemoveButton can now pass a delay parameter to the API.
It is set undefined as default so that users of the button
can set the parameter themselves.
Signed-off-by: Dominic Jäger
---
v3->v4: Make the delay undefined
On 7/24/19 12:10 PM, Dominik Csapak wrote:
On 7/24/19 12:03 PM, Aaron Lauterer wrote:
The latest changes to our audio device implemenation [0] changed the
naming of the device id to "audio" which in practice resulted in
"audio0".
This conflicts with the predefined audio device in the Q35 conf
On 7/24/19 12:15 PM, Aaron Lauterer wrote:
On 7/24/19 12:10 PM, Dominik Csapak wrote:
On 7/24/19 12:03 PM, Aaron Lauterer wrote:
The latest changes to our audio device implemenation [0] changed the
naming of the device id to "audio" which in practice resulted in
"audio0".
This conflicts wi
maybe change only the id in the config?
in the q35 config? This will not break live migration? Or do you mean
the id in QemuServer.pm?
i meant in the config, but i am not sure if this breaks live migration
(probably though, one would have to test it ;) )
alternatively for q35 the id in QemuSer
and constant AT_EMPTY_PATH for chowning a directory/file opened via
openat(2), for example when walking/creating a directory tree without
following symlinks.
Signed-off-by: Fabian Grünbichler
---
src/PVE/Syscall.pm | 1 +
src/PVE/Tools.pm | 7 +++
2 files changed, 8 insertions(+)
diff --g
otherwise unprivileged containers might end up with directories that
they cannot modify since they are owned by the user root in the host
namespace, instead of root inside the container.
note: the problematic behaviour is only exhibited when an intermediate
directory needs to be created, e.g. a mo
disregard this, will send a v2 shortly that fixes an edge case.
On Wed, Jul 24, 2019 at 01:37:13PM +0200, Fabian Grünbichler wrote:
> otherwise unprivileged containers might end up with directories that
> they cannot modify since they are owned by the user root in the host
> namespace, instead of
On Wed, Jul 24, 2019 at 01:46:42PM +0200, Fabian Grünbichler wrote:
> disregard this, will send a v2 shortly that fixes an edge case.
seems like that edge case behaviour was not caused by this patch, sorry
for the noise.
> On Wed, Jul 24, 2019 at 01:37:13PM +0200, Fabian Grünbichler wrote:
> > ot
it seems like you're working in an area of code that could also be
relevant for my (small) problem from:
https://pve.proxmox.com/pipermail/pve-devel/2017-September/028814.html
https://pve.proxmox.com/pipermail/pve-devel/2017-October/029004.html
or maybe this could also be a problem if your mps are
The latest changes to our audio device implemenation [0] changed the
naming of the device id to "audio" which in practice resulted in
"audio0".
This conflicts with the predefined audio device in the Q35 configs
that is also using "audio0". The result is that a VM with a
configured audio device and
A generated VM with default values does not set the memory key in the
configuration. Hence the size of the state file for a suspend had only
the default size of the state itself and not in addition twice the
configured memory.
The patch uses the static defaults from the JSON schema if the memory
k
Signed-off-by: Aaron Lauterer
---
Not sure how everyone feels about this, but maybe a small note like this
is useful to not forget to remove this when we get the next chance.
pve-q35-4.0.cfg | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/pve-q35-4.0.cfg b/pve-q35-4.0.cfg
On 7/24/19 3:57 PM, Aaron Lauterer wrote:
> Signed-off-by: Aaron Lauterer
> ---
>
> Not sure how everyone feels about this, but maybe a small note like this
> is useful to not forget to remove this when we get the next chance.
>
> pve-q35-4.0.cfg | 4 +++-
> 1 file changed, 3 insertions(+), 1 d
in case pvedaemon is not running or we somehow get a 595 response (connection
failure), we want to tell this to the user, since "Login failed" doesn't
help.
handle all connection failures, leave the rest the same.
we could go into more detail (CONNECT_FAILURE, CLIENT_INVALID,
LOAD_FAILURE and SERV
As much as it hurts to say this about a patch changing only icon
visuals, but this breaks the Hardware View: If you add a CD drive, it
will show up as a regular hard disk, and opens in the wrong editor.
AFAICT 'pve-itype-icon-storage' is used as an indicator if the chosen
row is a CD drive or
On 7/24/19 4:53 PM, Oguz Bektas wrote:
> in case pvedaemon is not running or we somehow get a 595 response (connection
s/somehow/somehow else/
> failure), we want to tell this to the user, since "Login failed" doesn't
> help.
>
> handle all connection failures, leave the rest the same.
> we coul
in case pvedaemon is not running or we somehow else get a 595 response
(connection
failure), we want to tell this to the user, since "Login failed" doesn't
help.
handle all connection failures, leave the rest the same.
we could go into more detail (CONNECT_FAILURE, CLIENT_INVALID,
LOAD_FAILURE an
This was pretty brittle to begin with, on should not attach logic to
CSS class names or the like, if possible.
Signed-off-by: Thomas Lamprecht
---
@Stefan: Much thanks for detecting this so quickly! And yes it hurt me too,
thus I decoupled it from any CSS class name parsing, or the like, complet
On 7/24/19 5:46 PM, Oguz Bektas wrote:
> in case pvedaemon is not running or we somehow else get a 595 response
> (connection
> failure), we want to tell this to the user, since "Login failed" doesn't
> help.
>
> handle all connection failures, leave the rest the same.
> we could go into more det
On 7/24/19 3:56 PM, Alwin Antreich wrote:
> A generated VM with default values does not set the memory key in the
> configuration. Hence the size of the state file for a suspend had only
> the default size of the state itself and not in addition twice the
> configured memory.
>
> The patch uses th
On 7/24/19 12:14 PM, Dominik Csapak wrote:
>> @@ -130,9 +133,11 @@ Ext.define('Proxmox.button.StdRemoveButton', {
>> handler: function(btn, event, rec) {
>> var me = this;
>> +var url = me.getUrl(rec);
>> +if (typeof me.delay !== 'undefined') url += "?delay=" + me.delay;
>
>
28 matches
Mail list logo
