[pve-devel] [PATCH pve-common] api_dump_remove_refs: prepare API tree for use with to_json($tree)

We want to use this with the extractapi.pl helper (pve-docs, pve-api-client). Signed-off-by: Dietmar Maurer --- src/PVE/RESTHandler.pm | 33 + 1 file changed, 33 insertions(+) diff --git a/src/PVE/RESTHandler.pm b/src/PVE/RESTHandler.pm index 3f5c732..5c64a20 100

Re: [pve-devel] [PATCH pve-common] api_dump_remove_refs: prepare API tree for use with to_json($tree)

two comments inline, which can be probably ignored... On 5/18/18 9:18 AM, Dietmar Maurer wrote: > We want to use this with the extractapi.pl helper (pve-docs, pve-api-client). > > Signed-off-by: Dietmar Maurer > --- > src/PVE/RESTHandler.pm | 33 + > 1 file chang

Re: [pve-devel] [PATCH pve-common] api_dump_remove_refs: prepare API tree for use with to_json($tree)

> > +if ($class eq 'ARRAY') { > > + my $res = []; > > + foreach my $el (@$tree) { > > + push @$res, api_dump_remove_refs($el); > > + } > > + return $res; > > above 4 lines could be written as: > > return [ map { api_dump_remove_refs($_) } @$tree ]; I still prefer the othe

[pve-devel] applied: [PATCH pve-common] api_dump_remove_refs: prepare API tree for use with to_json($tree)

applied with suggested changes. ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH qemu-server] Improve error message of shared storage connection check.

Now you see if the storage plugin support it, extra information about the error. --- PVE/QemuMigrate.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm index 27cf7e3..55a5554 100644 --- a/PVE/QemuMigrate.pm +++ b/PVE/QemuMigrate.pm @

[pve-devel] Make storage offline message more informative.

There are several reasons why storage could be offline. With this series, it is possible to make the offline message more informative. ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [Patch container] Improve error message of shared storage connection check.

Now you see if the storage plugin support it, extra information about the error. --- src/PVE/LXC/Migrate.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/PVE/LXC/Migrate.pm b/src/PVE/LXC/Migrate.pm index 1364b8d..e380bd8 100644 --- a/src/PVE/LXC/Migrate.pm +++ b/src/

[pve-devel] [Patch storage 2/2] Improve error message.

Now we get all errors from the cifs client and also if the client program fails. --- PVE/Storage/CIFSPlugin.pm | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/PVE/Storage/CIFSPlugin.pm b/PVE/Storage/CIFSPlugin.pm index 724fb1f..c1a0a0d 100644 --- a/PVE/Storage/CIFSPlugin.

[pve-devel] [Patch storage 1/2] Improve error message of shared storage connection check.

Now you see if the storage plugin support it, extra information about the error. --- PVE/Storage.pm | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/PVE/Storage.pm b/PVE/Storage.pm index d733380..b900a4e 100755 --- a/PVE/Storage.pm +++ b/PVE/Storage.pm @@ -914,9 +914,8 @@ s

[pve-devel] applied: [PATCH manager] ui: dc/storage: allow to renenable iscsi storages again

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH manager] correctly parse iscsi content

we parse the content as a list, so it is always an array Signed-off-by: Dominik Csapak --- already applied www/manager6/storage/IScsiEdit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/storage/IScsiEdit.js b/www/manager6/storage/IScsiEdit.js index 6a7db2af..

[pve-devel] [PATCH cluster] use constants for IPC request types

Add a simple header with the constants as defines. Use a simple awk script to translate this to an perl module with the constants exported. awk is far easier to understand and maintain than h2ph or h2xs, also their result is quite a mess for such a trivial thing, IMO. Signed-off-by: Thomas Lamprec

[pve-devel] [Patch storage] fix #1770: allow ex/import linked clones.

We encode the base-volume-name in the volname what is not needed. On ex/import we need the correct dataset name. --- PVE/Storage/ZFSPoolPlugin.pm | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/PVE/Storage/ZFSPoolPlugin.pm b/PVE/Storage/ZFSPoolPlugin.pm index fd63d94..32

[pve-devel] [PATCH qemu-server] activate volume for cloudinit disk

because it does not have to be activated (e.g. in case of lvm) Signed-off-by: Dominik Csapak --- PVE/QemuServer/Cloudinit.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/PVE/QemuServer/Cloudinit.pm b/PVE/QemuServer/Cloudinit.pm index d536a0f..3cdf3a6 100644 --- a/PVE/QemuServer/Cloudini

[pve-devel] applied: [PATCH common] fix #1766: compare task starttime numerically

On 5/16/18 8:54 AM, Wolfgang Bumiller wrote: > Not only because <=> is correct, but using 'cmp' also has > the side effect that it adds a string version to the > variable and the API's json output turns into a string as > well, and this only happens once a task has completed > (while it's an intege

[pve-devel] applied: [PATCH manager] ui: use cbind to make usb input panel static

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] pvedaemon hanging because of qga retry

> >>If you simply skip commands like 'guest-fsfreeze-thaw' > >>your VM will get totally unusable (frozen). So I am not > >>sure what you want to suggest? > > I'm not sure, but don't we have 2 timeout here ? > > 1 for connect , and 1 for command execution ? what for? > I would like to be able