[pve-devel] [PATCH qemu-server] remove legacy vm_monitor_command

We introduced our QMP socket with commit c971c4f2213524f27125f558978a428b53628f34 (29.05.2012) Already tried to remove this with commit 7b7c6d1b5dcee25e1194d4b8a0219bd5c31a5639 (13.07.2012) But reverted that to allow migration of VMs still using the old montior to ones which already switched over

Re: [pve-devel] [PATCH qemu-server 1/3] use default hostname when none is set

On 03/12/2018 04:25 PM, Dominik Csapak wrote: > use "VM$vmid" like we do in a container > series looks OK for me, but I let Wolfgang/Dietmar handle this, CloudInit is fully theirs ;) Reviewed-by: Thomas Lamprecht Nit: could you please add a tag in front of the commit message, for a series like

[pve-devel] [PATCH] increase zfs default timeout to 30sec

busy pools can easily take more than 5 seconds for eg. zfs create --- PVE/Storage/ZFSPoolPlugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/Storage/ZFSPoolPlugin.pm b/PVE/Storage/ZFSPoolPlugin.pm index e864a58..7ba035f 100644 --- a/PVE/Storage/ZFSPoolPlugin.pm +++ b/

[pve-devel] avoiding VMID reuse

Hi, we'd like to keep VMIDs always unique per node, so that we can use zfs for backups more easily (ie. avoid dataset name collisions; granted, this still leaves room for collisions if disks are removed and added to a VM). We've implemented the following (crappy) PoC that accomplishes just this by

Re: [pve-devel] [PATCH] increase zfs default timeout to 30sec

first off, thanks for the patch! if you haven't already, please send a signed CLA[1] to off...@proxmox.com, and include a "Signed-Off-By" tag in your commits/patches! On Mon, Mar 12, 2018 at 04:06:47PM +0200, Lauri Tirkkonen wrote: > busy pools can easily take more than 5 seconds for eg. zfs

Re: [pve-devel] [PATCH] increase zfs default timeout to 30sec

On Tue, Mar 13 2018 09:45:18 +0100, Fabian Grünbichler wrote: > On Mon, Mar 12, 2018 at 04:06:47PM +0200, Lauri Tirkkonen wrote: > > busy pools can easily take more than 5 seconds for eg. zfs create > > --- > > PVE/Storage/ZFSPoolPlugin.pm | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [pve-devel] avoiding VMID reuse

Hi, On 03/12/2018 03:13 PM, Lauri Tirkkonen wrote: > Hi, > > we'd like to keep VMIDs always unique per node, so that we can use zfs > for backups more easily (ie. avoid dataset name collisions; granted, > this still leaves room for collisions if disks are removed and added to > a VM). We've imple

Re: [pve-devel] avoiding VMID reuse

On Tue, Mar 13 2018 10:06:41 +0100, Thomas Lamprecht wrote: > On 03/12/2018 03:13 PM, Lauri Tirkkonen wrote: > > Hi, > > > > we'd like to keep VMIDs always unique per node, so that we can use zfs > > for backups more easily (ie. avoid dataset name collisions; granted, > > this still leaves room fo

Re: [pve-devel] [PATCH] increase zfs default timeout to 30sec

On 03/13/2018 09:53 AM, Lauri Tirkkonen wrote: > On Tue, Mar 13 2018 09:45:18 +0100, Fabian Grünbichler wrote: >> On Mon, Mar 12, 2018 at 04:06:47PM +0200, Lauri Tirkkonen wrote: >>> busy pools can easily take more than 5 seconds for eg. zfs create >>> --- >>> PVE/Storage/ZFSPoolPlugin.pm | 2 +- >

[pve-devel] [PATCH manager 0/8] further build/postinst cleanups

this series follows up on the recent build/packaging cleanup series by Thomas Lamprecht, adds some missing bits and refactors the postinst some more to make it short/easier to read also included are two entirely unrelated nit fixes for the build it self Fabian Grünbichler (8): postinst: cleanup

[pve-devel] [PATCH manager 2/8] postinst: actually enable and start pveupdate.timer

Signed-off-by: Fabian Grünbichler --- debian/postinst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/debian/postinst b/debian/postinst index 9f2b95a7..685f3c28 100755 --- a/debian/postinst +++ b/debian/postinst @@ -54,7 +54,7 @@ case "$1" in # same as dh_systemd_en

[pve-devel] [PATCH manager 7/8] build: use git rev-parse for GITVERSION

Signed-off-by: Fabian Grünbichler --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 532833aa..6cf32a95 100644 --- a/Makefile +++ b/Makefile @@ -7,7 +7,7 @@ DESTDIR= SUBDIRS = aplinfo PVE bin www ARCH:=$(shell dpkg-architecture -qDEB_BUI

[pve-devel] [PATCH manager 1/8] postinst: cleanup trigger code

reload-or-try-restart works just fine even if the unit is stopped or disabled Signed-off-by: Fabian Grünbichler --- debian/postinst | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/debian/postinst b/debian/postinst index 62ea8903..9f2b95a7 100755 --- a/debian/postinst

[pve-devel] [PATCH manager 3/8] postinst: refactor service/timer handling

reduce code duplication, and reload-or-restart timers just like service units instead of just starting them. Signed-off-by: Fabian Grünbichler --- debian/postinst | 33 + 1 file changed, 9 insertions(+), 24 deletions(-) diff --git a/debian/postinst b/debian/posti

[pve-devel] [PATCH manager 5/8] postinst: start/restart units like dh_start

with an added "reload-or" for pvedaemon/pveproxy/spiceproxy, which dh_start unfortunately does not yet support Signed-off-by: Fabian Grünbichler --- debian/postinst | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/debian/postinst b/debian/postinst index f2ac0ab2..a648ec

[pve-devel] [PATCH manager 4/8] postinst: unify version-dependent cleanup

putting this into one place is better for readability Signed-off-by: Fabian Grünbichler --- debian/postinst | 35 +-- 1 file changed, 17 insertions(+), 18 deletions(-) diff --git a/debian/postinst b/debian/postinst index ebce2536..f2ac0ab2 100755 --- a/debian/pos

[pve-devel] [RFC manager 8/8] build: remove empty WWWROOT dir

seems to be a remnant of the Apache days.. Signed-off-by: Fabian Grünbichler --- it's empty, and I did not find anything using it.. www/manager6/Makefile | 1 - defines.mk| 1 - 2 files changed, 2 deletions(-) diff --git a/www/manager6/Makefile b/www/manager6/Makefile index 2688fd0

[pve-devel] [PATCH manager 6/8] postinst: switch to /bin/sh

we don't use anything bash specific in our postinst, and this way linitian should warn us about any bashisms we introduce. Signed-off-by: Fabian Grünbichler --- debian/postinst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/postinst b/debian/postinst index a648ec39..5

[pve-devel] Cloud Init Questions

Hi, since the cloud init patches got recently applied, i had a few questions to any one actually using cloud init currently the instance-id is the hash of the config (afaics) so we trigger the cloud-init code for a new instance each time we have a differing config isn't this a little too much

[pve-devel] applied: [RFC common] cli: more generic interactive parameter definition

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [RFC qemu-server] cloud-init: make cipassword interactive on the CLI

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH manager 1/2] postinst: handle masked units

check if a unit is masked before starting/restarting/reloading it, as else we get pretty ugly error messages during upgrade. as "deb-systemd-helper --quiet was-enabled" differs from the "systemctl is-enabled" behaviour, the former returns true for masked units while the latter does not, we have to

[pve-devel] applied: [PATCH manager 2/2] postinst: ensure pve-daily-upgrade timer gets started on transition

Signed-off-by: Thomas Lamprecht Acked-by: Fabian Grünbichler --- debian/postinst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/debian/postinst b/debian/postinst index 4f8b158e..f1153fb3 100755 --- a/debian/postinst +++ b/debian/postinst @@ -93,6 +93,8 @@ case "$1" in # remove

[pve-devel] applied: [PATCH manager 0/8] further build/postinst cleanups

applied, with the two follow up patches we discussed Thomas Lamprecht (2): postinst: handle masked units postinst: ensure pve-daily-upgrade timer gets started on transition debian/postinst | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) -- 2.14.2 __

[pve-devel] applied: [PATCH cluster] cluster join: ensure updatecerts gets called on quorate cluster

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH cluster 2/2] api: add fork worker ID for create and join

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH cluster 1/2] pvecm: check if APIClient exception code is defined

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH cluster 1/2] refactor backup_cfs_database

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH cluster 2/2] fix tainted input in backup_cfs_database

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH REBASED v4 container 0/5] lxc clone/move volume patches

applied all 5 patches ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] Cloud Init Questions

On Tue, Mar 13, 2018 at 11:27:31AM +0100, Dominik Csapak wrote: > Hi, > > since the cloud init patches got recently applied, i had a few questions to > any one actually using cloud init > > currently the instance-id is the hash of the config (afaics) > so we trigger the cloud-init code for a new

[pve-devel] [PATCH qemu] build: use 3.0 source format

instead of manually including and calling quilt. resulting binary debs are identical. Signed-off-by: Fabian Grünbichler --- note: the rules file could probably benefit from further cleanup, but this was trivial and easily verifiable ;) debian/rules | 8 ++-- debian/source/format | 1

Re: [pve-devel] [PATCH qemu] build: use 3.0 source format

I don't really like this. Why not simply: %: dh $@ --with quilt > diff --git a/debian/source/format b/debian/source/format > new file mode 100644 > index 000..163aaf8 > --- /dev/null > +++ b/debian/source/format > @@ -0,0 +1 @@ > +3.0 (quilt) > -- > 2.14.2 > > >

[pve-devel] [PATCH storage 04/11] Add set CIFS credentials.

--- PVE/API2/Storage/Config.pm | 11 +++ 1 file changed, 11 insertions(+) diff --git a/PVE/API2/Storage/Config.pm b/PVE/API2/Storage/Config.pm index fa8d4de..a321204 100755 --- a/PVE/API2/Storage/Config.pm +++ b/PVE/API2/Storage/Config.pm @@ -52,6 +52,17 @@ my $extract_cifs_credentials =

[pve-devel] CIFS Plugin

This is a storage plugin for cifs/smb network storage. It is tested with Windows Server2012R2, Server1016, Debian9 with samba 4.5 and CentOS6 with samba 3.6. ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/li

[pve-devel] [PATCH storage 01/11] Remove pool with -f parameter.

The test pool will not removed if we do not force it. --- test/run_test_zfspoolplugin.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/run_test_zfspoolplugin.pl b/test/run_test_zfspoolplugin.pl index bda8348..f6218b1 100755 --- a/test/run_test_zfspoolplugin.pl +++ b/test

[pve-devel] [PATCH storage 03/11] Add helper function for extract CIFS credentials.

--- PVE/API2/Storage/Config.pm | 16 1 file changed, 16 insertions(+) diff --git a/PVE/API2/Storage/Config.pm b/PVE/API2/Storage/Config.pm index aa8c931..fa8d4de 100755 --- a/PVE/API2/Storage/Config.pm +++ b/PVE/API2/Storage/Config.pm @@ -12,6 +12,7 @@ use HTTP::Status qw(:consta

[pve-devel] [PATCH storage 05/11] Add cifs in create API call.

In this patch the nodes will be deleted if the nodes parameter comes with a empty string. We need this in the GUI when update the nodes in the config to reset if a nodes. If we do not erase the empty hash the storage online check would be skipped. Also the password and user would not be verified.

[pve-devel] [PATCH manager] Add cifs storage plugin

--- www/manager6/Makefile| 1 + www/manager6/Utils.js| 2 + www/manager6/dc/StorageView.js | 11 ++ www/manager6/storage/CIFSEdit.js | 285 +++ 4 files changed, 299 insertions(+) create mode 100644 www/manager6/storage/CIFSEdit.js

[pve-devel] [PATCH storage 11/11] Add cifsscan to CLI

--- PVE/CLI/pvesm.pm | 13 + 1 file changed, 13 insertions(+) diff --git a/PVE/CLI/pvesm.pm b/PVE/CLI/pvesm.pm index 9455595..e6c37ea 100755 --- a/PVE/CLI/pvesm.pm +++ b/PVE/CLI/pvesm.pm @@ -331,6 +331,19 @@ our $cmddef = { printf "%-${maxlen}s %s\n", $rec->{p

[pve-devel] [PATCH storage 07/11] Add CIFS dependencies in package management.

--- debian/control | 2 ++ 1 file changed, 2 insertions(+) diff --git a/debian/control b/debian/control index 04812bb..ffaefff 100644 --- a/debian/control +++ b/debian/control @@ -24,6 +24,8 @@ Depends: cstream, smartmontools, thin-provisioning-tools, udev, +

[pve-devel] [PATCH storage 02/11] Add CIFS Storage Plugin.

This Plugin use as template the NFSpluigin. We do only support smbversion 2 and 3. Version 3 is default and must override through the config. --- PVE/Storage/CIFSPlugin.pm | 215 ++ PVE/Storage/Makefile | 2 +- 2 files changed, 216 insertions(+),

[pve-devel] [PATCH storage 09/11] Add cifsscan.

--- PVE/Storage.pm | 35 +++ 1 file changed, 35 insertions(+) diff --git a/PVE/Storage.pm b/PVE/Storage.pm index 6a2b40b..4140a99 100755 --- a/PVE/Storage.pm +++ b/PVE/Storage.pm @@ -1116,6 +1116,41 @@ sub scan_nfs { return $res; } +sub scan_cifs { +my

[pve-devel] [PATCH storage 10/11] Add cifsscan to API

--- PVE/API2/Storage/Scan.pm | 51 1 file changed, 51 insertions(+) diff --git a/PVE/API2/Storage/Scan.pm b/PVE/API2/Storage/Scan.pm index 11d139f..e9ce18e 100644 --- a/PVE/API2/Storage/Scan.pm +++ b/PVE/API2/Storage/Scan.pm @@ -45,6 +45,7 @@ __PAC

[pve-devel] [PATCH storage 06/11] Add remove cifs in API call.

--- PVE/API2/Storage/Config.pm | 6 ++ 1 file changed, 6 insertions(+) diff --git a/PVE/API2/Storage/Config.pm b/PVE/API2/Storage/Config.pm index f274593..d6d752a 100755 --- a/PVE/API2/Storage/Config.pm +++ b/PVE/API2/Storage/Config.pm @@ -310,6 +310,12 @@ __PACKAGE__->register_method ({

[pve-devel] [PATCH storage 08/11] Register CIFSPlugin in the storage plugin system.

--- PVE/Storage.pm| 2 ++ PVE/Storage/Plugin.pm | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/PVE/Storage.pm b/PVE/Storage.pm index 143ed2e..6a2b40b 100755 --- a/PVE/Storage.pm +++ b/PVE/Storage.pm @@ -25,6 +25,7 @@ use PVE::Storage::DirPlugin; use PVE::Storage::LV

Re: [pve-devel] [PATCH storage 03/11] Add helper function for extract CIFS credentials.

On 03/13/2018 03:11 PM, Wolfgang Link wrote: > --- > PVE/API2/Storage/Config.pm | 16 > 1 file changed, 16 insertions(+) > > diff --git a/PVE/API2/Storage/Config.pm b/PVE/API2/Storage/Config.pm > index aa8c931..fa8d4de 100755 > --- a/PVE/API2/Storage/Config.pm > +++ b/PVE/API2/St

[pve-devel] [PATCH qemu-server] use pve-edk2-firmware to load ovmf

We're able to just change it's path as we use the FD_SIZE_2MB option to build OVMF in the new pve-edk2-firmware package, which was the earlier implicit size of our current used OVMF BLOB. Incoming live migrations have their OVMF_CODE image in a RAMBlock[1], and only load the new image on a warm re

[pve-devel] [RFC pve-qemu] drop OVMF binaries

we moved this out to the pve-edk2-firmware package, which allows us to build OVMF from source rather than tracking binary files. This breaks older qemu-server versions, so add a Break to d/control Signed-off-by: Thomas Lamprecht --- debian/Logo.bmp | Bin 49078 -> 0 bytes debian/OV

[pve-devel] [RFC edk2-firmware] Initial commit

Currently builds OVMF in a simmilar fashion the Debian package does, we just focus on a x86_64 build for now, disable secure boot (was disabled in our binary images from pve-qemu, it needs a static build of an specific version of OpenSSL, bit of an headache) and has our Logo for the boot splash. S

[pve-devel] [PATCH container] Fix pct skiplock

The method vm_start sets an environment variable that is not picked up anymore by systemd. This patch keeps the environment variable and introduces a skiplock file that is picked up by the lxc-pve-prestart-hook. Signed-off-by: Alwin Antreich --- src/PVE/LXC.pm| 9 - src/lxc-p

Re: [pve-devel] [PATCH container] Fix pct skiplock

On 03/13/2018 05:20 PM, Alwin Antreich wrote: > The method vm_start sets an environment variable that is not picked up > anymore by systemd. This patch keeps the environment variable and > introduces a skiplock file that is picked up by the > lxc-pve-prestart-hook. > > Signed-off-by: Alwin Antreic