some high-level feedback:
- looks much better than previous version already, I think v3 should be
the one that makes it :)
- just upgrading triggers the following error on order/renew:
Loading ACME account details
Placing ACME order
Order URL: https://acme-staging-v02.api.letsencrypt.org/acme/
On 10/23/19 9:37 AM, Fabian Grünbichler wrote:
LGTM in general, comments inline
On October 23, 2019 8:38 am, Wolfgang Link wrote:
Files:
./src/PVE/..--> /usr/share/perl5/PVE/..
./src/PVE/ACME.pm
./src/PVE/ACME/Challenge.pm
./src/PVE/ACME/Standalone.pm
./src/PVE/ACME/DNS.p
On October 21, 2019 12:11 pm, Wolfgang Link wrote:
> comment inline
>
> On 10/18/19 11:28 AM, Fabian Grünbichler wrote:
>> so this got a bit longer than expected - just a high-level feedback, I
>> haven't actually tested anything yet since there are too many open
>> general design questions for th
comment inline
On 10/18/19 11:28 AM, Fabian Grünbichler wrote:
so this got a bit longer than expected - just a high-level feedback, I
haven't actually tested anything yet since there are too many open
general design questions for that to make sense.
On October 14, 2019 1:08 pm, Wolfgang Link wr
so this got a bit longer than expected - just a high-level feedback, I
haven't actually tested anything yet since there are too many open
general design questions for that to make sense.
On October 14, 2019 1:08 pm, Wolfgang Link wrote:
> This series also includes a new GIT repository on proxdev