Re: [pve-devel] [zsync] fix: check for incremental sync snapshot.

2020-03-19 Thread Fabian Ebner
Hi, this does fix an issue when the receiving side has the most recent snapshot, but not the 'old_snap' one. And of course testing for 'last_snap' is correct, since that one is the relevant one for the incremental sync. With that: Reviewed-By: Fabian Ebner Tested-By: Fabian Ebner Some idea

Re: [pve-devel] [zsync] fix: check for incremental sync snapshot.

2020-03-18 Thread Wolfgang Link
The call to the zfs list contains the snapshot. If the snapshot does not exist, the command is returned with an error that we are catching. > On March 18, 2020 8:02 AM Dietmar Maurer wrote: > > > Why does the patch ignore the output from the command? > > > On March 18, 2020 7:51 AM Wolfgang

Re: [pve-devel] [zsync] fix: check for incremental sync snapshot.

2020-03-18 Thread Dietmar Maurer
Why does the patch ignore the output from the command? > On March 18, 2020 7:51 AM Wolfgang Link wrote: > > > For an incremental sync you need the last_snap on both sides. > --- > pve-zsync | 13 - > 1 file changed, 4 insertions(+), 9 deletions(-) > > diff --git a/pve-zsync b/pve