Re: [pve-devel] [PATCH v3 0/13] Fix: #2124 zstd

2020-04-09 Thread Alwin Antreich
On Thu, Apr 09, 2020 at 02:29:46PM +0200, Fabian Ebner wrote: > Hi, > series looks mostly good to me. Some comments on individual patches. > Backup/restore seems to work, also still with the other compression formats. > The tests for path_to_volume_id actually uncover a bug and a missing feature >

Re: [pve-devel] [PATCH v3 0/13] Fix: #2124 zstd

2020-04-09 Thread Fabian Ebner
Hi, series looks mostly good to me. Some comments on individual patches. Backup/restore seems to work, also still with the other compression formats. The tests for path_to_volume_id actually uncover a bug and a missing feature in the implementation in Storage.pm, which should be fixed. For th