Re: [pve-devel] proxmox install script

2017-08-16 Thread Fabian Grünbichler
On Wed, Aug 16, 2017 at 11:35:22AM +0200, Nils Privat wrote: > i got some questions about the proxmox-install-script: > https://git.proxmox.com/?p=pve-installer.git;a=blob_plain;f=proxinstall;hb=HEAD > > 1) line 21: should be 5.0 ? true, but that var is only used for testmode during development (

[pve-devel] proxmox install script

2017-08-16 Thread Nils Privat
i got some questions about the proxmox-install-script: https://git.proxmox.com/?p=pve-installer.git;a=blob_plain;f=proxinstall;hb=HEAD 1) line 21: should be 5.0 ? 2) line 781: small typo 'install' 3) A question regarding function "zfs_create_rpool" (line 761): Wouldn't it be better to define/chec