Re: [pve-devel] ZFS Storage Patches

2014-06-25 Thread Dietmar Maurer
applied, thanks! > My submission was rejected previously because I was not a member of pve- > devel mailing list.  I added myself to this list and I'm now re-submitting my > patches. ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxm

Re: [pve-devel] ZFS Storage Patches

2014-03-18 Thread Michael Rasmussen
On Tue, 18 Mar 2014 10:00:48 -0700 Chris Allen wrote: > > Michael, I can't seem to recreate this. I converted a VM with the sparse > option to a template and created a linked clone, and then backed up the > linked clone and didn't get this error message. This is a log of my linked > clone bac

Re: [pve-devel] ZFS Storage Patches

2014-03-18 Thread Chris Allen
> Your patch still needs to handle the case where a VM has been converted > to a template since image handling after conversion complains of an > unknown setting: sparse. Michael, I can't seem to recreate this. I converted a VM with the sparse option to a template and created a linked clone, and

Re: [pve-devel] ZFS Storage Patches

2014-03-17 Thread Chris Allen
> It might be worth trying to make a feature request to the qemu-img team to add this option? I'll pursue getting this feature added to qemu-img. > Your patch still needs to handle the case where a VM has been converted > to a template since image handling after conversion complains of an > unkno

Re: [pve-devel] ZFS Storage Patches

2014-03-17 Thread Michael Rasmussen
On Mon, 17 Mar 2014 11:08:41 -0700 Chris Allen wrote: > > Connecting to the target with a host group defined fails unless the > initiator has been added to the host group, as it should be by design. If > I manually add the initiator name ("iqn.2008-11.org.linux-kvm:") > to the host group on the

Re: [pve-devel] ZFS Storage Patches

2014-03-17 Thread Chris Allen
Michael, Thanks for testing these. If I supply you with future patches I'll try to be a little bit more rigorous with testing before I send them in. Connecting to the target with a host group defined fails unless the initiator has been added to the host group, as it should be by design. If I m

Re: [pve-devel] ZFS Storage Patches

2014-03-15 Thread Michael Rasmussen
On Sat, 15 Mar 2014 16:26:46 -0700 Chris Allen wrote: > Michael, > > Bummer, sorry it's not working. When I'm back in the office on Monday, > I'll play with it. I've been using it with a defined target group and no > host group so far without any problems. I have not tested a host group. I >

Re: [pve-devel] ZFS Storage Patches

2014-03-15 Thread Chris Allen
Michael, Bummer, sorry it's not working. When I'm back in the office on Monday, I'll play with it. I've been using it with a defined target group and no host group so far without any problems. I have not tested a host group. I mainly wanted to be able to define a target group, because the stor

Re: [pve-devel] ZFS Storage Patches

2014-03-15 Thread Michael Rasmussen
On Sat, 15 Mar 2014 21:22:20 +0100 Michael Rasmussen wrote: > So a request like this: > qemu-img info iscsi://192.168.3.110/iqn.2010-09.org.napp-it:omnios/0 > > Will give this response: > qemu-img: iSCSI: Failed to connect to LUN : SENSE > KEY:ILLEGAL_REQUEST(5) ASCQ:INVALID_OPERATION_CODE(0x200

Re: [pve-devel] ZFS Storage Patches

2014-03-15 Thread Michael Rasmussen
Hi Chris, How have you been able to use your patch adding host and target group? As far as I have been able to test these options are never send with the request for access to the LUN. So a request like this: qemu-img info iscsi://192.168.3.110/iqn.2010-09.org.napp-it:omnios/0 Will give this res

Re: [pve-devel] ZFS Storage Patches

2014-03-14 Thread Michael Rasmussen
On Fri, 14 Mar 2014 12:24:10 -0700 Chris Allen wrote: > Oops forgot to attach the script. Here's the script I mentioned. > I have added this line so that my MUA can sort the mail correct: msg += 'Date: %s \n' % time.strftime("%a, %d %b %Y %X %z") -- Hilsen/Regards Michael Rasmussen Get my pu

Re: [pve-devel] ZFS Storage Patches

2014-03-14 Thread Michael Rasmussen
On Fri, 14 Mar 2014 12:24:10 -0700 Chris Allen wrote: > Oops forgot to attach the script. Here's the script I mentioned. > Thanks. -- Hilsen/Regards Michael Rasmussen Get my public GnuPG keys: michael rasmussen cc http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xD3C9A00E mir datanom n

Re: [pve-devel] ZFS Storage Patches

2014-03-14 Thread Michael Rasmussen
On Fri, 14 Mar 2014 12:21:43 -0700 Chris Allen wrote: > 8k for me too is much better than 4k. With 4k I tend to hit my IOPS limit > easily, with not much throughput, and I get a lot of IO delay on VMs when > the SAN is fairly busy. Currently I'm leaning towards 16k, sparse, with > lz4 compressi

Re: [pve-devel] ZFS Storage Patches

2014-03-14 Thread Chris Allen
Oops forgot to attach the script. Here's the script I mentioned. On Fri, Mar 14, 2014 at 12:21 PM, Chris Allen wrote: > > I have already made some test and I have not be able to make any > > conclusive tests proving performance should be hurt by using sparse. > > Yeah it shouldn't affect the Z

Re: [pve-devel] ZFS Storage Patches

2014-03-14 Thread Chris Allen
> I have already made some test and I have not be able to make any > conclusive tests proving performance should be hurt by using sparse. Yeah it shouldn't affect the ZFS mechanics at all, the ZVOL will just lack a reservation. > Is sparse a way to provision more than a 100% then? Yes. That, an

Re: [pve-devel] ZFS Storage Patches

2014-03-14 Thread Michael Rasmussen
On Fri, 14 Mar 2014 10:11:17 -0700 Chris Allen wrote: > > It was also part of latest 3.1. Double-click the mouse over your > > storage specification in Datacenter->storage and the panel pops up. > > Patched panel attached. > I forgot to mention that at the moment the code for creating ZFS storag

Re: [pve-devel] ZFS Storage Patches

2014-03-14 Thread Chris Allen
> It was also part of latest 3.1. Double-click the mouse over your > storage specification in Datacenter->storage and the panel pops up. > Patched panel attached. Thank you, I was unaware of this. > BTW. Have you made any performance measures sparse vs non-sparse and > write cache vs no write ca

Re: [pve-devel] ZFS Storage Patches

2014-03-13 Thread Michael Rasmussen
On Thu, 13 Mar 2014 11:45:52 -0700 Chris Allen wrote: > Yes. Thanks for including the patches. I was unaware of ZFSEdit.js as I > wasn't testing this on new version of pve-manager (I was using 3.1 release). > It was also part of latest 3.1. Double-click the mouse over your storage specificatio

Re: [pve-devel] ZFS Storage Patches

2014-03-13 Thread Chris Allen
Yes. Thanks for including the patches. I was unaware of ZFSEdit.js as I wasn't testing this on new version of pve-manager (I was using 3.1 release). On Thu, Mar 13, 2014 at 11:09 AM, Michael Rasmussen wrote: > > On Wed, 12 Mar 2014 10:14:02 -0700 > Chris Allen wrote: > > > My submission was

Re: [pve-devel] ZFS Storage Patches

2014-03-13 Thread Michael Rasmussen
On Wed, 12 Mar 2014 10:14:02 -0700 Chris Allen wrote: > My submission was rejected previously because I was not a member of > pve-devel mailing list. I added myself to this list and I'm now > re-submitting my patches. > I have just briefly looked over the patch and can see that some patching

Re: [pve-devel] ZFS Storage Patches

2014-03-13 Thread Alexandre DERUMIER
Thanks, I don't have time myself to test them. (I review them fastly, seem to be good) - Mail original - De: "Michael Rasmussen" À: "Dietmar Maurer" Cc: pve-devel@pve.proxmox.com Envoyé: Jeudi 13 Mars 2014 08:09:52 Objet: Re: [pve-devel] ZFS Storage Patches

Re: [pve-devel] ZFS Storage Patches

2014-03-13 Thread Michael Rasmussen
Hi Dietmar, On Thu, 13 Mar 2014 07:00:10 + Dietmar Maurer wrote: > > would you mind to review and test those patches? You are the author of the > ZFS plugin, > so I guess it is best if you do the review. > I will do the testing tomorrow or Saturday. -- Hilsen/Regards Michael Rasmussen

Re: [pve-devel] ZFS Storage Patches

2014-03-13 Thread Dietmar Maurer
Subject: [pve-devel] ZFS Storage Patches My submission was rejected previously because I was not a member of pve-devel mailing list. I added myself to this list and I'm now re-submitting my patches. ___ pve-devel mailing list pve-devel@pve.proxmo

Re: [pve-devel] ZFS Storage Patches

2014-03-12 Thread Pablo Ruiz
Hi Chris, I am working on a refactor of ZFS Plugin which will decouple specific LUN implementations from the driver, by providing a single interface for LUN implementation by means of invoking an external script/program/binary. As such, I will try to review your patches and incorporate "what is no

[pve-devel] ZFS Storage Patches

2014-03-12 Thread Chris Allen
My submission was rejected previously because I was not a member of pve-devel mailing list. I added myself to this list and I'm now re-submitting my patches. From 753d826597851ef8bd55b7359ff7ee1c5b579920 Mon Sep 17 00:00:00 2001 From: Chris Allen Date: Fri, 28 Feb 2014 23:56:02 -0800 Subject: [PA