Re: [pve-devel] PATCH: Add support for bridges with more than one physical link.

2014-03-18 Thread Dietmar Maurer
> Now that 3.2 is out, did you find the time to finally review/merge this patch > series Sorry for the delay, I am still in bug fixing mode ;-) Just applied your patches (+one fix for undefined var $ifcount). Please can you test if that still works? https://git.proxmox.com/?p=pve-common.git;a=s

Re: [pve-devel] PATCH: Add support for bridges with more than one physical link.

2014-02-12 Thread Andrew Thrift
Correct in your case, but not all Proxmox users have MSTP/PVST+ configured. A much lower risk strategy is to use Multi-Chassis Link Aggregation Groups between Switch-A and Switch-B with a 4 port "bond" on the Proxmox hosts, using a L3/L4 hash you will achieve better load balancing of traffic acros

Re: [pve-devel] PATCH: Add support for bridges with more than one physical link.

2014-02-12 Thread Pablo Ruiz
Nevertheless, thanks for the comment. Especially since this maybe of interest to future readers, as as you guessed, this setup is not for everybody, as it requires specific networking knowledge in order to avoid issues.. (Althought this is same advice seems to be applicable to many software setups/

Re: [pve-devel] PATCH: Add support for bridges with more than one physical link.

2014-02-12 Thread Pablo Ruiz
That's what MSTP/PVSTP+ is supposed to avoid. (And infact, it does so in our environment).. however, it requires switches with such capability. On Wed, Feb 12, 2014 at 9:53 AM, Andrew Thrift wrote: > While this is a very neat way to load balance vlan traffic, it could be > dangerous. > > You are

Re: [pve-devel] PATCH: Add support for bridges with more than one physical link.

2014-02-12 Thread Andrew Thrift
While this is a very neat way to load balance vlan traffic, it could be dangerous. You are effectively allowing users to create a loop. Unless they have their switches and spanning tree configured correctly upstream of the host, they could create a large broadcast storm on their network, likely kn

Re: [pve-devel] PATCH: Add support for bridges with more than one physical link.

2014-02-11 Thread Dietmar Maurer
: Mittwoch, 12. Februar 2014 08:43 To: Dietmar Maurer Cc: pve-devel@pve.proxmox.com Subject: Re: [pve-devel] PATCH: Add support for bridges with more than one physical link. Hi Dietmar, Here goes an v2 with you requested changes. Just tested it on briefly by rebooting nodes and migrating a cou

Re: [pve-devel] PATCH: Add support for bridges with more than one physical link.

2014-02-11 Thread Pablo Ruiz
Hi Dietmar, Here goes an v2 with you requested changes. Just tested it on briefly by rebooting nodes and migrating a couple of VMs from/to the nodes with this new changes applied. diff --git a/data/PVE/Network.pm b/data/PVE/Network.pm index 9ad34f1..2fbb715 100644 --- a/data/PVE/Network.pm +++ b/

Re: [pve-devel] PATCH: Add support for bridges with more than one physical link.

2014-02-11 Thread Dietmar Maurer
see comment below: > +sub activate_bridge_vlan { > +my ($bridge, $tag_param) = @_; > + > +die "bridge '$bridge' is not active\n" if ! -d "/sys/class/net/$bridge"; > + > +return $bridge if !defined($tag_param); # no vlan, simply return > + > +my $tag = int($tag_param); > + > +di

Re: [pve-devel] PATCH: Add support for bridges with more than one physical link.

2014-02-11 Thread Pablo Ruiz
Sure ;) diff --git a/data/PVE/Network.pm b/data/PVE/Network.pm index 9ad34f1..96cf20b 100644 --- a/data/PVE/Network.pm +++ b/data/PVE/Network.pm @@ -122,36 +122,10 @@ sub copy_bridge_config { } } -sub activate_bridge_vlan { -my ($bridge, $tag_param) = @_; - -die "bridge '$bridge' is

Re: [pve-devel] PATCH: Add support for bridges with more than one physical link.

2014-02-11 Thread Pablo Ruiz
Btw, I've included a link to the first commit only. Full branch with feature can be found at: https://github.com/pruiz/pve-common/tree/bridge-multislave On Wed, Feb 12, 2014 at 6:28 AM, Pablo Ruiz wrote: > Hi, > > In our proxmox cluster, each node has two bond interfaces, and each bond > interf

Re: [pve-devel] PATCH: Add support for bridges with more than one physical link.

2014-02-11 Thread Dietmar Maurer
> We would like to have this enhacement merged into proxmox, and so I've read > about proxmox development policies, etc. And as stated here is the link > containing a diff format patch: https://github.com/pruiz/pve- > common/commit/ce0173a1079e4fc8bb08d9eebd1df71f0f8dc3fe.diff aswell as > the prett

[pve-devel] PATCH: Add support for bridges with more than one physical link.

2014-02-11 Thread Pablo Ruiz
Hi, In our proxmox cluster, each node has two bond interfaces, and each bond interface connects to and independent switch. This allows us to enable MSTP/PVSTP+ and thus load share traffic on different vlans across switches. +==+