Re: [pve-devel] 3 numa topology issues

2016-07-28 Thread Alexandre DERUMIER
; if ! -d "/sys/devices/system/node/node$i/" && $conf->{hugepages); - Mail original - De: "Wolfgang Bumiller" À: "aderumier" Cc: "pve-devel" Envoyé: Jeudi 28 Juillet 2016 09:24:58 Objet: Re: [pve-devel] 3 numa topology issues On Thu, Ju

Re: [pve-devel] 3 numa topology issues

2016-07-28 Thread Wolfgang Bumiller
On Thu, Jul 28, 2016 at 08:44:47AM +0200, Alexandre DERUMIER wrote: > I'm looking at openstack implementation > > https://specs.openstack.org/openstack/nova-specs/specs/juno/implemented/virt-driver-numa-placement.html > > and it seem that they check if host numa nodes exist too > > > "hw:numa_n

Re: [pve-devel] 3 numa topology issues

2016-07-27 Thread Alexandre DERUMIER
Envoyé: Mercredi 27 Juillet 2016 11:38:04 Objet: Re: [pve-devel] 3 numa topology issues >>I believe we can simply remove this line since qemu allows it and just >>applies its default policy. Alternatively we can keep a counter and >>apply host-nodes manually, starting over at 0

Re: [pve-devel] 3 numa topology issues

2016-07-27 Thread Alexandre DERUMIER
>>I believe we can simply remove this line since qemu allows it and just >>applies its default policy. Alternatively we can keep a counter and >>apply host-nodes manually, starting over at 0 when we run out of nodes, >>but that's no better than letting qemu do this. Well, I don't known how auto nu

Re: [pve-devel] 3 numa topology issues

2016-07-27 Thread Wolfgang Bumiller
> On July 26, 2016 at 2:18 PM Alexandre DERUMIER wrote: > > > > >>Issue #1: The above code currently does not honor our 'hostnodes' option > > >>and breaks when trying to use them together. > > Also I need to check how to allocated hugepage, when hostnodes is defined > with range like : "ho

Re: [pve-devel] 3 numa topology issues

2016-07-26 Thread Alexandre DERUMIER
> >>Issue #1: The above code currently does not honor our 'hostnodes' option > >>and breaks when trying to use them together. Also I need to check how to allocated hugepage, when hostnodes is defined with range like : "hostnodes:0-1". >>Useless, yes, which is why I'm wondering whether this

Re: [pve-devel] 3 numa topology issues

2016-07-26 Thread Wolfgang Bumiller
On Tue, Jul 26, 2016 at 01:35:50PM +0200, Alexandre DERUMIER wrote: > Hi Wolfgang, > > I just come back from holiday. Hope you had a good time :-) > > > > >>Issue #1: The above code currently does not honor our 'hostnodes' option > >>and breaks when trying to use them together. > > mmm ind

Re: [pve-devel] 3 numa topology issues

2016-07-26 Thread Alexandre DERUMIER
Hi Wolfgang, I just come back from holiday. >>Issue #1: The above code currently does not honor our 'hostnodes' option >>and breaks when trying to use them together. mmm indeed. I think this can be improved. I'll try to check that next week. >>Issue #2: We create one node per *virtual* so

[pve-devel] 3 numa topology issues

2016-07-26 Thread Wolfgang Bumiller
Currently we have the following code in hugepages_topology(): |for (my $i = 0; $i < $MAX_NUMA; $i++) { |next if !$conf->{"numa$i"}; |my $numa = PVE::QemuServer::parse_numa($conf->{"numa$i"}); (...) |$hugepages_topology->{$hugepages_size}->{$i} += hugepages_nr($numa_mem