Re: [pve-devel] [RFC v2 pve-container 4/4] vzdump: refactor LXC backup

2015-09-07 Thread Dietmar Maurer
This is really too much for a single commit. You do - function signature changes (without obvious reason). - code cleanups (white space removals) - use new features like command_pipe() - add optimizations (rsync parameters) - change current behavior (use tar exclusions) ... I would like to have

[pve-devel] [RFC v2 pve-container 4/4] vzdump: refactor LXC backup

2015-09-07 Thread Wolfgang Bumiller
*) Use the new Tools::command_pipe instead of building a shell command string. *) Ditch 'find' and utilize the --one-file-system switch instead. *) Added mountpoint handling *) Added support for 'backup=yes|no' on mountpoints *) sanitizing mountpoint paths --- src/PVE/VZDump/LXC.pm | 195 +++