Re: [pve-devel] [Patch V2 acme 10/12] Refactor extract_callenge for code reuse.

order between this and 9 is wrong, and this introduces a circular dependency. extract_challenge would probably need to go into Challenge.pm? that way, new challenge types that don't need this/do it differently can override it as well.. On March 31, 2020 12:08 pm, Wolfgang Link wrote: > Signed-o

[pve-devel] [Patch V2 acme 10/12] Refactor extract_callenge for code reuse.

Signed-off-by: Wolfgang Link --- src/PVE/ACME.pm| 15 +++ src/PVE/ACME/StandAlone.pm | 2 ++ 2 files changed, 17 insertions(+) diff --git a/src/PVE/ACME.pm b/src/PVE/ACME.pm index c10dca2..7c0794a 100644 --- a/src/PVE/ACME.pm +++ b/src/PVE/ACME.pm @@ -573,4 +573,19 @@ su