Re: [pve-devel] [PATCH v9 0/6] Add basics for custom CPU models

2020-04-06 Thread Thomas Lamprecht
On 4/6/20 3:01 PM, Stefan Reiter wrote: > On 06/04/2020 14:42, Fabian Ebner wrote: >> Hi, >> >> reviewed this series today. It's my first time looking at all the CPU >> related code, so I'm not sure I understood all the details. >> >> The patches work as described (patch #2 even does more ;) and I

Re: [pve-devel] [PATCH v9 0/6] Add basics for custom CPU models

2020-04-06 Thread Stefan Reiter
On 06/04/2020 14:42, Fabian Ebner wrote: Hi, reviewed this series today. It's my first time looking at all the CPU related code, so I'm not sure I understood all the details. The patches work as described (patch #2 even does more ;) and I do have 2 minor comments/suggestions on the individua

Re: [pve-devel] [PATCH v9 0/6] Add basics for custom CPU models

2020-04-06 Thread Fabian Ebner
Hi, reviewed this series today. It's my first time looking at all the CPU related code, so I'm not sure I understood all the details. The patches work as described (patch #2 even does more ;) and I do have 2 minor comments/suggestions on the individual patches. And needs to be rebased on cur

[pve-devel] [PATCH v9 0/6] Add basics for custom CPU models

2020-03-26 Thread Stefan Reiter
Based on the RFC and following on- and off-list discussion about custom CPU models [0]. In essence, this revised patch allows a user to specify custom CPU models in /etc/pve/cpu-models.conf (section-config style [1]), where VMs using that CPU model inherit details from the definition. This removes