On Wed, 21 Jun 2017 15:58:13 +0200
Fabian Grünbichler wrote:
> > +die $res->code."\n" unless $res->is_success;
>
> this deviates from v5 - now you die with the HTTP error code, and not
> with the full status message (except for in freenas_create_target_group
> and freenas_create_target) -
> In my book your stile is bad Perl which is more C or Java stile instead.
> This is something that old Perl programmers will agree to
I guess we are all C programmers, and that is why we like C style. I think
it is also more easy to read for non-perl programmers.
Hi Fabian,
On Wed, 21 Jun 2017 15:58:13 +0200
Fabian Grünbichler wrote:
>
> high level question #1: how do you guarantee that inbetween pagination
> requests, the underlying lists/.. on the freenas side don't change
> because of concurrent actions?
>
> getting outdated information altogether i
On Tue, Jun 20, 2017 at 10:39:54PM +0200, m...@datanom.net wrote:
> From: Michael Rasmussen
>
> Signed-off-by: Michael Rasmussen
> ---
> PVE/Storage/FreeNASPlugin.pm | 415
> +++
> 1 file changed, 415 insertions(+)
>
> diff --git a/PVE/Storage/FreeNASPl
From: Michael Rasmussen
Signed-off-by: Michael Rasmussen
---
PVE/Storage/FreeNASPlugin.pm | 415 +++
1 file changed, 415 insertions(+)
diff --git a/PVE/Storage/FreeNASPlugin.pm b/PVE/Storage/FreeNASPlugin.pm
index cf33e68..a50a2f6 100644
--- a/PVE/Storag
