On 4/16/20 10:07 AM, Fabian Grünbichler wrote:
> On April 16, 2020 8:57 am, Dominik Csapak wrote:
>> bottom line: i guess both are ok when used right, but with
>> [0-9] there is no ambiguity as to what it matches
>>
>
> fine for me as well (I prefer \d for readability/shortness, but I don't
> car
On April 16, 2020 8:57 am, Dominik Csapak wrote:
>
>>
>>
>> Thanks for clearing that up, I mostly poked at it as Dominic came to me
>> asking what to do as you told him to use [0-9] and Fabian told him to go
>> back again, not knowing about your suggestion.
>>
>> The question is, does the match
On 4/16/20 9:35 AM, Thomas Lamprecht wrote:
On 4/16/20 8:57 AM, Dominik Csapak wrote:
Thanks for clearing that up, I mostly poked at it as Dominic came to me
asking what to do as you told him to use [0-9] and Fabian told him to go
back again, not knowing about your suggestion.
The questi
On 4/16/20 8:57 AM, Dominik Csapak wrote:
>
>>
>>
>> Thanks for clearing that up, I mostly poked at it as Dominic came to me
>> asking what to do as you told him to use [0-9] and Fabian told him to go
>> back again, not knowing about your suggestion.
>>
>> The question is, does the matching of oth
Thanks for clearing that up, I mostly poked at it as Dominic came to me
asking what to do as you told him to use [0-9] and Fabian told him to go
back again, not knowing about your suggestion.
The question is, does the matching of other digit really matters at all?
I mean it naturally depend
On 4/16/20 7:41 AM, Dominik Csapak wrote:
> wanted to chime in here (since i believe the original comment
> about unicode literals came from me)
>
> On 4/15/20 5:02 PM, Thomas Lamprecht wrote:
>> albeit I'm not to sure if the unicode stuff is really true, I tried:
>> perl -we '"Ⅲ" =~ /\d/ or die "
wanted to chime in here (since i believe the original comment
about unicode literals came from me)
On 4/15/20 5:02 PM, Thomas Lamprecht wrote:
albeit I'm not to sure if the unicode stuff is really true, I tried:
perl -we '"Ⅲ" =~ /\d/ or die "no match"'
where "Ⅲ" is the roman numeral three (U+21
On 4/15/20 2:41 PM, Dominic Jäger wrote:
> Thank you for taking a look!
> Most makes sense to me and is already changed.
>
> On Wed, Apr 15, 2020 at 11:28:34AM +0200, Fabian Grünbichler wrote:
>>
>>> + if ($max_amount !~ /^[0-9]+$/);
>>
>> \d instead of [0-9]
>
> This was \d previously. However
Thank you for taking a look!
Most makes sense to me and is already changed.
On Wed, Apr 15, 2020 at 11:28:34AM +0200, Fabian Grünbichler wrote:
>
> > + if ($max_amount !~ /^[0-9]+$/);
>
> \d instead of [0-9]
This was \d previously. However, it was recommended to me to change it to [0-9]
in v2
some style/design nits below
On March 11, 2020 2:05 pm, Dominic Jäger wrote:
> Move wipe_disks from PVE::Ceph::Tools to PVE::Diskmanage and improve it by
> - Handling invalid parameters
> - Adding options for wiping
> - Making names clearer
> - Adding tests
>
> Relies on the corresponding pat
Move wipe_disks from PVE::Ceph::Tools to PVE::Diskmanage and improve it by
- Handling invalid parameters
- Adding options for wiping
- Making names clearer
- Adding tests
Relies on the corresponding patch in pve-manager.
Signed-off-by: Dominic Jäger
---
v2->v3:
- Relative instead of full pa
11 matches
Mail list logo
