Re: [pve-devel] [PATCH v3 manager 1/3] add pveceph install to shell api

2019-01-23 Thread Fabian Grünbichler
meta: it might still make sense to have all those identical options only defined once (e.g., in a local variable in this module) to prevent unnecessary churn when adding new commands. ideally, we would also pull out the mapping from 'cmd' value to actual command array, so that we only need to upd

[pve-devel] [PATCH v3 manager 1/3] add pveceph install to shell api

2019-01-22 Thread Tim Marx
Signed-off-by: Tim Marx --- changed since v2: * removed get_standard_option PVE/API2/Nodes.pm | 30 ++ 1 file changed, 30 insertions(+) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index 7f829b29..04fc4f08 100644 --- a/PVE/API2/Nodes.pm +++ b/PVE/API2/Nodes.pm