Re: [pve-devel] [PATCH v3 0/3] Support all 8 corosync3 links in GUI

2020-04-21 Thread Dominik Csapak
tested around and found nothing wrong with it also glanced over the code and it looks ok (eslint throws a few errors/warnings, but since we did not write up a style guideline,etc. yet, this is ok) On 3/23/20 1:41 PM, Stefan Reiter wrote: v2 -> v3: * add patch 1 (localization fix) * implement cha

Re: [pve-devel] [PATCH v3 0/3] Support all 8 corosync3 links in GUI

2020-04-21 Thread Thomas Lamprecht
On 4/21/20 10:56 AM, Dominik Csapak wrote: > hi, > > yeah sorry, did not get around to it, but i could look at it today/tomorrow > > @Thomas is that ok or do you want to take a look? > I have it half applied here, now that the displayedit field is there and packaged I can finally get out of by

Re: [pve-devel] [PATCH v3 0/3] Support all 8 corosync3 links in GUI

2020-04-21 Thread Dominik Csapak
hi, yeah sorry, did not get around to it, but i could look at it today/tomorrow @Thomas is that ok or do you want to take a look? On 4/21/20 10:54 AM, Stefan Reiter wrote: ping, I think we'd want this in 6.2? On 23/03/2020 13:41, Stefan Reiter wrote: v2 -> v3: * add patch 1 (localization fix

Re: [pve-devel] [PATCH v3 0/3] Support all 8 corosync3 links in GUI

2020-04-21 Thread Stefan Reiter
ping, I think we'd want this in 6.2? On 23/03/2020 13:41, Stefan Reiter wrote: v2 -> v3: * add patch 1 (localization fix) * implement changes from Dominik's review: * use 'let' in new code * use references for element lookup * some code style nits * fix formatting (simpler in general

[pve-devel] [PATCH v3 0/3] Support all 8 corosync3 links in GUI

2020-03-23 Thread Stefan Reiter
v2 -> v3: * add patch 1 (localization fix) * implement changes from Dominik's review: * use 'let' in new code * use references for element lookup * some code style nits * fix formatting (simpler in general with hbox, and also should work for all languages now) * fix IPv6 address selec