Re: [pve-devel] [PATCH v2 manager 1/2] vzdump: make guest include logic testable

2020-06-05 Thread Aaron Lauterer
On 6/3/20 4:35 PM, Thomas Lamprecht wrote: On 5/4/20 4:08 PM, Aaron Lauterer wrote: [...] +sub get_included_guests { +my ($self, $job) = @_; do we need $self here? Why not call it like: PVE::VZDump::get_included_guests($params) ? You're right. No need for it AFAICT + +my $n

Re: [pve-devel] [PATCH v2 manager 1/2] vzdump: make guest include logic testable

2020-06-03 Thread Thomas Lamprecht
On 5/4/20 4:08 PM, Aaron Lauterer wrote: > As a first step to make the whole guest include logic more testable the > part from the API endpoint has been moved to its own method with as > little changes as possible. > > Everything concerning `all` and `exclude` logic is still in the > PVE::VZDump->

[pve-devel] [PATCH v2 manager 1/2] vzdump: make guest include logic testable

2020-05-04 Thread Aaron Lauterer
As a first step to make the whole guest include logic more testable the part from the API endpoint has been moved to its own method with as little changes as possible. Everything concerning `all` and `exclude` logic is still in the PVE::VZDump->exec_backup() method. Signed-off-by: Aaron Lauterer