Re: [pve-devel] [PATCH v2 manager] gui: add revert button for lxc pending changes

2019-10-29 Thread Dominik Csapak
looks mostly good to me, after a bit of search i found that the reason for the delayed update is that we/you queried the wrong store the rstore in the context is the 'real store' which triggered the update of the 'diffstore' that showed the changes the sequence was: * api call * update of rstor

[pve-devel] [PATCH v2 manager] gui: add revert button for lxc pending changes

2019-10-28 Thread Oguz Bektas
adds the pending button for Resources, Options and DNS screens. Signed-off-by: Oguz Bektas --- v1 -> v2: * fix typo * use 'datachanged' to track the status of the buttons, however: for some reason it takes a while to refresh the status of the button, also same on the qemu side so this is likely