Re: [pve-devel] [PATCH v2 container] don't duplicate lxc.idmap entries during restore

2019-09-30 Thread Oguz Bektas
seems good to me. (note: maybe send in again as separate mail? had to edit the mail because commit message wasn't picked up right and apply with --ignore-whitespace) Tested-by: Oguz Bektas On Wed, Sep 25, 2019 at 02:37:32PM +0200, Fabian Grünbichler wrote: > On September 25, 2019 1:30 pm, Oguz B

Re: [pve-devel] [PATCH v2 container] don't duplicate lxc.idmap entries during restore

2019-09-25 Thread Fabian Grünbichler
On September 25, 2019 1:30 pm, Oguz Bektas wrote: > merging $conf->{lxc} causes lxc.idmap entries to be duplicated in the > restored configuration. instead, we can overwrite the contents from the > extracted configuration file. this way we don't duplicate these entries. > (having duplicate idmap en

[pve-devel] [PATCH v2 container] don't duplicate lxc.idmap entries during restore

2019-09-25 Thread Oguz Bektas
merging $conf->{lxc} causes lxc.idmap entries to be duplicated in the restored configuration. instead, we can overwrite the contents from the extracted configuration file. this way we don't duplicate these entries. (having duplicate idmap entries causes container to crash during start) Co-develope