Re: [pve-devel] [PATCH storage] ZFS: mount subvols in activate_volume

2020-04-22 Thread Wolfgang Bumiller
On Wed, Apr 22, 2020 at 11:28:36AM +0200, Thomas Lamprecht wrote: > On 4/22/20 10:30 AM, Fabian Ebner wrote: > > Turns out that this alone doesn't make starting containers with an > > unmounted zfs subvolume working. But "pct clone" and "pct mount" can still > > benefit from this patch. The probl

Re: [pve-devel] [PATCH storage] ZFS: mount subvols in activate_volume

2020-04-22 Thread Thomas Lamprecht
On 4/22/20 10:30 AM, Fabian Ebner wrote: > Turns out that this alone doesn't make starting containers with an unmounted > zfs subvolume working. But "pct clone" and "pct mount" can still benefit from > this patch. The problem for starting a container is that when we call > PVE::Storage::activate

Re: [pve-devel] [PATCH storage] ZFS: mount subvols in activate_volume

2020-04-22 Thread Fabian Ebner
Turns out that this alone doesn't make starting containers with an unmounted zfs subvolume working. But "pct clone" and "pct mount" can still benefit from this patch. The problem for starting a container is that when we call PVE::Storage::activate_volumes, it happens inside the lxc-pve-prestart

[pve-devel] [PATCH storage] ZFS: mount subvols in activate_volume

2020-04-21 Thread Fabian Ebner
This makes containers work even if the subvolumes are not already mounted beforehand for some reason. Without this patch, container could quietly fail for e.g. start and full clone, because bind-mounting still "worked" on the empty directory. Signed-off-by: Fabian Ebner --- This can be seen as a