Re: [pve-devel] [PATCH qemu 2/2] Fix backup for not 64k-aligned storages

2020-06-23 Thread Roland Kammerer
On Mon, Jun 22, 2020 at 02:54:02PM +0200, Stefan Reiter wrote: > Zero out clusters after the end of the device, this makes restore handle > it correctly (even if it may try to write those zeros, it won't fail and > just ignore the out-of-bounds write to disk). > > For not even 4k-aligned disks, th

[pve-devel] [PATCH qemu 2/2] Fix backup for not 64k-aligned storages

2020-06-22 Thread Stefan Reiter
Zero out clusters after the end of the device, this makes restore handle it correctly (even if it may try to write those zeros, it won't fail and just ignore the out-of-bounds write to disk). For not even 4k-aligned disks, there is a potential buffer overrun in the memcpy (since always 4k are copi