Re: [pve-devel] [PATCH qemu-server 1/2] add tests for qemu_img_convert

2019-10-17 Thread Thomas Lamprecht
On 10/17/19 12:09 PM, Dominik Csapak wrote: > On 10/17/19 9:26 AM, Thomas Lamprecht wrote: >> On 10/16/19 11:27 AM, Dominik Csapak wrote: >>> ... >>> +my $tests = { >>> +    qcow2raw => [ >>> +    "local:$vmid/vm-$vmid-disk-0.qcow2", >>> "local:$vmid/vm-$vmid-disk-0.raw", 1024*10, undef, 0, [ >>>

Re: [pve-devel] [PATCH qemu-server 1/2] add tests for qemu_img_convert

2019-10-17 Thread Dominik Csapak
On 10/17/19 9:26 AM, Thomas Lamprecht wrote: On 10/16/19 11:27 AM, Dominik Csapak wrote: storage config is motly copied from the config2command tests some general info about what and *how* you test would be great here. looks OK in general, and thanks for more test, some comments inline Sig

Re: [pve-devel] [PATCH qemu-server 1/2] add tests for qemu_img_convert

2019-10-17 Thread Thomas Lamprecht
On 10/16/19 11:27 AM, Dominik Csapak wrote: > storage config is motly copied from the config2command tests > some general info about what and *how* you test would be great here. looks OK in general, and thanks for more test, some comments inline > Signed-off-by: Dominik Csapak > --- > test/Ma

[pve-devel] [PATCH qemu-server 1/2] add tests for qemu_img_convert

2019-10-16 Thread Dominik Csapak
storage config is motly copied from the config2command tests Signed-off-by: Dominik Csapak --- test/Makefile | 5 +- test/run_qemu_img_convert_tests.pl | 186 + 2 files changed, 190 insertions(+), 1 deletion(-) create mode 100755 test/run_qemu_