Re: [pve-devel] [PATCH qemu-server 1/2] add support for nvme emulation

2020-05-14 Thread Oguz Bektas
hi, On Thu, May 14, 2020 at 09:27:31AM +0200, Thomas Lamprecht wrote: > > please always include the bug/feature # somewhere as reference, e.g. a > "fix #2255: ..." ideally in the subject, or at least in the commit message > would be good. will do for v2 > > On 5/13/20 5:36 PM, Oguz Bektas wrot

Re: [pve-devel] [PATCH qemu-server 1/2] add support for nvme emulation

2020-05-14 Thread Thomas Lamprecht
please always include the bug/feature # somewhere as reference, e.g. a "fix #2255: ..." ideally in the subject, or at least in the commit message would be good. On 5/13/20 5:36 PM, Oguz Bektas wrote: > now we can add nvme drives; > > nvme0: local-lvm:vm-103-disk-0,size=32G An example I can use

Re: [pve-devel] [PATCH qemu-server 1/2] add support for nvme emulation

2020-05-13 Thread Stefan Reiter
Gave both patches a spin and they work fine on first glance. We should probably assign a fixed PCI bus/addr to the NVMe devices though (same as we do for SCSI and AHCI hardware with print_pci_addr somewhere in the depths of config_to_command). On 5/13/20 5:36 PM, Oguz Bektas wrote: now we ca

[pve-devel] [PATCH qemu-server 1/2] add support for nvme emulation

2020-05-13 Thread Oguz Bektas
now we can add nvme drives; nvme0: local-lvm:vm-103-disk-0,size=32G max number is 8 Signed-off-by: Oguz Bektas --- PVE/QemuServer.pm | 20 +--- PVE/QemuServer/Drive.pm | 21 + 2 files changed, 38 insertions(+), 3 deletions(-) diff --git a/PVE/QemuServ