Re: [pve-devel] [PATCH installer] fix behavior if zfs disks have no by-id path

2020-02-19 Thread Thomas Lamprecht
On 2/19/20 4:51 PM, Thomas Lamprecht wrote: > On 2/19/20 12:24 PM, Stoiko Ivanov wrote: >>> can this happen at all for real devices? And which "virtio" devices are you >>> talking about, as "virtio-blk" isn't supported and "virtio-scsi" works here. >> Why are virtio-blk not supported? (a test vm bo

Re: [pve-devel] [PATCH installer] fix behavior if zfs disks have no by-id path

2020-02-19 Thread Thomas Lamprecht
On 2/19/20 12:24 PM, Stoiko Ivanov wrote: >> can this happen at all for real devices? And which "virtio" devices are you >> talking about, as "virtio-blk" isn't supported and "virtio-scsi" works here. > Why are virtio-blk not supported? (a test vm boots up just fine (with the > patch)) it did not

Re: [pve-devel] [PATCH installer] fix behavior if zfs disks have no by-id path

2020-02-19 Thread Thomas Lamprecht
On 2/19/20 12:39 PM, Fabian Ebner wrote: > On 2/18/20 5:55 PM, Aaron Lauterer wrote: >> in some situations it is possible, that a disk does not have a >> /dev/disk/by-id path, mainly AFAICT inside VMs with virtio disks. >> >> Commit e1b490865f750e08f6c9c6b7e162e7def9dcc411 forgot to handle this >>

Re: [pve-devel] [PATCH installer] fix behavior if zfs disks have no by-id path

2020-02-19 Thread Fabian Ebner
On 2/18/20 5:55 PM, Aaron Lauterer wrote: in some situations it is possible, that a disk does not have a /dev/disk/by-id path, mainly AFAICT inside VMs with virtio disks. Commit e1b490865f750e08f6c9c6b7e162e7def9dcc411 forgot to handle this situation which resultet in a failed installation. Sig

Re: [pve-devel] [PATCH installer] fix behavior if zfs disks have no by-id path

2020-02-19 Thread Aaron Lauterer
On 2/19/20 7:47 AM, Thomas Lamprecht wrote: On 2/18/20 5:55 PM, Aaron Lauterer wrote: in some situations it is possible, that a disk does not have a /dev/disk/by-id path, mainly AFAICT inside VMs with virtio disks. can this happen at all for real devices? And which "virtio" devices are you

Re: [pve-devel] [PATCH installer] fix behavior if zfs disks have no by-id path

2020-02-19 Thread Stoiko Ivanov
After a (not so) short detour into debian policy and the current state of policy-rc.d usage: Thanks for tracking this down so fast (and sorry for introducing the regression in the first place). The patch definitely makes sense - and works in my few tests: Reviewed-By: Stoiko Ivanov Tested-By: St

Re: [pve-devel] [PATCH installer] fix behavior if zfs disks have no by-id path

2020-02-18 Thread Thomas Lamprecht
On 2/18/20 5:55 PM, Aaron Lauterer wrote: > in some situations it is possible, that a disk does not have a > /dev/disk/by-id path, mainly AFAICT inside VMs with virtio disks. > can this happen at all for real devices? And which "virtio" devices are you talking about, as "virtio-blk" isn't support

[pve-devel] [PATCH installer] fix behavior if zfs disks have no by-id path

2020-02-18 Thread Aaron Lauterer
in some situations it is possible, that a disk does not have a /dev/disk/by-id path, mainly AFAICT inside VMs with virtio disks. Commit e1b490865f750e08f6c9c6b7e162e7def9dcc411 forgot to handle this situation which resultet in a failed installation. Signed-off-by: Aaron Lauterer --- thanks @stoi