Re: [pve-devel] [PATCH guest-common 1/3] snapshot_rollback: flock earlier

2020-04-27 Thread Fabian Grünbichler
On April 27, 2020 1:08 pm, Fabian Ebner wrote: > One not-patch-related observation inline. > > On 27.04.20 10:24, Fabian Grünbichler wrote: >> to protect checks against concurrent modifications >> >> Signed-off-by: Fabian Grünbichler >> --- >> >> Notes: >> bested viewed with --patience -w

Re: [pve-devel] [PATCH guest-common 1/3] snapshot_rollback: flock earlier

2020-04-27 Thread Fabian Ebner
One not-patch-related observation inline. On 27.04.20 10:24, Fabian Grünbichler wrote: to protect checks against concurrent modifications Signed-off-by: Fabian Grünbichler --- Notes: bested viewed with --patience -w PVE/AbstractConfig.pm | 45 +-

[pve-devel] [PATCH guest-common 1/3] snapshot_rollback: flock earlier

2020-04-27 Thread Fabian Grünbichler
to protect checks against concurrent modifications Signed-off-by: Fabian Grünbichler --- Notes: bested viewed with --patience -w PVE/AbstractConfig.pm | 45 +-- 1 file changed, 22 insertions(+), 23 deletions(-) diff --git a/PVE/AbstractConfig.pm b/P