Re: [pve-devel] [PATCH cluster 1/2] cluster: improve error handling when reading files

2017-10-11 Thread Thomas Lamprecht
On 10/11/2017 09:36 AM, Wolfgang Bumiller wrote: > When querying file contents via IPC we return undef if the > file does not exist, but also on any other error. This is > potentially problematic as the ipcc_send_rec() xs function > returns undef on actual errors as well, while setting $! > (errno)

[pve-devel] [PATCH cluster 1/2] cluster: improve error handling when reading files

2017-10-11 Thread Wolfgang Bumiller
When querying file contents via IPC we return undef if the file does not exist, but also on any other error. This is potentially problematic as the ipcc_send_rec() xs function returns undef on actual errors as well, while setting $! (errno). It's better to die in cases other than ENOENT. Before th