Re: [pve-devel] [PATCH cluster] add get_guest_config_property IPCC method

2019-06-12 Thread Dominik Csapak
On 6/12/19 2:35 PM, Wolfgang Bumiller wrote: On Wed, Jun 12, 2019 at 01:48:57PM +0200, Thomas Lamprecht wrote: On 6/12/19 1:12 PM, Wolfgang Bumiller wrote: On Tue, Jun 11, 2019 at 06:02:22AM +0200, Thomas Lamprecht wrote: + + char *val = _get_property_value(tmp, prop, prop_len);

Re: [pve-devel] [PATCH cluster] add get_guest_config_property IPCC method

2019-06-12 Thread Wolfgang Bumiller
On Wed, Jun 12, 2019 at 01:48:57PM +0200, Thomas Lamprecht wrote: > On 6/12/19 1:12 PM, Wolfgang Bumiller wrote: > > On Tue, Jun 11, 2019 at 06:02:22AM +0200, Thomas Lamprecht wrote: > >> + > >> + char *val = _get_property_value(tmp, prop, prop_len); > >> + if (val == NULL) { > >>

Re: [pve-devel] [PATCH cluster] add get_guest_config_property IPCC method

2019-06-12 Thread Thomas Lamprecht
On 6/12/19 1:12 PM, Wolfgang Bumiller wrote: > On Tue, Jun 11, 2019 at 06:02:22AM +0200, Thomas Lamprecht wrote: >> [snip] >> >> +// checks the conf for a line starting with '$prop:' and returns the value >> +// afterwards, whitout initial whitespace(s), we only deal with the format >> +// restri

Re: [pve-devel] [PATCH cluster] add get_guest_config_property IPCC method

2019-06-12 Thread Wolfgang Bumiller
On Tue, Jun 11, 2019 at 06:02:22AM +0200, Thomas Lamprecht wrote: > This adds a new method to our IPCC interface. > It's a helper to get a property of a single or all guests. > > It is restricted to only look at the current config state only, i.e., > no PENDING changes and no snapshots, this is by

[pve-devel] [PATCH cluster] add get_guest_config_property IPCC method

2019-06-10 Thread Thomas Lamprecht
This adds a new method to our IPCC interface. It's a helper to get a property of a single or all guests. It is restricted to only look at the current config state only, i.e., no PENDING changes and no snapshots, this is by design and wanted. It uses the strict config format to be quick and return/