Re: [pve-devel] [PATCH 12/19] phase3 : don't destroy local copy

2017-03-09 Thread Thomas Lamprecht
The patch semantics are OK, imo. But I'm not sure if the default behavior should be the one where we let the source VM fully intact, I'm mean a (wrongful) start could result in conflicts like duplicate IP addresses or similar. I would think that at leas an option to delete the source VM, on s

[pve-devel] [PATCH 12/19] phase3 : don't destroy local copy

2017-02-22 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/QemuMigrate.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm index 13952cb..7bd0d6f 100644 --- a/PVE/QemuMigrate.pm +++ b/PVE/QemuMigrate.pm @@ -924,6 +924,8 @@ sub phase3 { my $volids = $self->{volumes