> Also, if name is not provided,
> maybe can we add a default name : " Copy of".$orignalname ?
>
> To avoid duplicate name ?
Yes. will do that.
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-dev
r"
À: "Alexandre DERUMIER"
Cc: pve-devel@pve.proxmox.com
Envoyé: Mardi 30 Avril 2013 07:03:21
Objet: RE: [pve-devel] [PATCH 1/5] add qemu_img_convert
> I think it could be great to add a "name" parameter
yes, and a 'description'
> For full clo
> I think it could be great to add a "name" parameter
yes, and a 'description'
> For full clone, we should add a target storage and output format options.
> (I think that only 1 target storage/output format for all disks is enough)
OK for me.
___
pve-d
> >>My plan was to get this basic functionality stable so that we can
> >>include this with 3.0?
>
> Yes, I think it could be a start, we can add features step by step.
Yes (will try to do that asap).
> When do you plan to release 3.0 ?
AFAIK Debian Wheeze is planned this weekend. We want RC1 s
- Mail original -
De: "Alexandre DERUMIER"
À: "Dietmar Maurer"
Cc: pve-devel@pve.proxmox.com
Envoyé: Lundi 29 Avril 2013 12:59:03
Objet: Re: [pve-devel] [PATCH 1/5] add qemu_img_convert
>>I think create_vm is already too complex to add more functionality.
>
can add features step by step.
When do you plan to release 3.0 ?
I'll test your code today
- Mail original -
De: "Dietmar Maurer"
À: "Alexandre Derumier" , pve-devel@pve.proxmox.com
Envoyé: Lundi 29 Avril 2013 11:03:50
Objet: RE: [pve-devel] [PATCH 1/5]
Derumier
> Sent: Montag, 29. April 2013 08:41
> To: pve-devel@pve.proxmox.com
> Subject: [pve-devel] [PATCH 1/5] add qemu_img_convert
>
> also work with snapshot as source for qcow2,rbd,sheepdog.
>
___
pve-devel mailing list
pve
also work with snapshot as source for qcow2,rbd,sheepdog.
Signed-off-by: Alexandre Derumier
---
PVE/QemuServer.pm | 61 +
1 file changed, 61 insertions(+)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 4d2710a..70ca3b1 100644
--- a
I'll resend an improved version monday
- Mail original -
De: "Alexandre DERUMIER"
À: "Dietmar Maurer"
Cc: pve-devel@pve.proxmox.com
Envoyé: Vendredi 26 Avril 2013 13:59:42
Objet: Re: [pve-devel] [PATCH 1/5] add qemu_img_convert
>>Why do you s
redi 26 Avril 2013 13:36:44
Objet: RE: [pve-devel] [PATCH 1/5] add qemu_img_convert
> + my $parser = sub {
> + my $line = shift;
> + print $line."\n";
> + };
> +
> + eval { run_command($cmd, timeout => undef, errfunc => sub {}, outfunc
> =>
> + my $parser = sub {
> + my $line = shift;
> + print $line."\n";
> + };
> +
> + eval { run_command($cmd, timeout => undef, errfunc => sub {}, outfunc
> => $parser); };
Why do you suppress messages to stderr, and why do we need a $parser here?
___
> >>Why is it necessary to specify source and destination format?
>
> It's more by security,
>
> from doc:
>
> "fmt is the disk image format. It is guessed automatically in most cases."
>
> I don't like too much "in most cases" ;)
OK, lets keep that code.
__
al -
De: "Dietmar Maurer"
À: "Alexandre Derumier" , pve-devel@pve.proxmox.com
Envoyé: Mardi 23 Avril 2013 06:19:51
Objet: RE: [pve-devel] [PATCH 1/5] add qemu_img_convert
> + my $src_format = qemu_img_format($src_scfg, $src_volname);
> + my $dst_format = qem
> + my $src_format = qemu_img_format($src_scfg, $src_volname);
> + my $dst_format = qemu_img_format($dst_scfg, $dst_volname);
> +
> + my $src_path = PVE::Storage::path($storecfg, $src_volid, $snapname);
> + my $dst_path = PVE::Storage::path($storecfg, $dst_volid);
> +
> + my $cm
also work with snapshot as source for qcow2,rbd,sheepdog.
Signed-off-by: Alexandre Derumier
---
PVE/QemuServer.pm | 54 +
1 file changed, 54 insertions(+)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 4d2710a..c7b32c3 100644
--- a
also work with snapshot as source for qcow2,rbd,sheepdog.
Signed-off-by: Alexandre Derumier
---
PVE/QemuServer.pm | 51 +++
1 file changed, 51 insertions(+)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index fb672eb..b55a68e 100644
--- a/P
16 matches
Mail list logo
