> Am 01.08.2016 um 09:44 schrieb Alexandre DERUMIER :
>
>>> Answering myself, 'close' does not issue flush/fsync.
>
> close send a flush
>
> It's was introduce by this commit
>
> [Qemu-devel] [PATCH v3] qemu-img: let 'qemu-img convert' flush data
> https://lists.nongnu.org/archive/html/qemu-d
Applied. qemu-img does a blk_unref() which at the end on the device
which should eventually end up in bdrv_close() doing a flush(). So this
should be safe in theory.
On Mon, Aug 01, 2016 at 08:51:00AM +0200, Alexandre Derumier wrote:
> Signed-off-by: Alexandre Derumier
> ---
> PVE/QemuServer.pm
On Mon, Aug 01, 2016 at 09:48:17AM +0200, Dominik Csapak wrote:
> On 08/01/2016 09:44 AM, Alexandre DERUMIER wrote:
> >>>Answering myself, 'close' does not issue flush/fsync.
> >
> >close send a flush
> >
>
> ok nevermind then
Even if it didn't, if we're already patching it, adding a flush-on-clos
convert' flush data
https://lists.nongnu.org/archive/html/qemu-devel/2012-04/msg02936.html
- Mail original -
De: "dietmar"
À: "Dominik Csapak" , "pve-devel"
Envoyé: Lundi 1 Août 2016 09:37:20
Objet: Re: [pve-devel] [PATCH] qemu-img convert : use default cach
> Am 01.08.2016 um 09:26 schrieb Dominik Csapak :
>
> On 08/01/2016 08:51 AM, Alexandre Derumier wrote:
>> Signed-off-by: Alexandre Derumier
>> ---
>> PVE/QemuServer.pm | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
>> index 7778
l/2012-04/msg02936.html
- Mail original -
De: "dietmar"
À: "Dominik Csapak" , "pve-devel"
Envoyé: Lundi 1 Août 2016 09:37:20
Objet: Re: [pve-devel] [PATCH] qemu-img convert : use default cache=unsafe
instead writeback
> > is this really safe?
>
El 01/08/16 a las 09:26, Dominik Csapak escribió:
On 08/01/2016 08:51 AM, Alexandre Derumier wrote:
Signed-off-by: Alexandre Derumier
---
PVE/QemuServer.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 7778fb8..2414fd8 100644
--
> > is this really safe?
> >
> > this also impacts cloning and the "move disk" function.
> > what if i clone a vm to an nfs share and immediately move the vm to
> > another host, then start it?
>
> I guess qemu-img does a flush before closing (or flush is automatic on
> close?)?
Answering mysel
> On August 1, 2016 at 9:26 AM Dominik Csapak wrote:
>
>
> On 08/01/2016 08:51 AM, Alexandre Derumier wrote:
> > Signed-off-by: Alexandre Derumier
> > ---
> > PVE/QemuServer.pm | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.p
On 08/01/2016 08:51 AM, Alexandre Derumier wrote:
Signed-off-by: Alexandre Derumier
---
PVE/QemuServer.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 7778fb8..2414fd8 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -5
Signed-off-by: Alexandre Derumier
---
PVE/QemuServer.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 7778fb8..2414fd8 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -5605,7 +5605,7 @@ sub qemu_img_convert {
my $
Signed-off-by: Alexandre Derumier
---
PVE/QemuServer.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 7778fb8..2414fd8 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -5605,7 +5605,7 @@ sub qemu_img_convert {
my $
12 matches
Mail list logo
