applied, thanks
> -Original Message-
> From: pve-devel-boun...@pve.proxmox.com [mailto:pve-devel-
> boun...@pve.proxmox.com] On Behalf Of Stefan Priebe
> Sent: Freitag, 19. April 2013 08:38
> To: pve-devel@pve.proxmox.com
> Subject: [pve-devel] [PATCH] implement node n
Changes since V2:
- swap in / out / transmit / receive again
Changes since V1:
- new return format (use an arrayref instead of a hash to be JS compatible)
- swap in / out / transmit / receive
Signed-off-by: Stefan Priebe
---
PVE/API2/Nodes.pm | 48 +
Am 18.04.2013 08:57, schrieb Dietmar Maurer:
Is this a bug?
The code in vmstatus seems to be wrong for netout and netin
$d->{netout} += $netdev->{$dev}->{receive};
$d->{netin} += $netdev->{$dev}->{transmit};
netin is receive and netout is transmit... isn't it?
Should be
> Is this a bug?
>
> The code in vmstatus seems to be wrong for netout and netin
>
> $d->{netout} += $netdev->{$dev}->{receive};
> $d->{netin} += $netdev->{$dev}->{transmit};
>
>
> netin is receive and netout is transmit... isn't it?
Should be easy to test by downloading a fi
Changes since V1:
- new return format (use an arrayref instead of a hash to be JS compatible)
- swap in / out / transmit / receive
Signed-off-by: Stefan Priebe
---
API2/Nodes.pm | 48
1 file changed, 48 insertions(+)
diff --git a/API2/Nodes.pm
Am 18.04.2013 08:41, schrieb Dietmar Maurer:
+ $res->{$vmid}{'net'.$netid}{out} = $netdev->{$dev}->{receive};
+ $res->{$vmid}{'net'.$netid}{in} = $netdev->{$dev}->{transmit};
I also prefer "net$netid" instead of 'net'.$netid
Is this a bug?
The code in vmstatus see
> + $res->{$vmid}{'net'.$netid}{out} = $netdev->{$dev}->{receive};
> + $res->{$vmid}{'net'.$netid}{in} = $netdev->{$dev}->{transmit};
I also prefer "net$netid" instead of 'net'.$netid
___
pve-devel mailing list
pve-devel@pve.prox
Signed-off-by: Stefan Priebe
---
API2/Nodes.pm | 40
1 file changed, 40 insertions(+)
diff --git a/API2/Nodes.pm b/API2/Nodes.pm
index 0dac6af..8aebae0 100644
--- a/API2/Nodes.pm
+++ b/API2/Nodes.pm
@@ -123,6 +123,7 @@ __PACKAGE__->register_method ({